From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0AC0C77B75 for ; Wed, 3 May 2023 06:30:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 034C66B0074; Wed, 3 May 2023 02:30:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F264B6B0078; Wed, 3 May 2023 02:30:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E157C6B007B; Wed, 3 May 2023 02:30:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by kanga.kvack.org (Postfix) with ESMTP id BE52A6B0074 for ; Wed, 3 May 2023 02:30:48 -0400 (EDT) Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-5ef41569a3fso21956506d6.3 for ; Tue, 02 May 2023 23:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683095448; x=1685687448; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NSWUOSuqVLpIOWgszk2VW3MzVdJnM+9N5Gz+a5oZIik=; b=FwxsWECu6Vmz2nS2N36nqdmqGUy6EtTWCwQbQH8C4yyx7S50D7jj6hwfI3pG4WOWTe J5Ac/nm/4jjf2uonNwEk7kkgqGFkqqOlCnFifWxFhM5HBLHG5/+yNdwPcGRQZD8xyZgY y564jPge77bFOjQ7/C7PbIZo2J/D/9HIgWm1qaK+/JMqtAHJacp7Y7p+jXsMBKVPwiay de3olKWgxT5zQQmgR6+1vlYmLMhp7LATVC+UKYup+7gpwYRYwOXn88552r8N8+SfOO97 mz3mbEB+LcrH93Ca5jn3i5g7nB6tCk4YfB1Kz47lyE0ZxPdxng7OE8IRGtE3NBhEpUXq C5Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683095448; x=1685687448; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NSWUOSuqVLpIOWgszk2VW3MzVdJnM+9N5Gz+a5oZIik=; b=ahdBDH8JvS8FgVDzf3vindxA42FD0iy71SbfN8fy9TnJ7YYT7JpU/Hy7/lpAF11VCM vXNbQM2PdUqjDJ2kUmg4irO2/ZhqS55jTPy0qPKdx1l81whjpCmOOUXaSa6mnsWKOmdH dDvqKMYK/hBjF3zAwx0IN0EWmPwQsy8TmIAe4nePaI1X8eAo2vz79YVnhv6Wix2HF3uM kud6ZxNaP6Wr5vyyqusdg06ZUyKJmVDqmjjlAoXQF6LVkUvATOBhH16p+u0PD/VIw7Bd 4rT5dRwhE8VMtVIHY7x2fLTutPft33XPxSectKrXl/e6Iz9h5OS6JyjfzOq2t7RCrLRB yOeg== X-Gm-Message-State: AC+VfDzjD5snF3QdRR/QncmBcVZPr2yZTF+Dx/cekbuJ7uA79YtNoRdX zWx3V+QYXk1F7e3+Gxn3kXCdR0vhAm5PkEQK2gA= X-Google-Smtp-Source: ACHHUZ6mwR/Eb9QNNQC3EY6y0Gd5Rl8C7T1qIt5du/51986iaziD1AevtUJQS/vhAg1zqokn+I2SvW0bGzGu5uBEHP4= X-Received: by 2002:a05:6214:1941:b0:61b:5cba:5820 with SMTP id q1-20020a056214194100b0061b5cba5820mr9799913qvk.50.1683095448149; Tue, 02 May 2023 23:30:48 -0700 (PDT) MIME-Version: 1.0 References: <20230501165450.15352-1-surenb@google.com> <20230501165450.15352-2-surenb@google.com> In-Reply-To: From: Andy Shevchenko Date: Wed, 3 May 2023 09:30:11 +0300 Message-ID: Subject: Re: [PATCH 01/40] lib/string_helpers: Drop space in string_get_size's output To: Kent Overstreet Cc: James Bottomley , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, ldufour@linux.ibm.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?B?Tm9yYWxmIFRyw6/Cv8K9bm5lcw==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 3, 2023 at 5:07=E2=80=AFAM Kent Overstreet wrote: > On Tue, May 02, 2023 at 06:19:27PM +0300, Andy Shevchenko wrote: > > On Tue, May 2, 2023 at 9:22=E2=80=AFAM Kent Overstreet > > wrote: > > > On Tue, May 02, 2023 at 08:33:57AM +0300, Andy Shevchenko wrote: > > > > Actually instead of producing zillions of variants, do a %p extensi= on > > > > to the printf() and that's it. We have, for example, %pt with T and > > > > with space to follow users that want one or the other variant. Same > > > > can be done with string_get_size(). > > > > > > God no. > > > > Any elaboration what's wrong with that? > > I'm really not a fan of %p extensions in general (they are what people > reach for because we can't standardize on a common string output API), The whole story behind, for example, %pt is to _standardize_ the output of the same stanza in the kernel. > but when we'd be passing it bare integers the lack of type safety would > be a particularly big footgun. There is no difference to any other place in the kernel where we can shoot into our foot. > > God no for zillion APIs for almost the same. Today you want space, > > tomorrow some other (special) delimiter. > > No, I just want to delete the space and output numbers the same way > everyone else does. And if we are stuck with two string_get_size() > functions, %p extensions in no way improve the situation. I think it's exactly for the opposite, i.e. standardize that output once and for all. --=20 With Best Regards, Andy Shevchenko