From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA22CD6E7F for ; Wed, 11 Oct 2023 15:36:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2ABA8E000C; Wed, 11 Oct 2023 11:36:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD9BC8D0050; Wed, 11 Oct 2023 11:36:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C8ED8E000C; Wed, 11 Oct 2023 11:36:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8DD958D0050 for ; Wed, 11 Oct 2023 11:36:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 56D571A019C for ; Wed, 11 Oct 2023 15:36:50 +0000 (UTC) X-FDA: 81333583380.22.499DAE1 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf17.hostedemail.com (Postfix) with ESMTP id 8E68F40020 for ; Wed, 11 Oct 2023 15:36:48 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m4Wsjbaq; spf=pass (imf17.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697038608; a=rsa-sha256; cv=none; b=uUg0msnw7UWBUoHnMQTNxLY6zhqwbsAFm+PEvkBoKt9MQn673VTS+d5t8m1w2Bx1e3HUvX OmUByp83Ojo4IqlWuXT3OPtx2RIPB87LAuXtQ49cNLcFmUUIGV4FwnGI57N9uV0JxIjEi9 pLqbHc0gcd7kMBDL2UxdfJJefMXVlLg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=m4Wsjbaq; spf=pass (imf17.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697038608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3d70RV8D3q4Lw0yJT/tGgP8JEXxsa+Fuj9xKAysUS94=; b=fKvDIBFMipVx0AA6H6MS/8XNHkhtJHyCRAndkbKx/ASmqFh6V6BJ4ctOdjoSw2oEBbU8AW 2PEtwXU5DoNSZL+5fRbjIZdRxhqN6NWLuCV+rjs1C0iLUWU18IWcTrnqv6mhUNSII8vGsc GnzdV68h9SVrR5xeG1QZx56Aw1vJwGU= Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7740aa4b545so467977885a.3 for ; Wed, 11 Oct 2023 08:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697038607; x=1697643407; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3d70RV8D3q4Lw0yJT/tGgP8JEXxsa+Fuj9xKAysUS94=; b=m4WsjbaqKzPGmFfmCGdMnJwemr5ILJkhz1JgZi3TM/avEZVdFzo2rlOXpy2aeVHRU5 RsBOvAyS9Dh6qpUyXuv6dlPKfn/hzgKFMrQVjgzNWdN81tcpWAVwwVYMhtkSM5lfj5nm jYP7lDQVcacFRhGRxjkyY3q0pFkRJlCMGUtbpNfKSd+sLDlgBNYtPerp+b/bIMwj0fVM sWbgKSZLxiVCvE8kEimLeRG45QepbbERvC+eTnMQeM1o0lXeu2eOIw+RojIhpdjgwnDS oNahj5WjC4ePbCP1jyvNd6x3SV3IPqrRQIDI/T+jd3igcqR6WKcc8a39EPFPgMw8kakq 77sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697038607; x=1697643407; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3d70RV8D3q4Lw0yJT/tGgP8JEXxsa+Fuj9xKAysUS94=; b=Xq+eIeqDqy/UVJa6dXVD7ycUvj7zMP5dojjs/53c4Pff/87FtOBR0kh1nQymrbtffg h8+uCaJu9vWi7tF46VMdn+7Dwmo/sjWFAsqYhjNMiUrGhxtNXCvpLKNJftDnKHJU82DA 2Ahj3sJTgvhuys/NWQFe8WSTilC9mIw2H6LX1hnIzcXDOFvV6t+fAtPh9a67k2eR13nL kfT9uMOxnWruQsEDr9bIy9yCiZAFMC9KhhNwdaI1DehXOt3g1777k8b2YhtD1DuIS6dz 1kO+Npj3hY9emWdLsAeYnSZzvO4CXqC3wugs0ro6+NkmTwvg7UWmLi6U+vXSJHMiN1aa n//w== X-Gm-Message-State: AOJu0Yyp/POGcKH3MTAIP6yXoRfkkfwC3ebeIe04BVU3sdxGe4Hr3gJF K6WPw4Jgk9shF3XJu/HkkTX9wissrEsvIAK8ax0= X-Google-Smtp-Source: AGHT+IFU1SyCP9HwZEqNMLh2P+CII7WW5qTkTr5uJLytAwl8ChOtAUnXs0neArcgm7RUqu0fppbZXGkflHXFbWQDwrI= X-Received: by 2002:a0c:8cca:0:b0:65b:1802:4f3c with SMTP id q10-20020a0c8cca000000b0065b18024f3cmr18358578qvb.21.1697038607513; Wed, 11 Oct 2023 08:36:47 -0700 (PDT) MIME-Version: 1.0 References: <20231011093412.7994-1-kkartik@nvidia.com> <20231011093412.7994-2-kkartik@nvidia.com> In-Reply-To: <20231011093412.7994-2-kkartik@nvidia.com> From: Andy Shevchenko Date: Wed, 11 Oct 2023 18:36:11 +0300 Message-ID: Subject: Re: [PATCH v4 1/8] mm/util: Introduce kmemdup_array() to duplicate an array To: Kartik Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, keescook@chromium.org, andy@kernel.org, akpm@linux-foundation.org, arnd@arndb.de, petlozup@nvidia.com, pshete@nvidia.com, ulf.hansson@linaro.org, frank.li@vivo.com, robh@kernel.org, stefank@nvidia.com, pdeschrijver@nvidia.com, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 8E68F40020 X-Stat-Signature: n94upkwa6ad647fpboh7qzwsr9wqntza X-Rspam-User: X-HE-Tag: 1697038608-562431 X-HE-Meta: U2FsdGVkX1+YRwlh4Z3mfJjebHisgv/39HCvWOs4GdvPseGawjt/MTLw9vaI5DeUiL8wtQ02n78xNQRDRikxX7L0uVylQRaGl7i5eGukraCs3900ivM+//yIGOatYSXgeTqfP2DUHmnlvhsvZp8iJnzXIoWYg6nQfKxF8QM9Dt+M+JIV0YzmsvAUQuhvOmh6ZLf8MEh/abfRDt+hjaendqh4aLr39cvEWaJFuBGJ/N8pA/9b08pL68cph3Nn6sVNnteusncAcorYfPY+d/T1jJQKyb955jUaw5biY/ZfcQxmtoq0Q+LBsbRfpjZH1IgimA73KVwV7qHrl4ijteUaZeQYTt5pAWexWiXWOkjfuwbDi7Yq1uG2fbP7QNac63neisXlZnNjYvwkJm0kvmJfiQMgD20SjokQzOpx2CG1HWg4yXDbZ1zZ/OvBjNvjjgc66PJ8JAqYAZn/sixfSm+OPGNpv/n5clOw8PugG6GcVq/LW7rafZEIQJrQQDDpfJmpHsglb66MQDPAnmQAX3o0cgqQqv11JPbSUuAL5UgMHfIXq63dduPVcIhK3Er3fReJSbubzI8/kizW6T8M3KioIMthAP3ZznLPvh0wfk/5BgFU8GbxWYKmo7Pu68nvCgDyj5Q2+BgC71uvkrEjULTOTpc5+2qkDnBT5YiBTBZmmttBRZH14r2wqAxFcoX1MJ5goZWTycqf8h35EZLpTuyjyZfBDl91qTH3oUyGWPGYontDo0g9iRRDdoUJuNovUb8mfNeEp2nmI7ryHP/B5xpYlC/nlYzuO0yTwmhdoiJK0rOtdddqIUo//wcgrH5aWcSNBV59q1OUwy2oF9wPGjVw34Bs20ARF+L8tcuJ1ArCNMulug3qfQeq77MZTLoMEx7VvG8ix192U+41OjJ+SBIw2ho3AYv6+gydeVh3MpFAFibT6FzWKxnYcY06iUQx6hECYY1Ry33uBMiy1KXbHzc 9JhlkWNQ PRAVxi41jO+tcnIzux3yauFMZKXnFjd+cKC5HooHAsu1h7/tETscVVfOBMK6B0E7ZO/bo4mcWcK8uHKuv/Z02otKdWT8yqW9VyWKKyKeUOhzKFVAJxQsOqQvgP8tBPIkKkmMet3O6ScaYgc7dEplC7BvUDAsERzlxFhQqtDa4H7AavdImZ4vUbOW695Hm2pHBqa0CtXSYK+hjWxJzY2AwZvYb6pD34SaEiIPAo+Gl+zl5sqjNr4Yv62EXGwRUDR0+DdzHr6VLBI36z/Qr1wXXcSE7sAEubzKUUkgr7sMgpLRj3+ZtB0IdWj8lqU2lItcDAwrmlechHxTOD9mTaWhcCvXqpqZeRJJZKkz7aCD+ylkzoJoRNNZh3UZCUDY2yH5QCTTLCqGnjaxVHIclEPZ7AK3iDQtKj3W2Y1V6UrcA8zCuQX7vTlAq751fXQJ9LVqLtb0wYtrQrMnLjNyhArdKznZ3zuj6SWijWXiD6vKOQF1JswcDoUtjTyRG6+piTZrKRsi8ued9/tN1evM8D3Sj3Mq1hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.003189, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 11, 2023 at 2:17=E2=80=AFPM Kartik wrote: > > Introduce function kmemdup_array(), that will copy `n` number of > elements from a given array `src` to `dst`. > > On success, kmemdup_array() returns 0 and copy the elements from `src` > to newly allocated array `dst`, it also stores number of elements > copied from `src` array to `dst_count` parameter. On failure, this > returns a negative integer value containing the error value. Hmm... Why is it so complicated? Can it be as simple as return kmemdup(size_mul()); ? -- With Best Regards, Andy Shevchenko