From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DD2C48260 for ; Tue, 13 Feb 2024 08:30:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 198016B008C; Tue, 13 Feb 2024 03:30:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 123406B0092; Tue, 13 Feb 2024 03:30:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB5B46B0093; Tue, 13 Feb 2024 03:30:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6DA76B008C for ; Tue, 13 Feb 2024 03:30:15 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 85E90160167 for ; Tue, 13 Feb 2024 08:30:15 +0000 (UTC) X-FDA: 81786108390.12.0DA6C40 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf28.hostedemail.com (Postfix) with ESMTP id AD185C0018 for ; Tue, 13 Feb 2024 08:30:12 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F7aipUl3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707813012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UVoibj/kriuj68qpqrmYwyDO76NZZTUK51M4zJowuXg=; b=ZvO7YWGfwui/uuwL8iu9jmTNZ9EoF7XD/KMntgTtOx6o5+4yi69hAciaoMxj1Dkfjg9s8D 1y8L2WRUnFxSjyHBElp4Y3SgN5KB2viYGP+uv6b46xxS+BomXcn+G2I7Et1BsqnHgw5nA3 97QtDmb9CspsUMXZAkeLG2pUD3NxhbI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F7aipUl3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of andy.shevchenko@gmail.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707813012; a=rsa-sha256; cv=none; b=DoHRKfkbG1/kohNtn6SZ1wAt8C3Hy0Cqfm0P3hrdxWnmQ63sD/LlAzeWuJbnM6eiKAC1pe qxy6D2XnhziKM7yBP8IVtBkNgcPvxE8s5TPv4BHX+T97R55V64GhL+s10P3NJhQZ8/a2su f2x/vJ8N2mVRvGB6W3LIcSxzK8zYWHo= Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a3cc8f0c97fso166319766b.0 for ; Tue, 13 Feb 2024 00:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707813011; x=1708417811; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UVoibj/kriuj68qpqrmYwyDO76NZZTUK51M4zJowuXg=; b=F7aipUl3M/cEYX2psVnaxXb5/s5J/to1L5i3uUc+gOi1xOLWRZi1LW1zaNdf+1JTwO tI4LfDu1NQyslAuAbNyRMSqJNHlWynE67JCoXidz6wr9FYmgKKldZAC+Uj/b/1V+Yc8K geG7EkrgN++wKtLL3cvRBMM0jps+n/UzNLuJdXEAbw2rRq1G0SAaC13QU0SmGmPCt8g8 YOKdwu53w6PCvDsTMsTulB5AmnXDw6To9+rV+XbgVsMO5pzmuHZh5BH9s9Lt26yJaV41 n3muLszt92fPsd5BvFZstziC0ebBqwvNmjv9ns0EzNPr1nEJZSw0mxM0dwAfm8wrM+/n 75gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707813011; x=1708417811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UVoibj/kriuj68qpqrmYwyDO76NZZTUK51M4zJowuXg=; b=eSICbl1BbRZpqLV9Qgz3ieGFDTlDrxsVB7vDR0o810FsrDrTD8dzqAZ+4cTfW5+D// c1RhsZC09g8yFgStAeeYqTMcgnRNuWgRfXdKZgksoUTXBElM/5eDRfqmzNEONK9rvl0q OLigcaaoPVNwZ3mpGFI5AUbrKFCkxHeFNZBLjdrx5RtZ6zKsmAnVhAsJ8Sb8ppabT+d0 0S4n3YdxHUYdfZUdLdCKj582mvahNLNMLc9YjOFG8mVH+1HUVMR9X3+FR1xs2KSycOZe 9PTAOmJJwX3N57PsOdFfLpfLoj7M02wZRhMNRdpckQjFqyovIG4IBYkkcN1jvvaXP/dP iUkQ== X-Forwarded-Encrypted: i=1; AJvYcCVdvxLGIFqqA2kkMhaSSAofM/1SpwJx5lS0jssNvGds5rMsfe+dv7lNn1BkfoE4bnefZt+fcmC6T7+9ZczcZqDfVtA= X-Gm-Message-State: AOJu0YzFBdT8FKdkZ6YZuaCFK+WIoEEeUktScbhdUGVUV3JuCJgY7AR4 2O3ItFX2BgOFYl+w3oh9/NQzudzrNyNeuSmpw/X5eFaOQT39I3rhFg7z6wUYKZSpTzaDft75cjt x0TBRayDEa+0vvS6QZnXlBKv6SLQ= X-Google-Smtp-Source: AGHT+IGx/YbYc3+LQ8reBTPjQn19LHdQNalJWBrwb4F8AS6CetNmE5OP52aorlUQ8qqrg2PWp0Ni3QIDkvdkx5+GGkc= X-Received: by 2002:a17:907:7896:b0:a3d:704:d688 with SMTP id ku22-20020a170907789600b00a3d0704d688mr613690ejc.47.1707813011047; Tue, 13 Feb 2024 00:30:11 -0800 (PST) MIME-Version: 1.0 References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-2-surenb@google.com> In-Reply-To: From: Andy Shevchenko Date: Tue, 13 Feb 2024 10:29:34 +0200 Message-ID: Subject: Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size() To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AD185C0018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: cm8zw36354pacehxh1ikdqxru4bh36dm X-HE-Tag: 1707813012-318620 X-HE-Meta: U2FsdGVkX1+zinF6lP1n8ENHbOSgh/9CgeE7VNdZdHgYo6RqzAPuG3ZC0lskNE2npQs+VKnj4U/X0owX6+H7Qn9UM8bvclzOnoEN5vfaB73JwHb3ktomjmRokynIO6So3yVK6slHrkdvRKmh0GZXCQ9rzDlnSY+2OdwWUfyQ4L4636xM/PIXdmP1076Hutx/b2T/pOm+gwAMZfaQ2UdKjhEKe08QiHOE2859ojF1Nj0q8i5hSFFRIXaLK/j/4TArVZBqvXKHGNMvctUx0BTed/vS5mGl2++uNQ0/CukOp3dVRiFk+CNfUd6PVg/E/SsrUS3/CPJJAbn55Nzn3x1jSBPUPUwlJhYyB50n+gVZklb/X/JUfE6x03VohmIAibRsYeJrnbxSE4pJ5dTiPmSE9hZTY5DdOzNtKCv11c42WpTT6JxUGJyjzsxJYQyLG7aD8kFp0nnH6dng4CyaXkr4T3cGCAaz3qsf43CIR2tmKnBgKBivwDzdX7TNkl/XbrTZofZgq6biGFocf3xvieNEPCzaxAHR/SUzmnd30yHiCxtx/Okg22HnOc0B0vg7n5JoevGzDwrHiTxMiOnRrrMbcI6IA0o73H5F7rbUrl0BPfaVeY1Gu4tNXbppPQVEQLw0V96HVNI1KUcEI8l8Xhjp0A+0p86wX3EHjgcIWuy+YXNF4YHs+CfCBRRy9Rybs4Hdf155rDeFRH3WW06s3YYBdc85kR8rl7Ykds5+T0wAeKo5GkkzH4F10JRwXufsm4eE+QwoOo9MvqEO9pGTMqLTghXUS6Uu+14e4aaOWuYiIIEkIliPzk+PFO5THm2aT+nZs462AArzivrlmeUdWPemHiS9fqp57RO6DbuYS1ZghAoTcRPLAGyqdD3X9fcOkDUY39e5PZGhrXGBZgDpRtlsPSZD8NBclaWD4tmH8NuIhsYqKunp+CFRuk/G7d/1wPKZjPrgwiEhGPM2LXkhb+F qAEDjZeU Vw9mnERocl99omLlY6UDM6pfkXt2//UNPxC5oQMF7qGWOt72WZvRj1DHjJtLRdiIyH4cj2X0DhZWlJQmxNzlMbGqODd2RjtVPLDzH2c1MmrTc6h4PvvrrCFhPUjDKjWRqkRV4xYZX3NXuE5T+8TQU3Qich60o8r2ddAXozsEGTT5FMU1LP91XmjCJ0K+yhMgwaabKdrw5S+FrKBTL4laR+YD6r/LA4U7WLyOqps4kRJXwHdNc7wzkSpkPXEYLFRUUB/EtVmopErecsD0SuppLMGUBt3aHO7YOHxo9NRS71N4H2g7e9kezOFXCWrMDtDDl6989oLBuGrjo3N1ttyGbihEEHGbF+f/0Z7ZYgtwYvOTRuDxjdvx2g+/Q+ahnOoIXN8WrWYik77jP9yEOjDmtN3Rwg7yF26XvrI/AgAC9auPRZhhvIjx8MDrfww5PyHok8HlN8PeUMCBVtZKGrix6ju5WbhLjDrcJ0A8wSbLVOlI/fxlrz9YENORWVtpaM6eTCg0k2VjexRUbFEEqpuyHTTqkvFAi3H1S8t2P9zo/+ZFfvt3riDoNjHnYp78yBJmx8l7k6hFhl6mWcAirGI64cnZB6WTom2hjxe+d9wwG9gLtMp5P7pbLRSYbYy7GZwCiqn9U2+dbQxZB2o2xltyfKYjpTNRAc92BfVIaD86wuiv2g+7nlSodUucPQzknqklnPAw6ZqpF97/R6mQclBHieZ4rgJqq4N4k0sGdTiduR7gMKO8H+QTKoo0Zt++V2KiQKSJm7l0htlOwLXiuA7GeqiNkykjRfUaRGn8PsnrHcCcW00itPQjJZ3EcWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 13, 2024 at 10:26=E2=80=AFAM Andy Shevchenko wrote: > > On Mon, Feb 12, 2024 at 11:39=E2=80=AFPM Suren Baghdasaryan wrote: > > > > From: Kent Overstreet > > > > The new flags parameter allows controlling > > - Whether or not the units suffix is separated by a space, for > > compatibility with sort -h > > - Whether or not to append a B suffix - we're not always printing > > bytes. And you effectively missed to _add_ the test cases for the modified code. Formal NAK for this, the rest is discussable, the absence of tests is not. > > Signed-off-by: Kent Overstreet > > Signed-off-by: Suren Baghdasaryan > > It seems most of my points from the previous review were refused... > > ... > > You can move the below under --- cutter, so it won't pollute the git hist= ory. > > > Cc: Andy Shevchenko > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: "Michael S. Tsirkin" > > Cc: Jason Wang > > Cc: "Noralf Tr=C3=B8nnes" > > Cc: Jens Axboe > > --- > > ... > > > --- a/include/linux/string_helpers.h > > +++ b/include/linux/string_helpers.h > > @@ -17,14 +17,13 @@ static inline bool string_is_terminated(const char = *s, int len) > > ... > > > -/* Descriptions of the types of units to > > - * print in */ > > -enum string_size_units { > > - STRING_UNITS_10, /* use powers of 10^3 (standard SI) */ > > - STRING_UNITS_2, /* use binary powers of 2^10 */ > > +enum string_size_flags { > > + STRING_SIZE_BASE2 =3D (1 << 0), > > + STRING_SIZE_NOSPACE =3D (1 << 1), > > + STRING_SIZE_NOBYTES =3D (1 << 2), > > }; > > Do not kill documentation, I already said that. Or i.o.w. document this. > Also the _SIZE is ambigous (if you don't want UNITS, use SIZE_FORMAT. > > Also why did you kill BASE10 here? (see below as well) > > ... > > > --- a/lib/string_helpers.c > > +++ b/lib/string_helpers.c > > @@ -19,11 +19,17 @@ > > #include > > #include > > > > +enum string_size_units { > > + STRING_UNITS_10, /* use powers of 10^3 (standard SI) */ > > + STRING_UNITS_2, /* use binary powers of 2^10 */ > > +}; > > Why do we need this duplication? > > ... > > > + enum string_size_units units =3D flags & flags & STRING_SIZE_BA= SE2 > > + ? STRING_UNITS_2 : STRING_UNITS_10; > > Double flags check is redundant. --=20 With Best Regards, Andy Shevchenko