From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
"Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
syzbot <syzbot+4c882a4a0697c4a25364@syzkaller.appspotmail.com>,
akpm@linux-foundation.org, davem@davemloft.net,
herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [syzbot] [crypto?] KASAN: slab-use-after-free Read in handle_mm_fault
Date: Thu, 18 Jul 2024 18:51:59 +0200 [thread overview]
Message-ID: <CAHmME9rugxJiJTVCr5tdz5_YHcJVFckubQfK6Xn9TCuua5o1JA@mail.gmail.com> (raw)
In-Reply-To: <CAJuCfpEQQ4dKOwS8a9dRgwWtqR7LyKMx2Qr8vjaBu=CM4dNSCw@mail.gmail.com>
Hi Suren,
On Thu, Jul 18, 2024 at 6:49 PM Suren Baghdasaryan <surenb@google.com> wrote:
> > > Warning: It is no longer safe to dereference vma-> after this point, because mmap_lock is dropped, so vma might be destroyed from underneath us.
>
> Better but I would change "mmap_lock is dropped" to "mmap_lock might
> have been dropped by __handle_mm_fault()" because mmap_lock is not
> always dropped by __handle_mm_fault(). Technicality but better be
> clear about it.
> With that changed feel free to add:
>
> Reviewed-by: Suren Baghdasaryan <surenb@google.com>
Will do.
Thanks,
Jason
prev parent reply other threads:[~2024-07-18 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-16 8:29 syzbot
2024-07-18 10:59 ` Vlastimil Babka (SUSE)
2024-07-18 15:43 ` Liam R. Howlett
2024-07-18 16:20 ` Suren Baghdasaryan
2024-07-18 16:23 ` Suren Baghdasaryan
2024-07-18 16:36 ` Jason A. Donenfeld
2024-07-18 16:42 ` Suren Baghdasaryan
2024-07-18 16:44 ` Jason A. Donenfeld
2024-07-18 16:49 ` Suren Baghdasaryan
2024-07-18 16:51 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9rugxJiJTVCr5tdz5_YHcJVFckubQfK6Xn9TCuua5o1JA@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=surenb@google.com \
--cc=syzbot+4c882a4a0697c4a25364@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox