From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40DF2C433E0 for ; Tue, 16 Jun 2020 19:52:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D91A5207C4 for ; Tue, 16 Jun 2020 19:52:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="auHBa5AE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D91A5207C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=zx2c4.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 50B6B6B0006; Tue, 16 Jun 2020 15:52:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BCCC6B0007; Tue, 16 Jun 2020 15:52:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3ACF76B0008; Tue, 16 Jun 2020 15:52:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0227.hostedemail.com [216.40.44.227]) by kanga.kvack.org (Postfix) with ESMTP id 232216B0006 for ; Tue, 16 Jun 2020 15:52:01 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BB19A15535E for ; Tue, 16 Jun 2020 19:52:00 +0000 (UTC) X-FDA: 76936120800.19.ghost76_480d3e826e01 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 8F10738EE3 for ; Tue, 16 Jun 2020 19:52:00 +0000 (UTC) X-HE-Tag: ghost76_480d3e826e01 X-Filterd-Recvd-Size: 5134 Received: from mail.zx2c4.com (mail.zx2c4.com [192.95.5.64]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 19:51:59 +0000 (UTC) Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 0a066358 for ; Tue, 16 Jun 2020 19:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version :references:in-reply-to:from:date:message-id:subject:to:cc :content-type; s=mail; bh=7vGnD2Fc5hFa6zE6l8I/6fYFWTE=; b=auHBa5 AEe5pm5r80dgWM49RbxNg2b1wePIyReSMQ0Rz/3L8Yx5mFtqdklxmmgnU69XYlJN hUBaHFgVJALywQiz6/SIkttoZgX1tGyz+Zg+VQcgVldFachBs52tuPslyyMFQ0LX thiKjEu3HP7G7pjaS6Q85sWuiJrjwSZZouMci0xDSFLn39VuLeRw1x/kWL7uYtnC q9lJ9u4WEJkyqJPlHNMFgYZ8GQhbEM4aqhZNPWgxeSvHzabhX4d1A2W++bIgoNgb 5POprpu6DVgEzddWZ80fiiLd2tnSpz4DTk3KcXvzj6IQwWQeVy1VhdN6Y6LpuXnz 67qrTsLtz03/PXLw== Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 563319d5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 16 Jun 2020 19:33:58 +0000 (UTC) Received: by mail-io1-xd29.google.com with SMTP id s18so3192231ioe.2 for ; Tue, 16 Jun 2020 12:51:58 -0700 (PDT) X-Gm-Message-State: AOAM530iXUuEwytgzYxD2JocdxRtFQRVjyN0Ez94ZvFs3Z+5k6BwQ/IS g6VaeyzDfwjUWtLM9xllBl+nWW08jBxpsaJk3OM= X-Google-Smtp-Source: ABdhPJxC2pRunaModJX8LCWHauaz4Ko5hXWZ58PHme1+4UYNCmQGIC+iarFUNAqn+rNJyw3DywT6LsxlwSFMRJ3z3pU= X-Received: by 2002:a6b:6705:: with SMTP id b5mr4346341ioc.29.1592336817452; Tue, 16 Jun 2020 12:46:57 -0700 (PDT) MIME-Version: 1.0 References: <20200616015718.7812-1-longman@redhat.com> In-Reply-To: From: "Jason A. Donenfeld" Date: Tue, 16 Jun 2020 13:46:46 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/3] mm, treewide: Rename kzfree() to kfree_sensitive() To: Joe Perches Cc: Waiman Long , Andrew Morton , David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Linus Torvalds , Matthew Wilcox , David Rientjes , Michal Hocko , Johannes Weiner , Dan Carpenter , David Sterba , Linux-MM , keyrings@vger.kernel.org, LKML , Linux Crypto Mailing List , linux-pm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, Netdev , linux-ppp@vger.kernel.org, WireGuard mailing list , linux-wireless , devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-fscrypt@vger.kernel.org, ecryptfs@vger.kernel.org, kasan-dev@googlegroups.com, linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org, linux-sctp@vger.kernel.org, linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-security-module , linux-integrity@vger.kernel.org, David Miller , Steffen Klassert Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 8F10738EE3 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 16, 2020 at 12:54 PM Joe Perches wrote: > > On Mon, 2020-06-15 at 21:57 -0400, Waiman Long wrote: > > v4: > > - Break out the memzero_explicit() change as suggested by Dan Carpenter > > so that it can be backported to stable. > > - Drop the "crypto: Remove unnecessary memzero_explicit()" patch for > > now as there can be a bit more discussion on what is best. It will be > > introduced as a separate patch later on after this one is merged. > > To this larger audience and last week without reply: > https://lore.kernel.org/lkml/573b3fbd5927c643920e1364230c296b23e7584d.camel@perches.com/ > > Are there _any_ fastpath uses of kfree or vfree? The networking stack has various places where there will be a quick kmalloc followed by a kfree for an incoming or outgoing packet. One place that comes to mind would be esp_alloc_tmp, which does a quick allocation of some temporary kmalloc memory, processes some packet things inside of that, and then frees it, sometimes in the same function, and sometimes later in an async callback. I don't know how "fastpath" you consider this, but usually packet processing is something people want to do with minimal overhead, considering how fast NICs are these days.