From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: aryabinin@virtuozzo.com
Cc: Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, Andrew Morton <akpm@linux-foundation.org>,
kasan-dev@googlegroups.com, Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Shakeel Butt <shakeelb@google.com>
Subject: Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"
Date: Tue, 19 Jun 2018 22:17:25 +0200 [thread overview]
Message-ID: <CAHmME9qqsgz2faVP8FTbJvKTzX-5qQU1aHGbkzT6b05PZ4nkuw@mail.gmail.com> (raw)
In-Reply-To: <46ca5661-4bd1-6733-0140-d6e6dea1ab33@virtuozzo.com>
Hi Andrey,
On Tue, Jun 19, 2018 at 7:33 PM Andrey Ryabinin <aryabinin@virtuozzo.com> wrote:
> What's the status of CONFIG_SLUB_DEBUG in your config?
>
> AFAICS __kmem_cache_empty() is broken for CONFIG_SLUB_DEBUG=n. We use slabs_node() there
> which is always 0 for CONFIG_SLUB_DEBUG=n.
>
> The problem seems not limited to __kmem_cache_empty(), __kmem_cache_shutdown() and __kmem_cache_shrink()
> are also rely on correctness of the slabs_node(). Presumably this might cause some problems while
> destroying memcg kmem caches.
CONFIG_SLUB_DEBUG is not set in the crash I sent.
Enabling it "fixes" the problem! This either means that KASAN+SLUB
should enable SLUB_DEBUG, or the extra overhead from SLUB_DEBUG is
just making the bug more rare but not actually eliminating it.
Jason
prev parent reply other threads:[~2018-06-19 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 2:51 Jason A. Donenfeld
2018-06-19 3:59 ` Shakeel Butt
2018-06-19 4:08 ` Jason A. Donenfeld
2018-06-19 4:55 ` Dmitry Vyukov
2018-06-19 13:04 ` Jason A. Donenfeld
2018-06-19 13:16 ` Dmitry Vyukov
2018-06-19 15:08 ` Shakeel Butt
2018-06-19 15:18 ` Jason A. Donenfeld
2018-06-19 19:21 ` Shakeel Butt
2018-06-19 20:20 ` Jason A. Donenfeld
2018-06-19 5:06 ` Shakeel Butt
2018-06-19 13:25 ` Jason A. Donenfeld
2018-06-19 13:30 ` Dmitry Vyukov
2018-06-19 13:40 ` Jason A. Donenfeld
2018-06-19 17:34 ` Andrey Ryabinin
2018-06-19 20:17 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHmME9qqsgz2faVP8FTbJvKTzX-5qQU1aHGbkzT6b05PZ4nkuw@mail.gmail.com \
--to=jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox