From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA7AC77B73 for ; Sat, 6 May 2023 17:34:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36A7B6B0072; Sat, 6 May 2023 13:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31AC76B0078; Sat, 6 May 2023 13:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E2C26B007B; Sat, 6 May 2023 13:34:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0EAF36B0072 for ; Sat, 6 May 2023 13:34:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BBC09A064F for ; Sat, 6 May 2023 17:34:53 +0000 (UTC) X-FDA: 80760530466.22.FCFEFF5 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf27.hostedemail.com (Postfix) with ESMTP id B2D0E40002 for ; Sat, 6 May 2023 17:34:51 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IB8OZDsK; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683394491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wkfiFO2TAu8U9TzXRHy7r3/97lK8Wf22UerAhikqYj0=; b=5H2cXiwfJ21/ddcbrRghgC7SGyySLFEE07u2M34DcMBZRrpmNf+aL3CbCz9LuRS6uBld1y CNnL3uf3FQf9d4RdaxJNunctAhqnLd9cWBoUv5j6YbApNdD4e3x7DW+OX/QS4ps0jr/pc4 nfEmxK0d3Q+AFufoa/Xuo5a3+YjywV8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=IB8OZDsK; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683394491; a=rsa-sha256; cv=none; b=k2od/rzp1/WtuRT/99sHKvh3+DfY0qVFi3PnKlIk6sOj550ACeD2Yoov8AE6S7Y1RFVxzp W7ehb2w+7JmgZ19mjvekr2GLiZ2Ol0qutlAZeHBYx0/Bzsm1L2E2rRTdvH03XkesD8rjn1 hwjW9Gz+2G8BciRxgjclNyEYD7JGtPw= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-50bcb4a81ceso5352820a12.2 for ; Sat, 06 May 2023 10:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1683394490; x=1685986490; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wkfiFO2TAu8U9TzXRHy7r3/97lK8Wf22UerAhikqYj0=; b=IB8OZDsKqukrdCqerhCFBXPVfcEzoh7yZOTKsB1J9ymovJScitXh/cuXnG3j0KG2pC yRzx7KlbRzmBE25HCjCRffs4XW6VLsP74bOCCqUlnJmdUEVWsNnvZhTKpew0VdjbrNHI g13+tSbQXFwIeqORrjq8RXOnUaPkCSn3whIq4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683394490; x=1685986490; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wkfiFO2TAu8U9TzXRHy7r3/97lK8Wf22UerAhikqYj0=; b=VjlY03qBJreqaKByjkY02CLKwGjK4LyB9gGW80vpyQfX6NbP75mpLHBlJDmeEDnxjB iM4WKYTCzUu1Ho8lGzY3zLkxdcZSyHW661P0UR7T5usm2n9v9z0U3lo1qe6RA4sM5tai IrjwgPm7LpTPmIM1hlBO06CE3GhDL29FiZgsjFfk0u6+TjbvfrsxJJkuofHPlxadiWw4 68laHkUnJWukh9VLZlyimTIWMCoGVfSLQXG3ybUODAMKeM5jBO3ZWxd8i82ncsiFLytK yV6SDcB2HLo0ktSoj8/gnrZT3h8x8PbNDo0osRDKl3iGCXVTU5ZCUwVZAp76A/8zPueH Phrg== X-Gm-Message-State: AC+VfDwfkUcCNbtUMi8vSh4bVWZj77DPseOuLarCI/L0koFaDBRZ1xHo cik3UZrrTXnnVjadSMYkebBaGWJQXYP3v9Av+IFIOQ== X-Google-Smtp-Source: ACHHUZ4KTNC9JaBSt5gEwZuJtlmvM785icuS4TPwRMFnIMm+sEYRnDjAC0y1e/e7xbtzkpemPCIGaQ== X-Received: by 2002:a05:6402:493:b0:50b:c981:1fc7 with SMTP id k19-20020a056402049300b0050bc9811fc7mr4296305edv.19.1683394489999; Sat, 06 May 2023 10:34:49 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id l10-20020aa7caca000000b005083db60635sm4206966edt.34.2023.05.06.10.34.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 May 2023 10:34:49 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-965f7bdab6bso292154366b.3 for ; Sat, 06 May 2023 10:34:48 -0700 (PDT) X-Received: by 2002:a17:907:360c:b0:94a:845c:3528 with SMTP id bk12-20020a170907360c00b0094a845c3528mr4237253ejc.45.1683394488588; Sat, 06 May 2023 10:34:48 -0700 (PDT) MIME-Version: 1.0 References: <20230506160415.2992089-1-willy@infradead.org> In-Reply-To: From: Linus Torvalds Date: Sat, 6 May 2023 10:34:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] filemap: Handle error return from __filemap_get_folio() To: "Matthew Wilcox (Oracle)" , Josef Bacik , Johannes Weiner Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Dan Carpenter , syzbot+48011b86c8ea329af1b9@syzkaller.appspotmail.com, Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B2D0E40002 X-Stat-Signature: i3z9z7qusdm6zufc1oxoxnuysmbzncmp X-HE-Tag: 1683394491-131986 X-HE-Meta: U2FsdGVkX1+WOSziVC3SUfd2hbdNoJFQhj6a94as5l60PJPsldfYvs5EXRGjvkvremdJSxJTQlc8aGkG8DF9OplKbwR7C3hqo/JvLsuQ492qwTWXJZCn+cRKg3x8EtcS/3fJtFdcIpduuYBOlsXnU5Obr34TckB1PpPG7v/1E/Vn/zzGqi6eDrBkL5Z7mAKPqbi/n9TcUSfn6NpSx1DMWGsUXyrQZhqLE1GEeeEVoM4GSQ/f2DZHltIXMsoQ9wJK7v5vR5frxDHn6bYSjZYcjAmcWMzpEaB2nUwXaQQtLSzYAIaLC8WUjQjezQVTAEJ5hwvrcZmJ0YnF+MHPZMxsE4+kvIIBDeqWWhl+ciMi0JFTNIpMqq7LVNYPiIzxi0+877KG+N7MpBozxpLtyVD5+DEceoND/vp6cJLBO7TkQ+FTEaD3HB+4kRx6o4r1JPXYGgOVW8rkjamkVMDs0+m0gzsYR/CtR2i3G3nrRAgxahXqFC95ALzBSuYMcEMS6uCkD5Sbvo5lR07iyjat9adXwwxPhzQroglnAC/GQ0sntQ2fDZdDHG6r8ehOvpPOMMPVdg2+SaakKh26+B6sehZgz4MHSThIAv6P0U1tsvGz6SCYX4r1KqGVIenHHuAZRo2IDBh2lrsdXY7B+M8qjG/fDN1YQRzxbAKWO7GeiTaLfKtXGweA/WQZbkcqTXtC606CJkE9p8R5epndsjyjX19acMdpSisa47Sg33w+RmLLe8wLLArp3vczGBNbdr6t4Mfhs7uv1DMXuK6h1UWTgPE08UknIlkdGWDHHFgAVxYMbQ7WMcQ6l+apiWX4qZKSMceRFms6eUBYJ+1805/KFSocvEikXm+dqewyYGv8ieKLy0wApq/MqOArAG15h0eWM8XtMHUJtZKLZYNB/iKKl71BDlnuTnkrD5WH+Pw5QMu+u6hGcz6i9+pRRfQkOeS+aJ/ZCcf/fOjmyBbdScTfen/ jpScoIGT n5V8aCzge5nK7KEVOtl5V1wbLWyAxPwQFghLfxCFtqNh8Se4WhM9s3PFCNIqNJpTTTpNjh6gFrwmoYQ75XnpWl1VH/odv02rDwCw5lSwXfmK5EIrOacVatLj4xlr1pM40Pw8O/fxbQLSzgcXJ7i5ThLuw4uX592NYHtfO9MNaNuptdlZ1Ezfcn13ti67OlqlLAWLJClGUa6Vl+goJxNjIxqFGJxQjWKEuP5NGatx0g98w7aPTgswpKp0wwZhTm0VFSlCxjlU9hFuG2vQDpzlgKkYS3F4xeDWAyQoSsFSwhYd73z6KRyFQ7MLR5Ww4Riab1uBiX+83z7ZtT//D4MNkE0YR8N9WsVGidZCyabyWpmizmIFZ8OUfl7x4cfcpFMtvipQX3ogNYihZrGQWfnH+xXvmJPuZVUAytDa/gnPSQNezE7hxf27DfnkDCX1YKVg3TN6VQgIP455z5vHO73HHiJBS+A7Cnb4Hqvjop5mcVFBVteyxFKljw6XpOpAxoiVcDPNsT3Hph7CfbqJoMPEvFom2267FShfH8OpUFB7jDE78onf/4a1EmiWtEF0egYW8GExjFXF3vnIwpLLAVip95Fp61SoN023yIYyp638u3zRNIS1nFS2at4mrinMeKuLErOoPBWo8EChaAemDDxE4hwBpO6MLonPjMY5d/5Pf1mOIUlBrrArY+ynIdC3uui9urP3q3BN7s0y3Nw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 6, 2023 at 10:10=E2=80=AFAM Linus Torvalds wrote: > > .. in the meantime, I did end up applying your patch. Final (?) note on this: I not only applied your patch, but went looking for any other missed cases. And found one in fs/nfs/dir.c, which like ext4 had grown a new use of __filemap_get_folio(). But unlike ext4 it hadn't been caught in linux-next (or I had just missed it) and so I hadn't caught it in my merge either. I hope that's the last one. I grepped for all these __filemap_get_folio() cases when I did the MM merge that brought in that change (and did the ext4 merge fixup), but then the nfs pull happened later and I didn't think to check for new cases... A current grep seems to say that it's all good. But we had all missed the second check in filemap_fault(), so... Linus