From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9C6C433FE for ; Thu, 17 Nov 2022 23:20:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE3DC8E0001; Thu, 17 Nov 2022 18:20:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C45846B0072; Thu, 17 Nov 2022 18:20:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABF198E0001; Thu, 17 Nov 2022 18:20:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 961B46B0071 for ; Thu, 17 Nov 2022 18:20:20 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 67AB41413D5 for ; Thu, 17 Nov 2022 23:20:20 +0000 (UTC) X-FDA: 80144505000.01.2C3B322 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by imf03.hostedemail.com (Postfix) with ESMTP id 0960F2000B for ; Thu, 17 Nov 2022 23:20:19 +0000 (UTC) Received: by mail-qt1-f178.google.com with SMTP id l2so2148352qtq.11 for ; Thu, 17 Nov 2022 15:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Y0Zl62KafxDJ8AwrDahi1bqb4Xk/32bDlmDdXpQC/2I=; b=McHst7l/f7KmgETncU4ax8Cz1+X0pDSSDz+NpOo85KKRbSTGF3eq2IAlrIRy/FELSJ Y7C0SIlyu5mGQyhzPLIjsCXMOXUrzD5TZH+dJcbaF2LHrVuVcof8hyWOL3D9pZZx4wAD 8LINQRolzJh6QXumNwKV51jsDIdF9sMEo4+5s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Y0Zl62KafxDJ8AwrDahi1bqb4Xk/32bDlmDdXpQC/2I=; b=bsw7/Dvt8a5C3fbVD7Gi34K9CzSxksSYUdQ8yoJN+3Y3sGgSUvQY7uHv9xdLiJ70UJ vKJKmhcYLhkKXYgASrt9jT4OcNPsTa9W8uqYcL8p2fKD2pyDfSvPNCT2hb+/a3i+NnsA BIlUX375/lQOC+oDkCZmf/PJgycutidKTi4EakToyvQ7gEkA9aLcVsKuIUqfVJN4z75q 6UFOwttdIEL3WZ41Tfae0oBDgX5i5jJRlHvA0qSFyPqwhHSqcvEqW3BBxYxeiDLpxVeP X/AXMD1RAvryeDmPjWkOY8nwfMYL3RO+6gGj/ZY4gH//L8lXW0mWIN+5stk6CuEpEYTj kdig== X-Gm-Message-State: ANoB5pnTluef8dby+z6INYzwQn9dYVlxe4VfG+340DOEl5Bfie7Nrhhm JHtdsq8ji5XmcaT9EK/HyWgz1o1Q45IdBQ== X-Google-Smtp-Source: AA0mqf6zNd/TYhlBTGrRrYZPePeMup56hBp1l9bk2BqUjHIEaCJdEF4oH0qhM9Jby9STfpxc9OlH5A== X-Received: by 2002:ac8:5148:0:b0:35c:d017:2fd7 with SMTP id h8-20020ac85148000000b0035cd0172fd7mr4356534qtn.579.1668727219009; Thu, 17 Nov 2022 15:20:19 -0800 (PST) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com. [209.85.219.52]) by smtp.gmail.com with ESMTPSA id d12-20020ac8060c000000b0039d085a2571sm1103265qth.55.2022.11.17.15.20.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 15:20:17 -0800 (PST) Received: by mail-qv1-f52.google.com with SMTP id mi9so2273815qvb.8 for ; Thu, 17 Nov 2022 15:20:17 -0800 (PST) X-Received: by 2002:ad4:4101:0:b0:4b1:856b:4277 with SMTP id i1-20020ad44101000000b004b1856b4277mr4665856qvp.129.1668727216978; Thu, 17 Nov 2022 15:20:16 -0800 (PST) MIME-Version: 1.0 References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-21-david@redhat.com> <202211171439.CDE720EAD@keescook> In-Reply-To: <202211171439.CDE720EAD@keescook> From: Linus Torvalds Date: Thu, 17 Nov 2022 15:20:01 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH mm-unstable v1 20/20] mm: rename FOLL_FORCE to FOLL_PTRACE To: Kees Cook Cc: David Hildenbrand , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Oleg Nesterov , Richard Henderson , Ivan Kokshaysky , Matt Turner , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Richard Weinberger , Anton Ivanov , Johannes Berg , Eric Biederman , Alexander Viro , Peter Zijlstra , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kentaro Takeda , Tetsuo Handa , Paul Moore , James Morris , "Serge E. Hallyn" Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="McHst7l/"; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668727220; a=rsa-sha256; cv=none; b=jGOETHrkhUo7KPk8j33dTyOHrz9z2tPjW8n/TiOYJB2FScEx+x1r3nqi0QShkcHjxAz4Xz c5d3bBU38fcSCN/X/JOKrIV+BTZ4Krp3n5ctI7t+elWywy9rLxqQHArvc/ZDLKygQwYdjZ 8bx/YXi4ghk/jVmbT1cBa8tiPVwOhVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668727220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y0Zl62KafxDJ8AwrDahi1bqb4Xk/32bDlmDdXpQC/2I=; b=C2Swduu6heY6X/Jg9a7vtrOwHnC3EnnvOYvLO2O8FCt1+xGhR9JdmysOc+gnwOhFQ2VCSj qgHihIQSznPrPyZrGMa6thwvb/CIsmDiOsUUI+Zdxyec3Zr2Biz7HzqmQPcqGP9J1+3wG8 O/Ps2qX0KxxyFlsTfZ4ldh5gJkofL3Y= Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="McHst7l/"; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.160.178 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: 3dnimmr9ad1keijeawqkstgrct9kx99m X-Rspamd-Queue-Id: 0960F2000B X-HE-Tag: 1668727219-489617 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 17, 2022 at 2:58 PM Kees Cook wrote: > > Oh, er, why does get_arg_page() even need FOLL_FORCE? This is writing the > new stack contents to the nascent brpm->vma, which was newly allocated > with VM_STACK_FLAGS, which an arch can override, but they all appear to include > VM_WRITE | VM_MAYWRITE. Yeah, it does seem entirely superfluous. It's been there since the very beginning (although in that original commit b6a2fea39318 it was there as a '1' to the 'force' argument to get_user_pages()). I *think* it can be just removed. But as long as it exists, it should most definitely not be renamed to FOLL_PTRACE. There's a slight worry that it currently hides some other setup issue that makes it matter, since it's been that way so long, but I can't see what it is. Linus