From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD39DC001E0 for ; Wed, 2 Aug 2023 18:54:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BB062801DB; Wed, 2 Aug 2023 14:54:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2444A2801AA; Wed, 2 Aug 2023 14:54:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F01A2801DB; Wed, 2 Aug 2023 14:54:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF20D2801AA for ; Wed, 2 Aug 2023 14:54:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5D39940D88 for ; Wed, 2 Aug 2023 18:54:11 +0000 (UTC) X-FDA: 81080064702.10.59CA918 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by imf13.hostedemail.com (Postfix) with ESMTP id 2A58120023 for ; Wed, 2 Aug 2023 18:54:08 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=iAJoALiq; spf=pass (imf13.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.181 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691002449; a=rsa-sha256; cv=none; b=rYHLBX/CC/+pqYLbnyfLWOPctqAoIeHdm/uR/ckWGFqQMiugJDk0e4znGczI+xGiif8xar eSZab4HuLWk5JvS5beLhiWMz6S4F61IbBIRWJpHAssmzoUzhvZpbWj7feuVmUIciHuMgID VFs+rZdFeHPlEDhzOCfCBBK2EgOnMNc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=iAJoALiq; spf=pass (imf13.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.181 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691002449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bOvJemkz8MAV7rkDv/s31q26dZgdbiAYujbRCsOrvF8=; b=DUI+JUYQ2iw8kZxxm/6uF4U2LXOi86xkIcPJeVy+brNTW/fPS6NOGnH43+jmxPXlPLmVJ/ 63EuoNntDr2qBsUymtLXiwaQINYO47py3xTaHM8w6TYcQdxXWYfMRXSS9KtxSF+J+EIMGa d0VVInBKo3vPek/4D/Ji7DCdHErZyIM= Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2b9338e4695so1678291fa.2 for ; Wed, 02 Aug 2023 11:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1691002447; x=1691607247; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bOvJemkz8MAV7rkDv/s31q26dZgdbiAYujbRCsOrvF8=; b=iAJoALiqtAbdQA87RmsAUnXZA1DIpIrj6EBAyzQ29CwXAsd1jXvMnU6jawbCRiZxkw MO3Hyie+UDR5MuVg7zawY4kOg/B1dlb1qinzOGkMV/PeZ21PziYIFA2zI7OgXvj7MSWG Phb2xmkRhTsrgx0XSeWRscKqti8AqniVr3Mb8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691002447; x=1691607247; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bOvJemkz8MAV7rkDv/s31q26dZgdbiAYujbRCsOrvF8=; b=OAN3P2bYyG+AkA685Z3+fCtRbBHavdwDyxjAKPCbOS6d/r33VmLp6XxjfTjeBI9mQL dlIPayTBavGcsTXnuwcPlRwSngXhP501TVNns45Z2mvkVV/nICEhn0VPmMNeKR1syAwa lgdWaCbaV/Z476cAE0SYVF0yYVx1mDMgPL3pWCIC85sf3GJA6oUlsagfkJz0nPrF0hN1 nxng1C3thv8UqKenqkdlqhUA+DA36PjZCGHAyeWYcXMa+AgrrYcTbKKJIhyZ6geHVYof 44OTEXbao2/sRQPK4EOA9rdpXvvGewm0i9hjVsKvIEDBsQsDb5QIarmD4KP5zVAb2jXO TP9g== X-Gm-Message-State: ABy/qLbcJsBJB+5JHSnvbh4LqZ1SrMjaKkpr3jYG/DiSb2hzPlbCT3Ki u8CmY3KLJHC4ofboIH2nV84UPyxLKbkx4dZcCtHMR5sh X-Google-Smtp-Source: APBJJlFG1b5vDfbz8Ja4CR2bJwq0A1b27cqx8Yq7hg9CNJwx8SYKWi+FJCJ6IuPQzvNs8PLMRMJ1xw== X-Received: by 2002:a2e:2407:0:b0:2b6:9da9:2884 with SMTP id k7-20020a2e2407000000b002b69da92884mr5439754ljk.40.1691002447044; Wed, 02 Aug 2023 11:54:07 -0700 (PDT) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com. [209.85.208.49]) by smtp.gmail.com with ESMTPSA id y9-20020a170906470900b0099bc8db97bcsm9418861ejq.131.2023.08.02.11.54.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 11:54:06 -0700 (PDT) Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5222c5d71b8so75532a12.2 for ; Wed, 02 Aug 2023 11:54:06 -0700 (PDT) X-Received: by 2002:aa7:df18:0:b0:522:289d:8dcd with SMTP id c24-20020aa7df18000000b00522289d8dcdmr4973875edy.35.1691002446423; Wed, 02 Aug 2023 11:54:06 -0700 (PDT) MIME-Version: 1.0 References: <20230801220733.1987762-1-surenb@google.com> <20230801220733.1987762-5-surenb@google.com> In-Reply-To: From: Linus Torvalds Date: Wed, 2 Aug 2023 11:53:48 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/6] mm: lock vma explicitly before doing vm_flags_reset and vm_flags_reset_once To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, jannh@google.com, willy@infradead.org, liam.howlett@oracle.com, david@redhat.com, peterx@redhat.com, ldufour@linux.ibm.com, vbabka@suse.cz, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, hannes@cmpxchg.org, dave@stgolabs.net, hughd@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2A58120023 X-Stat-Signature: w868q1od7whxnn8q5ubufczrimkrr511 X-Rspam-User: X-HE-Tag: 1691002448-528691 X-HE-Meta: U2FsdGVkX1/PxltZcUZ3KeiSC1fUUH7hjYOtazb//t46ksWOMYFtBrPMZH/LbkFL+Eex/osALTHOI002442Saf7c6LbHIyIigJeR/v57teoS1ktFG/Mq2+sBYCsgisP32zvJHtf8CQgKwVv+IkqSaZVxobSVeY3vcabNhXbPIsGBnU25prC7c6litQTzz6MLyIrRIvqI9jzlz4CLPoVJl0knJ4Ul52YdTTkZxiiN0N4AcPmO7W73L/k5DbNn5cmTsANc4Dvmh2EfXB6pvvK8v1KJWFOZrZlIfCYMRbRRyT3ZlCYHzRnijTLmyPNXypTTjUSOd2VcdNv5ua16uJmNA7K4YdgxP3/ojeXVJzTLNYiWBQvNWF6o+zscgiGqWTHw5MZF90MqVIJmKKNs7XI497S5K5GmZNfTxNy6D+ERWvLDLwV2jHENaIEsKtBAzW4fEJQ8wH2nNf94lE0WRb1PMVt9m0KqHIYrbSvn4AkO0dldulMOmPbBEflDUvsK2yGbiK48zrTM87zWUiyDBnSCNzCQaaKUsRtP2KoPycHqa/bEVkAaqHXpKPVtBupH2Aww5Z3uxM38T49yFDCSHQWqxzMxsF97DUd6BHfnu0H6nCSkn/NpegI+a4MhVJlYdHKYE/ecx8ryatWNx8+GRAHONP/gkbTn7j5QiqYeghlUmRfK+losJDgZgid2WVHd9ZRgVqnuWbUGNhNgclOKLZ5xZNTDNzspVfehvTteCpPwL85h8soVgpsdvMPMZq6oZUSpAhDpCeQlk8Kdu/iErpWDx4n1S8Dh5RA1VwRpOLzh8rebHCj7pQKaQDBKfJy8OQxV/Jk2YvbYpyXgLV+3e/igGnb94kprWF7gRW0Gme6SpAuYjDdp2w8Zm5sCQaRvJgi0LT6g2fp2nyXelsIm7agAn6HvBjE9e++F8zbibtTYl3vCIObzxviF5Co4/LGm+I9+R7SZeXFQKA8Iez08+nl vaSeOfGX xRJ+PlofGKne96+I9K7CickHa67qYRGBSky7wpCxFNxszB4/LwTP/M/rvZ6wwCwtFqlMc2Q4WZNU6u/gN+VfEOaGBnG7SIRSID8l5aqfomPFc/BkF4x9ha7PgTFhdeZ85vJxvzA6qScYpIkSgkPg9NSaT5jv53M9kokK1XWkJe32DYEAgl/oFCtU2hFXekVQQoItwi4WMi677+v929uXwWoMEoXBVDKshjMy0T3AamI4f8X6i9D42dHquXQWThjc6C6t/37TdVfaZy9aGW0j6Lo2PoaKY5DeGwNktGV1iEBE2H2x89nUv4nNQgm01ptYC0NSeQhyXsIF7dNhEVT7PVNwfQoU857lsuh/lez1YXf2DK2NkriKxmjZoCPVv6Q5iUdRbk/p/Z4qJb4g7N8Ccejh6PvL7CUNoj+g16XiqquQLLvo9lwD9V8A447rgqcPjnJ6AVJKYDySPPWgt2ToXsxLJ8+2cNY78CQG6qk3eL6fGDJxJXnLydszxXe0/wX72uc/88IJIOGgNSzWGOjNsk2eqkq7o1E+sVudig9hLi13p9+90INey0IOFrFDCLXAucZ2+UXUKlW61umuk16AJQsDHhzzvRnseZeH3K6664qQrFzrMc+wswZItHQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 2 Aug 2023 at 11:09, Suren Baghdasaryan wrote: > > Ok, IOW the vma would be already locked before mmap() is called... Yup. > Just to confirm, you are suggesting to remove vma_start_write() call > from hfi1_file_mmap() and let vm_flags_reset() generate an assertion > if it's ever called with an unlocked vma, correct? Correct. Linus