From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6F65C433DF for ; Wed, 15 Jul 2020 23:19:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8926C2065D for ; Wed, 15 Jul 2020 23:19:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Bw6ZnFqi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8926C2065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4F3E6B0002; Wed, 15 Jul 2020 19:19:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFFB66B0005; Wed, 15 Jul 2020 19:19:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C14D36B000C; Wed, 15 Jul 2020 19:19:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id AF1096B0002 for ; Wed, 15 Jul 2020 19:19:04 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3BD95180AD802 for ; Wed, 15 Jul 2020 23:19:04 +0000 (UTC) X-FDA: 77041877808.13.force71_630a1c326efd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 1AE1718140B60 for ; Wed, 15 Jul 2020 23:19:04 +0000 (UTC) X-HE-Tag: force71_630a1c326efd X-Filterd-Recvd-Size: 4194 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jul 2020 23:19:03 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id s16so2107103lfp.12 for ; Wed, 15 Jul 2020 16:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z1+a/ObNZL3+vD2m0kxRuakdnVXRAY/0dRWxur7hS3o=; b=Bw6ZnFqi0LokptDDvPQkvwYgLM4EwcHyG/o1zG9i4eCycUy4CxjKWFX4GltGI5Ntwu d442hjcpYOB0MC20Fn5HvhtSFP67sPkKUNqyOYJDbwzwjKHb6eHI5uKTOfpagqPhVox0 RzQODZFbGnNBc7po2varkk7q5GTekjF4CDpbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z1+a/ObNZL3+vD2m0kxRuakdnVXRAY/0dRWxur7hS3o=; b=gJVhiKFKooVo1g/QXnnG7mPf5CxggJDqGDft5xK9zuqVSdQ+hK9/OMKNh+0tiou5cS 66JmczfTSKoSBEkaEpHX29t2tynapP57WXmOUelOGrQzgp7e3fkXcguVyF+rz6WCmNYN uD+13nFLyPCy7MOTn2izf899IB4ugZp/hp02zJiR1gG6XpDOkyRSNxhUTt9loL5s2UPT rqYAeN2bYejk6iRTvUg6NIZUIpCf1FUmFJiq69drQ8I1M9Pxx4kcVrYrpIQBTxad3U/D wrlv8dWA2a+wUJ0LJErmY3VLwIW58XA99hrarvoQFWhlYY4/GUZbJ/+MUo8QB7p/1oPw O3CA== X-Gm-Message-State: AOAM530eY0iUkZ2XGdhv2sXJPYIpGveAKkeKYOij4qD9oKOBiPaF4oII QnkJ4oZv/FYpb3ZwWfL7eWhQc4ujXKE= X-Google-Smtp-Source: ABdhPJy7JRiQQWFkhFhkNWS4XvzPs5rUy3/Jk1uvv0gtjtICTCX0YSYCO1SbSHbpL44qXobVnszY5Q== X-Received: by 2002:ac2:4564:: with SMTP id k4mr598482lfm.197.1594855141607; Wed, 15 Jul 2020 16:19:01 -0700 (PDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com. [209.85.208.171]) by smtp.gmail.com with ESMTPSA id j25sm771361lfh.95.2020.07.15.16.19.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2020 16:19:00 -0700 (PDT) Received: by mail-lj1-f171.google.com with SMTP id q7so4804650ljm.1 for ; Wed, 15 Jul 2020 16:19:00 -0700 (PDT) X-Received: by 2002:a2e:760b:: with SMTP id r11mr668699ljc.285.1594855140186; Wed, 15 Jul 2020 16:19:00 -0700 (PDT) MIME-Version: 1.0 References: <20200715135011.42743-1-kirill.shutemov@linux.intel.com> <20200715205428.GA201569@google.com> <20200715222228.jf2pv5u2wyhtc5o5@box> In-Reply-To: From: Linus Torvalds Date: Wed, 15 Jul 2020 16:18:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2] mm: Fix warning in move_normal_pmd() To: "Kirill A. Shutemov" Cc: Joel Fernandes , "Kirill A. Shutemov" , Andrew Morton , Linux-MM , Linux Kernel Mailing List , Naresh Kamboju , William Kucharski Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1AE1718140B60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 15, 2020 at 4:04 PM Linus Torvalds wrote: > > It *might* be as simple as this incremental thing on top No, it needs to be + if (*old_addr + *len < old->vm_end) + return; in try_to_align_end(), of course. Now I'm going for a lie-down, because this cross-eyed thing isn't working. Linus