From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F658C3600C for ; Thu, 3 Apr 2025 18:16:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB3CA280007; Thu, 3 Apr 2025 14:16:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B3C6F280005; Thu, 3 Apr 2025 14:16:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B54D280007; Thu, 3 Apr 2025 14:16:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7BE2E280005 for ; Thu, 3 Apr 2025 14:16:06 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 91C85C0F65 for ; Thu, 3 Apr 2025 18:16:06 +0000 (UTC) X-FDA: 83293536732.12.346EAA9 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by imf17.hostedemail.com (Postfix) with ESMTP id 59D7F4000C for ; Thu, 3 Apr 2025 18:16:04 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=PkNzGgOW; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743704164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FJlcXXP2FukqGEHv0z1cQI88EHr2Dv5R3LlDfDt2A4c=; b=TNujobDUcMuaXBpIiJWzgxU7DZVmeBe2Eta+4gD+Spve+HGiYFZ+9b0I1aPAFw3ZMo3Exr 1sFmzcVRWGfUgEV/wpEHNchRQbLip8/3HfHWLksPirHyI2fG6xDjZ9HH1DAX3m7QPrBLSa fcklMWl50IFkEeqxls/VAd+BbV4oKpA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=PkNzGgOW; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743704164; a=rsa-sha256; cv=none; b=lU561zBktBRD3iwj0wWaBjRQ/seiirSjQNZellKrkfAKovxOnd34QYQ0hAPgeRAcGQxlyF Cx7QQedaL57aAzOVLcP/gOGm0A3xOGzuw1NqyWlLzfYNzOtYX+QpqZ1gVatg/FIcoZlxDV +n4B3s4JD3KL8kAsNCguMswbrJY8GEA= Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-abbd96bef64so211165766b.3 for ; Thu, 03 Apr 2025 11:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1743704162; x=1744308962; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=FJlcXXP2FukqGEHv0z1cQI88EHr2Dv5R3LlDfDt2A4c=; b=PkNzGgOWgP4ukRh93kUOQKVoQKFlSUolgX0vvnOb76DtkZdHZh7Wk6JPuf/TZYttt/ dcGA+BiKu1gE74abExfcsBb9xtoV2dhDDUp7zCsAq4DloXJgmUYuF5sGwPh3v7n7fftf j7qGysPzHAuIKUjOx4uCwVWzL7ljxDmrEMZ88= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743704162; x=1744308962; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FJlcXXP2FukqGEHv0z1cQI88EHr2Dv5R3LlDfDt2A4c=; b=HSDA+1l57U/SK22MAIizhjRhl15fGWjF2Ty/9x8z2LKOOntxODuEf37/A8ZxTDNcK3 x6ZhppXIajA/g9+3jeTJwH4xopinFYlRYgV4MzPR2Fa2fi45RD15H5JuOVe2dpWIe3Ap EvsC16lrHhvYRdJwv08UouTedp9eBUHKiUVHwtLZBN7IAckXXhUDGqH+y7LD76giGHfw wQx4alm1wUr5H8A3fdlev7M4O0Z92shHa2p1y8vdwSNcLP145Grt18JRO9ZDAvSc/1Uj +nHnw8pjHengF+dBMUg5/FDOfFhEEEOC45/Io2shzjIzPNy3sQY+MD/VunQcaOhKukOm AuNw== X-Forwarded-Encrypted: i=1; AJvYcCUVI2bA7/mJU1Q3GNz2qHxL6ztjEK84/stkrV4+RGOJCgq5KYbZ/mBRUR5afiWqWEG+IxCrhSq+BQ==@kvack.org X-Gm-Message-State: AOJu0YxElTLIhMtlOVwEoPpsknhZh0OPWvnt2Z0Hc3oaUnmmGLNSb0St zgdCfdjYoxVfejwlm1hwqW8IHgNHZqGlaFatjOIGNICsBUUfGppm84nU4sgDO/lHiVBSyKVUC6/ B6rc= X-Gm-Gg: ASbGncs5D51w1VBYNmElsT+3N1tBfO6GAr57+lPtZEObdyiMPw4V2wPMSPKHi69GJwi cJmekjpjUZrDO98mh52L2R8skPo9FbHqMXU6+YRyqyFOqdUjP5pqaj+7QgK5O/LelwRrIcbWXqF i5aPPfbwUOAswctsgMQeuBn371La33a29cRDJaQsAP9YvfhxIKI+u85+QzTDeFSECDKlXUA8rYC 9vCxDtr01rICC8BwI2LasMmILAnINBHpOlNvrBLNCZyOVLLXJrLxFj5Aphe0I7mb9Hd1nQzNRaa bxPinThAY2w5SEj+K/4lONhwOHAodybLSqCjuNkvZYj4MbqhCevkmZfvSmqrXu0Nbyjw30HybKf wflIfULsRKDa+RmJtFDE= X-Google-Smtp-Source: AGHT+IHm2bKdjdQgtR2TqekcUmc1/zmr9qmo+gQ66Dw6GPTVNM62K9dwT/MhuuFdZNGH54WGz74HeA== X-Received: by 2002:a17:907:960f:b0:ac3:5c8e:d3f5 with SMTP id a640c23a62f3a-ac7d190ff66mr58256666b.27.1743704162326; Thu, 03 Apr 2025 11:16:02 -0700 (PDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac7c01c21d0sm131784566b.175.2025.04.03.11.16.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Apr 2025 11:16:01 -0700 (PDT) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-ac2c663a3daso226561066b.2 for ; Thu, 03 Apr 2025 11:16:01 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUaQexm08+E3sqFHLr6nkrhHK2SkuOyS7MO+obQVfKwg09Naiy8iCPSueALd2pzBBi0JrEZE3fY+g==@kvack.org X-Received: by 2002:a17:907:9728:b0:ac7:41c:748d with SMTP id a640c23a62f3a-ac7d1b27f38mr53718566b.38.1743704161358; Thu, 03 Apr 2025 11:16:01 -0700 (PDT) MIME-Version: 1.0 References: <20250401134408.37312-1-przemyslaw.kitszel@intel.com> In-Reply-To: <20250401134408.37312-1-przemyslaw.kitszel@intel.com> From: Linus Torvalds Date: Thu, 3 Apr 2025 11:15:44 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1Jqqq_S2O0OJpyEjcg88KSOkVuR9PdTbHkE7So44nAp-S1DtNbZhUbWjRJI Message-ID: Subject: Re: [RFC] slab: introduce auto_kfree macro To: Przemek Kitszel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, peterz@infradead.org, andriy.shevchenko@linux.intel.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 59D7F4000C X-Stat-Signature: zcc6kqh3bybc7k8f311qte5bk5c3aywh X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743704164-914090 X-HE-Meta: U2FsdGVkX1/68nnIxsYRNkM2QvVNW8/sBSZzy+ftirmGwrjuvmom3i9deE20OiYy8oXC4U71plWOXIFZSjUcKGoCqrOWsJuKSSbgq4yZk4gmerCE4xg2XIl2ms2oL4jSpsy4gBAYBZ93hrgguP5k3fyGUQ0X1r2+A0X3rJJAY3CICryXJqVhg/sUteJO8ptofM99rknDwS4z2bcYv9fXQEb+DKzCRZPAXnNMO6E2tCLF8uDBlayg4sYyxxQDgZkVCSSb8EhVupr8etPNAQIhq3A1OvsbP8lulV8cVmg4uiymq8ha5DuC8fP9u1mRlFIn9ubVTeBHpJNPMI5gNzXooC2HwqOD7Bq4za9m4gyVl/fGWEsJpnlYlJ671lWVdaxzV+O5OP2OQJKSD74cE7n2/kZnTi6E6mjxs5KztgVyMPG1uHA5iWdv8HJkGo6Ptnh/WehXiJc5tF/IRxTSYKhlmK31VT8njbyRT4w7r3ZapDMeXrHbPvB3lIotFd9HA1vnml8TGmGK3YwTxPFe5mDgjsI7k/odOgA1MaqQB+ts525lI9nmCAovCzRYe4KE++7dshleZLcc0HxeIdn6f6u5EvDwFSY8ghk0CW7+vCwCYDzquyjlbNRrjOc0gBplOMFtSOue9eM9WLWwQVpP3aGarGgOBhIQ+Thl5IByD3vDEcS2+PpSAAbyIiHY02QvmeYfeutVP+zCwE71jtV5MFWDIE0hS7aJq9gquDe84vlXIo71N5Wmdv3TICciFr+ncQDL/34CmeYaIxRneBlSYFyqt0P5+D3p64wAZFzOfuV7ovXjMmgag37sc/fY4S6JYmwp/iM85HpxTyLqw+RH6zGDSGVUHRue5iDgqUCuDXMMw/2LlSjTwFdmqe5qptdJlaZ3WCwK+4NVOeq36KKpw504/h3s6TRpCh4wJVvrHaxk2yhrb+3aLY7DOinbRsPmLbprwluyh5ql0OUbDbqBhnx j8y9zDOM 9yBqt1k0aI76RuJkUtZxhKD7i/AkiB3MmPbLGrrWOdRdXmFqSCv4ZiGAxeoBgX9DHjVUCWlnnbu3jcjmjVAeJiWJ64/YRa+K1cnNWpdjgIQECq3J2B8LrprrpwKmspCJhLcrAfaNuc0IlqeslGn/QtPRd/w7XllRG/i/yw3BXGmbDZY798qlibERQ2zGVujVFR/2/NSgY9cvjJylJndq7avpcrnmIpeLqeH+s3G6OXSnA1iehRVBebfoUCBscwmajNbgsUbSAlQo/L8yjc4GRTr3XdEUEdMWxL0OgH123ut4O8mtMLNtBcOO8A0DPMdnduZlGn58S3KF5mbSVW9SoL4pOyOP6hZ0N8xYc26ge9Pd5to4rVQuXVfsgrQtEgslO7Eft9CtWB/QtYLxWr/xYOefjJ+D4bxKCTVTtznmTb1KVSS4qPZnN9W+ucI0xLyWp4zpVBda8uPqOicxmRyNwS24RN8AX+EbkXIg7PtyrKAxTIRAKZWMnbYG/Z+HJqxCjVzo8YWO0fPaX5m785+HoLg/N/VYkXZHevoH5i5Gut6iBhGZc9jW+SpNgzeVtpxXYfn7rNp5l08Y2htg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001260, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 1 Apr 2025 at 06:50, Przemek Kitszel wrote: > > With new auto_kfree, we simply will start with > struct my_dev_foo *foo auto_kfree; > and be safe against future extensions. Honestly, I'd much rather just see any auto-freeing *always* assigning the value. We used to have a rule that declarations had to be at the top of a block, which made that not an option, but that rule went out the window exactly because you can't do that with the cleanup macros. So just make the rule be that __free() without an assignment is simply a bug. Linus