From: Linus Torvalds <torvalds@linux-foundation.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz,
peterz@infradead.org, andriy.shevchenko@linux.intel.com,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [RFC] slab: introduce auto_kfree macro
Date: Thu, 3 Apr 2025 11:15:44 -0700 [thread overview]
Message-ID: <CAHk-=wjvh_LUpa=864joG2JJXs3+viO-kLzLidR2JLyMr4MNwA@mail.gmail.com> (raw)
In-Reply-To: <20250401134408.37312-1-przemyslaw.kitszel@intel.com>
On Tue, 1 Apr 2025 at 06:50, Przemek Kitszel
<przemyslaw.kitszel@intel.com> wrote:
>
> With new auto_kfree, we simply will start with
> struct my_dev_foo *foo auto_kfree;
> and be safe against future extensions.
Honestly, I'd much rather just see any auto-freeing *always* assigning
the value.
We used to have a rule that declarations had to be at the top of a
block, which made that not an option, but that rule went out the
window exactly because you can't do that with the cleanup macros.
So just make the rule be that __free() without an assignment is simply a bug.
Linus
prev parent reply other threads:[~2025-04-03 18:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 13:44 Przemek Kitszel
2025-04-02 10:32 ` Andy Shevchenko
2025-04-02 10:40 ` Andy Shevchenko
2025-04-02 12:19 ` Peter Zijlstra
2025-04-02 12:22 ` Peter Zijlstra
2025-04-02 12:57 ` Andy Shevchenko
2025-04-04 3:05 ` Herbert Xu
2025-04-02 12:21 ` Peter Zijlstra
2025-04-02 12:55 ` Andy Shevchenko
2025-04-02 10:44 ` Vlastimil Babka
2025-04-03 16:59 ` Kees Cook
2025-04-03 17:35 ` Matthew Wilcox
2025-04-03 17:46 ` Andy Shevchenko
2025-04-03 18:15 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjvh_LUpa=864joG2JJXs3+viO-kLzLidR2JLyMr4MNwA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox