From: Linus Torvalds <torvalds@linux-foundation.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
syzbot <syzbot+6cf44e127903fdf9d929@syzkaller.appspotmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [mm?] WARNING in __gup_longterm_locked
Date: Tue, 4 Jul 2023 10:13:17 -0700 [thread overview]
Message-ID: <CAHk-=wjvVRv7yfsAYyRigSWxKyeMb42yzB3hj2U9J1u59MyvUg@mail.gmail.com> (raw)
In-Reply-To: <20230704170144.GB1851@sol.localdomain>
On Tue, 4 Jul 2023 at 10:01, Eric Biggers <ebiggers@kernel.org> wrote:
>
> syzkaller just makes system calls.
>
> Unless you want to do the crazy thing of checking if current->comm begins with
> "syz", I don't think there is a way to distinguish.
Yeah, that's what I thought.
> In the past there's been some discussion of adding a kconfig option like
> CONFIG_FUZZ_TESTING that would be expected to be enabled in order to run a
> kernel fuzzer, and changing behavior in certain cases based on that. Changing
> behavior in production vs. test is problematic, though...
Agreed. The whole point of a fuzzer is to check the real thing. This
test for GUP expansion really is a pretty specialized thing.
Maybe the WARN_ON_ONCE() could have been just a "pr_warn_once()", but
at the same time, *if* that condition ever happens in some real
situation, I'd really want to know just exactly *what* the app in
question is doing.
Linus
prev parent reply other threads:[~2023-07-04 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 9:37 syzbot
2023-07-04 16:24 ` Andrew Morton
2023-07-04 16:39 ` Linus Torvalds
2023-07-04 17:01 ` Eric Biggers
2023-07-04 17:13 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjvVRv7yfsAYyRigSWxKyeMb42yzB3hj2U9J1u59MyvUg@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=syzbot+6cf44e127903fdf9d929@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox