From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B70C4332F for ; Wed, 2 Nov 2022 23:13:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31B188E0002; Wed, 2 Nov 2022 19:13:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB218E0001; Wed, 2 Nov 2022 19:13:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192BC8E0002; Wed, 2 Nov 2022 19:13:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0A5828E0001 for ; Wed, 2 Nov 2022 19:13:23 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CE8681C6364 for ; Wed, 2 Nov 2022 23:13:22 +0000 (UTC) X-FDA: 80090055444.19.4201C92 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf08.hostedemail.com (Postfix) with ESMTP id 01CF0160003 for ; Wed, 2 Nov 2022 23:13:20 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id x21so164755qkj.0 for ; Wed, 02 Nov 2022 16:13:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GVuco/fPOv3fEWTXwRJYz62nlQyqO6H+cs6e/gRx3vc=; b=bwoJSQBSGTuFi1Z2JnP4EuzofGlatFFBbp5t2OLtk5xLcsuAdIMjVYu2q+NBodmZVh HKKcr8Xop5vJ9wwXF6yy95UeGH7IUAKR42lQakOtgXBragSd1iAzLxEsEnWb8/BpeUeD AQHH2G3ajPu4F47YV3OVME+ds1L3iYcSOk6Vw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GVuco/fPOv3fEWTXwRJYz62nlQyqO6H+cs6e/gRx3vc=; b=o8DmREpeNk0FkZ/4CrZVZUYQXLL/qyJjhqw8OVKugMPTRk4mdLyievKaGKrQeALPYO g0kEjjAILvkn4l2M/gBFO24t/bDPjHas9M0AmSnIbBmNRx+YVYXwBdM9MCT1vOOAtrre niE0MbbOa/FM22kFMpi+Txcp2R0QvQuQapykBBEWDm4ID5lXt9M+tpg4vb/Hll/zWqH4 gDF26cRkx3+bMLLgEv+tf5ls9fYNBlMUnl87CCuyu3/Sdu13k8BPkTxnaud3gzYG8y/n xS7gvDxybw7Mp2YxTPV2zt0fAqcl3KwOM1YJ0vak/Q1OmJRBjFNbr0bPPrVz6WYHrFXh PIQw== X-Gm-Message-State: ACrzQf0HzObUYRXCI0Yb8rVr5QPPyEMXraYOj+pQRLklV2Wj+u1wSGKS oSmy35dgC288G9P5atf8P9fFKPY/HrZgmg== X-Google-Smtp-Source: AMsMyM4dlmqlHw2cg8trXwnT42VbAldhzqEkIdndwh3SemGleIiuSAXkZt0m+dzGDmzMxwpRJHW96w== X-Received: by 2002:a05:620a:288a:b0:6b8:fcfe:db02 with SMTP id j10-20020a05620a288a00b006b8fcfedb02mr20398227qkp.504.1667430799868; Wed, 02 Nov 2022 16:13:19 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id 14-20020ac84e8e000000b003a50b9f099esm1271364qtp.12.2022.11.02.16.13.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 16:13:19 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id j2so353650ybb.6 for ; Wed, 02 Nov 2022 16:13:18 -0700 (PDT) X-Received: by 2002:a05:6902:1352:b0:6bb:3f4b:9666 with SMTP id g18-20020a056902135200b006bb3f4b9666mr24282606ybu.101.1667430798577; Wed, 02 Nov 2022 16:13:18 -0700 (PDT) MIME-Version: 1.0 References: <47678198-C502-47E1-B7C8-8A12352CDA95@gmail.com> <140B437E-B994-45B7-8DAC-E9B66885BEEF@gmail.com> <20221102233127.423a6112@thinkpad> In-Reply-To: <20221102233127.423a6112@thinkpad> From: Linus Torvalds Date: Wed, 2 Nov 2022 16:13:02 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mm: delay rmap removal until after TLB flush To: Gerald Schaefer Cc: Peter Zijlstra , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Nadav Amit , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , Andrew Morton , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , Joerg Roedel , Uros Bizjak , Alistair Popple , linux-arch Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bwoJSQBS; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.180 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667430801; a=rsa-sha256; cv=none; b=nXdC41d6RdOClfiHOD3/Bo0NqI9flm9e+0LQF9gR/bsQMICkgBM3F2CcI1gP27q44ugkY7 U37Xnwr87XpUb+OpW5ggDN38TfX9j+Yqi/BIlVSElHEoWMM48jEMUAcpb4qAUNB7EI5H5A /KWvPF+PRHC8ozYGSLeLDkwZdFmk88A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667430801; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GVuco/fPOv3fEWTXwRJYz62nlQyqO6H+cs6e/gRx3vc=; b=PVfRL0UDvt1EWNAo0Z05jgrpIZSmPLA0tIKolWPLKtg/KutzfjbY26sdZV2K92nK6cgCJy sDkUs/00CF2OshR2/SUdUQ0vPHnavMhs4TjGeiTcUD/uf06i3VgwLnZDBJ14/4s9Fr2aG0 pFq3zU3D+rNGdUx2ndyevzHw1e18i8o= X-Stat-Signature: 9k5coppjkfrmtiy1hxyyeyxf6x5jbyxj X-Rspamd-Queue-Id: 01CF0160003 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bwoJSQBS; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.180 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspam-User: X-HE-Tag: 1667430800-560040 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 2, 2022 at 3:31 PM Gerald Schaefer wrote: > > Just wondering a bit why you did not also add the > VM_WARN_ON_ONCE_PAGE(page_mapcount(page) < 0, page), like > in the generic change. Heh, I had considered dropping it entirely even from the generic code, since I don't remember seeing that ever trigger, but PeterZ convinced me otherwise. For the s390 side I really wanted to keep things minimal since I (obviously) didn't even built-test it, so.. I'm perfectly happy with s390 people adding it later, of course. Linus