From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DBD6C2BA12 for ; Sat, 16 Sep 2023 21:17:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B06D96B044A; Sat, 16 Sep 2023 17:17:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB63F6B044B; Sat, 16 Sep 2023 17:17:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97E9F6B044C; Sat, 16 Sep 2023 17:17:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 87CAB6B044A for ; Sat, 16 Sep 2023 17:17:33 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 84DE91C9EC2 for ; Sat, 16 Sep 2023 21:17:32 +0000 (UTC) X-FDA: 81243721944.20.4F7017D Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf05.hostedemail.com (Postfix) with ESMTP id 7E822100004 for ; Sat, 16 Sep 2023 21:17:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="JpJ1x/Ln"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694899049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nsQTPm1Pcces4jObIPICpUNhN/fBbrd7/cdATB/UoXo=; b=i0M8kDz0wKy/4TjyXVqU4c1psT9ey2x3dybA+0StiX9lcW5q3SMiOGsqFIkFO3JtCkxy+K Id79n+mMqfuODSPNL21rPL7BRq17ZVcVNua9uZ9BN2N7FTend9DOMAevWVVJdAkuaDNEmC XReGNbU6gsq6xl4o8YbSq3HpwRFsgas= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="JpJ1x/Ln"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694899049; a=rsa-sha256; cv=none; b=XGYyz6Jd4sCs4c1o3rYKxT9ObSLJdch+Fi81vIoG2UmQYDZPG8NIyX71RZ/lIyYLGNHEvm l6+1CjNsCG2Y/CUmfQBHfJQxuGHrAzQkr7tR/Z5MAO5KKbhrN5YXJvnZ9zTwBN08dTaIhn TkodA0bJYln9QbK6W9dDmnon067BBnw= Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-9adc75f6f09so279254366b.0 for ; Sat, 16 Sep 2023 14:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1694899048; x=1695503848; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nsQTPm1Pcces4jObIPICpUNhN/fBbrd7/cdATB/UoXo=; b=JpJ1x/Ln5eFODTLw/KB3RCZ6H9Hk20rx73UlBB9//jBTE2CsJjXLK2miSxrUpaojY1 xB7BriwgMgrPYD1LHSUs/YnyubSkIMwKevhqyxXhLTUbCnWrAeBNxBdt5aiEByCINssS DuL1++BM72Juv05t67WEj7oIlnq9sN6q5zjuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694899048; x=1695503848; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nsQTPm1Pcces4jObIPICpUNhN/fBbrd7/cdATB/UoXo=; b=r1VsdP7h3YaCPcUEUJC277sl2Q2EWyS9Whm2OwJly0SotBYkCzJ1/3FKsamIBRLpqD aQSWmtH/nAxG9R1qeed5E6/aUdid/Nd2rPfNFf9m+eOrdupd+GTmKZJWu3Givo9Qt5/z 2RLsTHtESFvGZzAuISyMjMm6gAJm/mSxxwDeyaOMtQ3OawgyTdCZMoLtwwSKNxqfuue8 WMCHF0YqJywGle2ykPHp33gsGWT83KRKIYndVmHubqLYtiVbBhWJnsA1lObROHUXhB4I jQ3DftPuwxB+VidkXR3f0TEl7q//AE+KTadVC7RI28Ztt+aPMn1VXtrapiof4fvkB06t 2Hdg== X-Gm-Message-State: AOJu0Yz3URaejofdTd4a983BGFuNoOHs4FYDuhD+fp14KT76i0YQG94h fY5Gk3eV2oq72k3yGhKlkPrypiY724ZhlkFUZffjdiCM X-Google-Smtp-Source: AGHT+IHRWX20j3BREZL+rnfpLmGePLMkgAijnSwftbPW6QXPyOj/t78omJnn6KGveJ8PZr32COuyCQ== X-Received: by 2002:a17:907:7892:b0:9a6:1eab:9c84 with SMTP id ku18-20020a170907789200b009a61eab9c84mr4663878ejc.9.1694899047640; Sat, 16 Sep 2023 14:17:27 -0700 (PDT) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id oz11-20020a170906cd0b00b009a1dbf55665sm4181596ejb.161.2023.09.16.14.17.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Sep 2023 14:17:26 -0700 (PDT) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-52a39a1c4d5so3953642a12.3 for ; Sat, 16 Sep 2023 14:17:26 -0700 (PDT) X-Received: by 2002:aa7:cad3:0:b0:52c:e607:3866 with SMTP id l19-20020aa7cad3000000b0052ce6073866mr4342397edt.32.1694899046430; Sat, 16 Sep 2023 14:17:26 -0700 (PDT) MIME-Version: 1.0 References: <1694366957@msgid.manchmal.in-ulm.de> In-Reply-To: From: Linus Torvalds Date: Sat, 16 Sep 2023 14:17:09 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Possible 6.5 regression: Huge values for "commited memory" To: Bagas Sanjaya , Michael Labiuk , Christoph Biedl Cc: Linux PARISC , Linux Memory Management List , Linux Kernel Mailing List , Linux Regressions , Andrew Morton , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" Content-Type: multipart/mixed; boundary="0000000000009839770605806f0b" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7E822100004 X-Stat-Signature: it1mr855h6s6o8e7q3jxkdcdww78f8dp X-Rspam-User: X-HE-Tag: 1694899049-919777 X-HE-Meta: U2FsdGVkX1+IdKydKyICOxBEO+hCRFuWUq3RUEOX3uX/aCSGL3QEl/dzD8R4lDTk0Ocxxc9lSlEqDcXdY5sFLPYudEJCuwP805YeeIxQmL/sayhD6xJn1PygBDKF4A2tKlKkm84xD03GlwM1vHocHzVhJ+n8SC2QQlWk83UU25Ya06xyQmon/OeSgDPVLybtYrnL9hLt10JjJqWEVnltXEhy1qlb9r+kH9rQsTUQu3VaOPTnV2ctm5dLfMvaxHoXUYDEMfFWeMRmGT4GtXMiFs8mLJghpBS7oCSBs7iuYojLmuJqlY0W9HdYzUVGpkO20TGc6h87YTdyLss2d5JGEwSYSW5/5mTa2S/CUY5SLzbiEfoCp+1fGc0UGm26J5uFgsg8jeAtIjrDpDv8o/SKGJhiN6TheEN60gYEwSToib4FLsaR297k+w3TJWlkBAPhaKTWxWZyWRJ3TCpMAt0Ggj9nKZr9jkEnKmV/bit4EiWskhFlyPDgIUUrYelXCqe7z736pTj6sAqyy0ZosKDwtZl8BBVKFlWf+4Fck8WPVKBdrnlDscFdAtAk9LBlCR4J3fyyM7gESN5CfgoORlE3Tg0CMW3TjBGTYP1ne/UkyH+ECIXCZYtQK0Zu0b5mlDH6qe46FeJUFQDq118WjXMGbaw9Z66yc66kOjgRXUShw5kUxa69AxZmzA6uIIBUiSV7Zs1z1xgedCYzYN8Z9rVAANo2HR/xMult27SLXUGv05aj9MOmLMbNQdRPwhAijcudDxukxuFTB7AzpySo43vhiGU6MPoB+zJ/SNIVemvDQOpjPYKhyGsHK0mUsk/86a4W1UkmEfARDqw93RGbTHSB2j8FlMCEpF1Jtqjr63sJNvGrE6s8AEUhs0Z7B4eQ+NOrBZfO2YBMLxE657Zyu6uB5W6wq/k8cTKJLDmhmXeGbP5e2FDmYofBk+n54Oa4U2zx640RUkYXPgTJCSsV8XX /wGu2V81 GH8JaRbbslJdTlNtLS1aJ12ugWi0ITeEQJKk+iipbmcqT+4/5qCcJP+B9eTkFQ2G0KQ5mYbb7Z3R/a2XwrF1OkVBRvMAEMa/Y4ilV3py9Mu4ZYZCFoaUd2dU+ix8DJGrq6PMPlxWOD/5MpSiMcKWFdljx4KDYzwTjUf4OVn8cth0WbbFWXU+mI4wxh7jBaAngvD9A9gco8lubP/XjxlFeICFySK+CND9NsRvNjPP5iIeUeZQBZKgqIlxINPxNruL2NRkyNfi5U32NyYxBzGVXja4+pf3Z3fJ3udLq1tjHtAvacNpvwaIigc6cyBgvO5L9Nbd2lIS/nJY2kAlFNzRZfELthkEkDdTheDvh93nox5uYCSkeq/g0Ym9PZvxhiGi0eVN7NGCkNnZNfOTzQKPyIDDRgI8ZQTuJ+qpg+ViPk8xQ6YutPxBOSQ9SCxFerDVqKXfeDavsD5QnYhLJBme9pw36gqPD51WACNqKKTYBFUTO6u0N1mk+lokRoA+3nT//6uRFplLgt2CxBdhSR9mL+JuXxCnKz4W16BngtHClNDPBAvg+kktZODXhkbbCTy66mc/2F6Hyw2+Y30oLqexZLm3+JsbN+Iogc+x2FumX2MqiVNsW8HgDemOxvbTCTK95fhmAl0od3dTcJK8HgxhPgTntyMewvsIpODI445JnXOIDFiIOw9Mnd5hHI3Ecpkbvd+o1oz4POC8A01AC6JnCK7CxiRjrFl5QSx2Fzmqd3R4CX1yMM0g57yfDnhFIadl0PjmHmjipP1Yb7TxMoBwWkMr5p17YAR7s3JCZ1M9UzeMVMu5K3Po3Pt9Ykfd+AgFeuwmCDNND3f93WaSNwlg+1ukiJh6PcaTNLzUTuWAzpVORPbAo5GgkDzWdMD7OmGVG6tAmIjoxCsSYKWExxCw6aUBT9kwK5LsnCZmzRoIAtsxvlDUOaW4cMdlZnDOyV64r+yM1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000009839770605806f0b Content-Type: text/plain; charset="UTF-8" On Sat, 16 Sept 2023 at 12:31, Linus Torvalds wrote: > > Does the attached patch fix the problem? So while I didn't confirm the fix myself, I'm pretty sure that was it. Getting the return value wrong would cause an incorrect extra vm_acct_memory() call in the non-error case when VM_ACCOUNT is set (and mean the loss of one in the error case, but the error case never happens in practice). Which then causes 'vm_committed_as' to grow when it shouldn't, and causes exactly that "Committed_AS" in /proc/meminfo to be off. So here's the same patch, but now with a proper commit message etc. I haven't pushed it out (because it would be lovely to get a "Tested-by" for it, and that will make the commit ID change), but I'll probably do so later today, with or without confirmation, because it does seem to be the problem. Linus --0000000000009839770605806f0b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-vm-fix-move_vma-memory-accounting-being-off.patch" Content-Disposition: attachment; filename="0001-vm-fix-move_vma-memory-accounting-being-off.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lmmj2etv0 RnJvbSA2NWEwZTEwMGM4YTZmODc2M2E5YzNiZjJjMGIzNjFjOGY0MzZlNDJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRh dGlvbi5vcmc+CkRhdGU6IFNhdCwgMTYgU2VwIDIwMjMgMTI6MzE6NDIgLTA3MDAKU3ViamVjdDog W1BBVENIXSB2bTogZml4IG1vdmVfdm1hKCkgbWVtb3J5IGFjY291bnRpbmcgYmVpbmcgb2ZmCgpD b21taXQgNDA4NTc5Y2Q2MjdhICgibW06IFVwZGF0ZSBkb192bWlfYWxpZ25fbXVubWFwKCkgcmV0 dXJuCnNlbWFudGljcyIpIHNlZW1zIHRvIGhhdmUgdXBkYXRlZCBvbmUgb2YgdGhlIGNhbGxlcnMg b2YgZG9fdm1pX211bm1hcCgpCmluY29ycmVjdGx5OiBpdCB1c2VkIHRvIGNoZWNrIGZvciB0aGUg ZXJyb3IgY2FzZSAod2hpY2ggZGlkbid0CmNoYW5nZTogbmVnYXRpdmUgbWVhbnMgZXJyb3IpLgoK VGhhdCBjb21taXQgY2hhbmdlZCB0aGUgY2hlY2sgdG8gdGhlIHN1Y2Nlc3MgY2FzZSAod2hpY2gg ZGlkIGNoYW5nZToKYmVmb3JlIHRoYXQgY29tbWl0LCAwIHdhcyBzdWNjZXNzLCBhbmQgMSB3YXMg InN1Y2Nlc3MgYW5kIGxvY2sKZG93bmdyYWRlZCIuICBBZnRlciB0aGUgY2hhbmdlLCBpdCdzIGFs d2F5cyAwIGZvciBzdWNjZXNzLCBhbmQgdGhlIGxvY2sKd2lsbCBoYXZlIGJlZW4gcmVsZWFzZWQg aWYgcmVxdWVzdGVkKS4KClRoaXMgZGlkbid0IGNoYW5nZSBhbnkgYWN0dWFsIFZNIGJlaGF2aW9y IF9leGNlcHRfIGZvciBtZW1vcnkgYWNjb3VudGluZwp3aGVuICdWTV9BQ0NPVU5UJyB3YXMgc2V0 IG9uIHRoZSB2bWEuICBXaGljaCBtYWRlIHRoZSB3cm9uZyByZXR1cm4gdmFsdWUKdGVzdCBmYWly bHkgc3VidGxlLCBzaW5jZSBldmVyeXRoaW5nIGNvbnRpbnVlcyB0byB3b3JrLgoKT3IgcmF0aGVy IC0gaXQgY29udGludWVzIHRvIHdvcmsgYnV0IHRoZSAiQ29tbWl0dGVkIG1lbW9yeSIgYWNjb3Vu dGluZwpnb2VzIGFsbCB3b25reSAoQ29tbWl0dGVkX0FTIHZhbHVlIGluIC9wcm9jL21lbWluZm8p LCBhbmQgZGVwZW5kaW5nIG9uCnNldHRpbmdzIHRoYXQgdGhlbiBjYXVzZXMgcHJvYmxlbXMgbXVj aCBtdWNoIGxhdGVyIGFzIHRoZSBWTSByZWxpZXMgb24KYm9ndXMgc3RhdGlzdGljcyBmb3IgaXRz IGhldXJpc3RpY3MuCgpSZXZlcnQgdGhhdCBvbmUgbGluZSBvZiB0aGUgY2hhbmdlIGJhY2sgdG8g dGhlIG9yaWdpbmFsIGxvZ2ljLgoKRml4ZXM6IDQwODU3OWNkNjI3YSAoIm1tOiBVcGRhdGUgZG9f dm1pX2FsaWduX211bm1hcCgpIHJldHVybiBzZW1hbnRpY3MiKQpSZXBvcnRlZC1ieTogQ2hyaXN0 b3BoIEJpZWRsIDxsaW51eC1rZXJuZWwuYmZyekBtYW5jaG1hbC5pbi11bG0uZGU+ClJlcG9ydGVk LWFuZC1iaXNlY3RlZC1ieTogTWljaGFlbCBMYWJpdWsgPG1pY2hhZWwubGFiaXVrQHZpcnR1b3p6 by5jb20+CkNjOiBCYWdhcyBTYW5qYXlhIDxiYWdhc2RvdG1lQGdtYWlsLmNvbT4KQ2M6IExpYW0g Ui4gSG93bGV0dCA8TGlhbS5Ib3dsZXR0QG9yYWNsZS5jb20+Ckxpbms6IGh0dHBzOi8vbG9yZS5r ZXJuZWwub3JnL2FsbC8xNjk0MzY2OTU3QG1zZ2lkLm1hbmNobWFsLmluLXVsbS5kZS8KU2lnbmVk LW9mZi1ieTogTGludXMgVG9ydmFsZHMgPHRvcnZhbGRzQGxpbnV4LWZvdW5kYXRpb24ub3JnPgot LS0KIG1tL21yZW1hcC5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAx IGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbW0vbXJlbWFwLmMgYi9tbS9tcmVtYXAuYwppbmRl eCAwNTY0NzhjMTA2ZWUuLjM4MmU4MWMzM2ZjNCAxMDA2NDQKLS0tIGEvbW0vbXJlbWFwLmMKKysr IGIvbW0vbXJlbWFwLmMKQEAgLTcxNSw3ICs3MTUsNyBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBt b3ZlX3ZtYShzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwKIAl9CiAKIAl2bWFfaXRlcl9pbml0 KCZ2bWksIG1tLCBvbGRfYWRkcik7Ci0JaWYgKCFkb192bWlfbXVubWFwKCZ2bWksIG1tLCBvbGRf YWRkciwgb2xkX2xlbiwgdWZfdW5tYXAsIGZhbHNlKSkgeworCWlmIChkb192bWlfbXVubWFwKCZ2 bWksIG1tLCBvbGRfYWRkciwgb2xkX2xlbiwgdWZfdW5tYXAsIGZhbHNlKSA8IDApIHsKIAkJLyog T09NOiB1bmFibGUgdG8gc3BsaXQgdm1hLCBqdXN0IGdldCBhY2NvdW50cyByaWdodCAqLwogCQlp ZiAodm1fZmxhZ3MgJiBWTV9BQ0NPVU5UICYmICEoZmxhZ3MgJiBNUkVNQVBfRE9OVFVOTUFQKSkK IAkJCXZtX2FjY3RfbWVtb3J5KG9sZF9sZW4gPj4gUEFHRV9TSElGVCk7Ci0tIAoyLjQyLjAucmMw LjMwLmdjYTgxYWJhM2IwCgo= --0000000000009839770605806f0b--