From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62ADBC5472F for ; Tue, 27 Aug 2024 18:34:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C09F06B0083; Tue, 27 Aug 2024 14:34:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB89A6B0088; Tue, 27 Aug 2024 14:34:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A80186B0089; Tue, 27 Aug 2024 14:34:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 86C746B0083 for ; Tue, 27 Aug 2024 14:34:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DF1F5161407 for ; Tue, 27 Aug 2024 18:34:04 +0000 (UTC) X-FDA: 82498874808.14.900D21F Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf03.hostedemail.com (Postfix) with ESMTP id B45C42001F for ; Tue, 27 Aug 2024 18:34:02 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EFtybok1; dmarc=none; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724783623; a=rsa-sha256; cv=none; b=4XUMw6SQprnN9SwyPSmC1NUqVnasbr+XJ8zMXwxUq7TPOPkYqc4xAKZ8PonGT7R1nNn4gV Y5N3c7mVwp66Z1O5QJ0ZGLmy5nl1/sY7o66hI+hwGNzBH0N5ehHHKgOi4nmdBSM1/kEhyl P0d+queBcokU0OIGIMAfPKWLK7RGvj0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EFtybok1; dmarc=none; spf=pass (imf03.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724783623; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DExTwZMZtz5yc9KBU91nZu8gRhnDp+vsjXxHXMNDseU=; b=J5Y8Gjk9zI011yOtr1l3Lc518ygvL7eKDGzKEmpCMHvMHkm+lZ4z1Y8hn1hMuWyv9oked5 jWpz5fNaIQeznT6POzxuHcpcUx+PmqWkugbWkyhbRrl5DTqm99aDcng8S31nFHEqgM0lTP eTsaVusFlmDny6dDqS1kiSriXAmEyAk= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-53349d3071eso7151334e87.2 for ; Tue, 27 Aug 2024 11:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1724783640; x=1725388440; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DExTwZMZtz5yc9KBU91nZu8gRhnDp+vsjXxHXMNDseU=; b=EFtybok1B9n/1yMnNm6vUgLuGv1hd5/ZJSjmAv+I2SZgGz0Zj/KkWporexJlClLBEt eavlxXzgUO+IvLdmrPRWHMgjv3nmmBOi2ZlnSAlwcGhffjQ+xO+2+FAD7LOEsAtXTrCn UIHebphl8QEYKx/SSN8CrVzXXgH3R5ao88c1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724783640; x=1725388440; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DExTwZMZtz5yc9KBU91nZu8gRhnDp+vsjXxHXMNDseU=; b=SU28AkHtAIwG5MUL17yRtvU6aUObUZTUGRY8qehuPv831g6xIJjqcKJaVErpE7zzTg tZmMvLbAA2j4iatC0B7suke5j1EZTNu9258KPHgleygYxIgz56ahRIMDQ6kHlxix47sj bq1W1tPtNiyq9wvafkbIYX6Ocxvn+IPmn6ztp/sLZrlpFlh5B58sXsVs7WklBdAzWlX8 h1CUWYy+BS3V/ml5jY6lu3O4mgXcSS1n9AdrYEYhnLgCxNADKOEmca0qrmDB23BtOai4 Yct41zbN4h1mxtc5VUXwkbaFSZiXQ6+GvVrxBMKaWa57f0fpQoH8JkW450xNXssqKOdz tf0w== X-Forwarded-Encrypted: i=1; AJvYcCWCq0TkURo8eFKa494TiBYsStH0g+O9ioj/9JIisGR7rMYD8Lsbt1hRMtxfjGwwlwFfr3ps1btnLg==@kvack.org X-Gm-Message-State: AOJu0YyG1vBjGTyj1TsQlmJS2IeDj8kIRjSaDTwyQSiSVQStME6gmkTo fJshUdZj1CYfLwIbHlJCLtc/oKsj7x+J7x6ir178PLvY1GZt4YoZWCvQVXxc5tZDwfoLpGkgAlZ DhjmYgw== X-Google-Smtp-Source: AGHT+IGYlihR3xEg43f1oEkPKABxpMpPQv7Ns9G+/UGeh9udN0YXD0Uik7aIfoCL+m3cbZjis2Fnaw== X-Received: by 2002:a05:6512:6c7:b0:52c:a5cb:69e4 with SMTP id 2adb3069b0e04-534387c1741mr8995138e87.54.1724783639984; Tue, 27 Aug 2024 11:33:59 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5334ea59415sm1896990e87.120.2024.08.27.11.33.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 11:33:59 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5334b0e1a8eso7690324e87.0 for ; Tue, 27 Aug 2024 11:33:58 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWF+LeNuQ3V+63cjJU5LqQoF4hSIR0L8Mi09v8hbgqYyRcxUW8jeMXLzFlsweYfZaNjYMFEu2a8AQ==@kvack.org X-Received: by 2002:a2e:9c55:0:b0:2ef:2883:2746 with SMTP id 38308e7fff4ca-2f4f4965089mr86417741fa.48.1724783638526; Tue, 27 Aug 2024 11:33:58 -0700 (PDT) MIME-Version: 1.0 References: <20240827-work-kmem_cache-rcu-v2-0-7bc9c90d5eef@kernel.org> <20240827-work-kmem_cache-rcu-v2-2-7bc9c90d5eef@kernel.org> In-Reply-To: <20240827-work-kmem_cache-rcu-v2-2-7bc9c90d5eef@kernel.org> From: Linus Torvalds Date: Wed, 28 Aug 2024 06:33:41 +1200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] mm: add kmem_cache_create_rcu() To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , "Paul E. McKenney" , Roman Gushchin , Jann Horn , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: B45C42001F X-Rspamd-Server: rspam01 X-Stat-Signature: 5re9tfx54s7gizoxconb8gf5xgt4msg8 X-HE-Tag: 1724783642-99267 X-HE-Meta: U2FsdGVkX1/4yd0klB4dltT/nyFhPI9VlNaHzaFjXKvEwLx+29p05U3sMlkQ1i/+wD5mP+eIxcOjDyHWA1AH3bkcwhcu9x8eE65Ab/ioWyqlj+WN/XR46auJOQJz6mrkBj9S7WlI93kgEuU0NlPf1qe8+EDopRbL5ungqIjHGhCeNEOrgu2Y+VLXeRqsI01vim5LL4FhZ0g9a1kp3iiQD44Uo2sDX3rB76Q1UicPaI9Peyo2uP7+D7oqGQ1EWNSAF8IVZNf428xsicbyOV0wHlDSA/HJv4Ym+i/XhkKnKpIiBf1Fud/9dD22uLM2nNW78sIoCuzMkpW5rQbVW888SYewxVBPBHiNtieLMKQukzaUbLGWz/6KFkqBisTHFZYEko6/JZ76eDDFMX4+tGap14PMBszWu8s6Pnkul+Sz7iTXsTh0ARVzrS/JBqWdfAqCl5XLo/N6H7ZERVHUSwilVaYPD5/B1WHs81n7AHzF6nGVEDId2s1JLte5cIikuzHBftxM2bRBGKIEKGsN9QROBWEofw56TKISim30p9+ih1LmPJNbiikn+tbUFfW31F7BspT5lfSsBrgLhNUyHqQj7nTLy86B0FosMPWdT39qS6DkGmqyLfUurZjLg8C1bpeiWg8pqo/F+k8B+izLnc8QTKWQOxTQTl/3mMLBGRGu0Ollsh5vBqWqrnZuLcIUy4eK10SEmXlKw3h7/4S+1K5aeuRlzkKuCV0a3rNjfY3RO4Eouk8UrhDOuygi8Tyf76SG5BX/daqyUzOf1bnTZiYKNcTUW+DbwttT9l6c9AaGvLsJs0Tntyq4K/JUrC8rCcsfTg4iF3sfoBnXAD5oqD6Zvq4LaePV1jFfaeWM1mbyAYHEQB7y1W29H8Axr+5WvQpcmIHtUl4z30frGkcBmMU5hSXnYycnokFnsYd7rneDABgxfcGKT9bRpRguM98r/5MfT7nue9nlm0FtOHGoBOI 8yXENYZF hZgxlelqBlVOg528dp7AQXn2vhBy/o74YWpwiuRUIcZ2SPl3oqoBNO2HdXxhlLn99XLszEg/pdKb9i6yLi5z+wxAJ5w8iRPinzwGXHiNrBeMO/5nCzTpfNylu+USDqCYKahxa+HvvuFmZiOeLcNphYA6etaQ2TfOoNtm/gFmVHtO+iBZ9mfKT+ApUdWOisvz9LGLFDGgdoRnNvKEl/855EHlvNMeROHei/wFaVCMUUqJc4UwtQLaNFBqDBjOA03e+zbKkYroX5FKNSVdC+oktKa6YoOp+Ofp5KL2UA2XUXpdBIcJjNskEpX8njSdXd0GvKv4aMPDLCmkP5HzMpfot+JZV94TZZUpqTnKjAqE/yu+uBm6xWSEPbWr3VgtZRwSDNuE+oDyYHhT771BJXDij29LIHYNRaUlBCg0o/pwGnB6ZdpyR5EDBKtLRtpfu+7Q+ehiaEdyI2swommlPHxSbMFdGSV+eCGq3O53RwlClcwmfW/ET+6X/SVqZ1y5OkCGdouctL9IBAhW9ssKABG38tU5SiMp9B82N1DUIEaA7Dm5HE7Zn5nBM++HBnDwZqkEmSd4oMBBbzhOVOf0a1i9BPHw9wxLWMORitpU6/iy6A91Ajks= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 28 Aug 2024 at 04:07, Christian Brauner wrote: > > static struct kmem_cache *create_cache(const char *name, > - unsigned int object_size, unsigned int align, > - slab_flags_t flags, unsigned int useroffset, > - unsigned int usersize, void (*ctor)(void *)) > + unsigned int object_size, unsigned int freeptr_offset, > + unsigned int align, slab_flags_t flags, > + unsigned int useroffset, unsigned int usersize, > + void (*ctor)(void *)) I actually think it would be nicer at this point to have a "kmem_cache create structure", and not 8 individual arguments. But this approach looks fine to me even without that. Linus