From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE23C433EF for ; Tue, 22 Mar 2022 22:13:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FB406B0072; Tue, 22 Mar 2022 18:13:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AAEE6B0073; Tue, 22 Mar 2022 18:13:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 673136B007B; Tue, 22 Mar 2022 18:13:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 590236B0072 for ; Tue, 22 Mar 2022 18:13:30 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 1800280D40 for ; Tue, 22 Mar 2022 22:13:30 +0000 (UTC) X-FDA: 79273424580.08.2B99957 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 993A48001F for ; Tue, 22 Mar 2022 22:13:29 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id l20so32042723lfg.12 for ; Tue, 22 Mar 2022 15:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/JqUw7N0pQiYUGggfB1gLbjw37OlSObKornAcIsuE/w=; b=Pew1K7y3CpT1ghIeP6zNXgjqkgvlgq8GZ1eq5rwdB0TuKxLXxor0+ZVnKofKj/65cq oPtdFrkuNCC3crgTsACxwEy5zACBzm/eMnJg9RR8mpjJEzWJ3Ga1YUdGzrlkeM8D/fX7 Fig4PvN6JpjdY+i/+N2spp17GKwsylL5WTl0Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/JqUw7N0pQiYUGggfB1gLbjw37OlSObKornAcIsuE/w=; b=QwsN7ylBOif02GCelJ+dox4fLflIcA8dSp/7++38ezrrvpNhlGc9HUsTQbq4gkdC1p BRf8K2Ev4VpQBS9vF2s67sGbJghe9eGPlcOCs8GW1b9VRAnhj0193t3V7d0fDZKHKBz0 8PQygFHCjtfUuZVe17YXHp1zQcAz8vipWzarkZ754bAhiinxYfrYeu9j/sLOGVv4QlRW vnN6M5sMrMC28KYQARsQE8epKXU8BWd/HFabEsAsaoheeWzM0xOPppGeKaScy2U9hKOd 1Ovb69r6LnOnrL1SuO/2Bd/Ie6Szvl9J2MPjaFSDvYLkbvn0OVwOX9StqcsIlD7i2EbT efcg== X-Gm-Message-State: AOAM533S5P/Cv7nCC0+DVXYDJRhVLFYIMUnWmZU9MCuL6KS6L+cC6E1O psIBabdoiQyGMx/Yy4/22CmPcwDjAjjoJow+JlI= X-Google-Smtp-Source: ABdhPJzH1/S+CuyMAV9AD2pGGmv2K2XuMEl7W2lRUZKiAkhvPvt2ITx/BZb3BNeY/lzJclMObgaCxw== X-Received: by 2002:ac2:5085:0:b0:448:64f3:4ee1 with SMTP id f5-20020ac25085000000b0044864f34ee1mr19222068lfm.392.1647987207481; Tue, 22 Mar 2022 15:13:27 -0700 (PDT) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com. [209.85.167.45]) by smtp.gmail.com with ESMTPSA id u7-20020a2e1407000000b00247f17646b4sm2626064ljd.59.2022.03.22.15.13.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Mar 2022 15:13:26 -0700 (PDT) Received: by mail-lf1-f45.google.com with SMTP id a26so14119981lfg.10 for ; Tue, 22 Mar 2022 15:13:26 -0700 (PDT) X-Received: by 2002:a19:e048:0:b0:448:2caa:7ed2 with SMTP id g8-20020a19e048000000b004482caa7ed2mr20018350lfj.449.1647987206418; Tue, 22 Mar 2022 15:13:26 -0700 (PDT) MIME-Version: 1.0 References: <20220322143803.04a5e59a07e48284f196a2f9@linux-foundation.org> <20220322213840.3117DC340F4@smtp.kernel.org> In-Reply-To: <20220322213840.3117DC340F4@smtp.kernel.org> From: Linus Torvalds Date: Tue, 22 Mar 2022 15:13:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 003/227] ntfs: add sanity check on allocation size To: Andrew Morton Cc: Anton Altaparmakov , mudongliangabcd@gmail.com, patches@lists.linux.dev, Linux-MM , mm-commits@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 993A48001F X-Stat-Signature: ej9pt8xfodswhbpkxsfapwqoqr5oykzd Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Pew1K7y3; dmarc=none; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-HE-Tag: 1647987209-965712 X-Bogosity: Ham, tests=bogofilter, spamicity=0.005295, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 22, 2022 at 2:38 PM Andrew Morton wrote: > > From: Dongliang Mu > Subject: ntfs: add sanity check on allocation size > > ntfs_read_inode_mount invokes ntfs_malloc_nofs with zero allocation size. > It triggers one BUG in the __ntfs_malloc function. Hmm. A more serious issue seems to be that cast to (u32). ntfs_attr_size(a) returns a 's64', so it just randomly truncates a possibly bad value.. Linus