From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78782C433EF for ; Fri, 22 Apr 2022 20:35:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AD506B0073; Fri, 22 Apr 2022 16:35:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05B566B0074; Fri, 22 Apr 2022 16:35:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3ED36B0075; Fri, 22 Apr 2022 16:35:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id D7B026B0073 for ; Fri, 22 Apr 2022 16:35:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A847725164 for ; Fri, 22 Apr 2022 20:35:22 +0000 (UTC) X-FDA: 79385670084.24.BC521C0 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf17.hostedemail.com (Postfix) with ESMTP id 431FC40032 for ; Fri, 22 Apr 2022 20:35:18 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id g19so16269731lfv.2 for ; Fri, 22 Apr 2022 13:35:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LUIRwjAdRkEnvc7qu/4QggxdGOExn65onlukWBeFsUI=; b=drjmZFpO/eg/aqGWeRXDxMCuiAMKW8i3ror9N/4lB8yyadnzfP6lQwSgAMyFconsgF gtxeRu1lzm5b8ZvABGsb/Gg6xXWFCEfiAv57raWOKsjF3F86wC9KYCYdqkg5OlLl266C AY7IdQrNB2qHZU4X9tcv18FCJYEOYNS5JELfk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LUIRwjAdRkEnvc7qu/4QggxdGOExn65onlukWBeFsUI=; b=CW3mcMijW7tvlwNb/6Q9XkptVmp2IX8DIPB7hrxAsC53BJTmxwR8M8NtAft51N4pLK Fn1WDwb8QxDg1FH5hhxV6otaxq72KahV6QAbx3c8ykdHUbUjAVQLxDUECgCOMVDrVtkT FR0Z9sLftBM8dC21XQ2rmy3fPcnTD6XU5oqe7SPCHitwuAzOiTanMsYRZ37/Qlx/0caS HYbCAX7nwIPwb6c29+JGMNS+5dED9XbSuBSkoiRudHw0uf4MIBQDzDOHHJkWPceFLnrx 6bpbaaIIIqo1jtoYhteHRDfd2A9x5zSrDxOM0uznHfIGpgs50dJWgpOsz95DUVYFXdeu +QEg== X-Gm-Message-State: AOAM530NkDZbUbonnBG5+1r2TErWArUXvIckDvvLNTOStLGkYxV8uWA+ KqTMhOmSm38ukauezeW9+cfXPIaeBNttU4qemm0= X-Google-Smtp-Source: ABdhPJxy57QmLmFHh+fZbkWhi8lsQHvRa/O8+5AsXoBdp6eWjIGRLsiniRVsJxP3XQ7TLUVUFGIi6A== X-Received: by 2002:a05:6512:3a89:b0:471:c6ba:c522 with SMTP id q9-20020a0565123a8900b00471c6bac522mr4257928lfu.371.1650659720314; Fri, 22 Apr 2022 13:35:20 -0700 (PDT) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id n17-20020a19d611000000b00471b3db1166sm343693lfg.119.2022.04.22.13.35.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Apr 2022 13:35:19 -0700 (PDT) Received: by mail-lj1-f176.google.com with SMTP id f5so10986370ljp.8 for ; Fri, 22 Apr 2022 13:35:19 -0700 (PDT) X-Received: by 2002:a2e:9041:0:b0:24a:ce83:dcb4 with SMTP id n1-20020a2e9041000000b0024ace83dcb4mr3953312ljg.291.1650659719109; Fri, 22 Apr 2022 13:35:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Fri, 22 Apr 2022 13:35:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Rare page cache data corruption fix To: Matthew Wilcox Cc: Linux Kernel Mailing List , linux-fsdevel , Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 431FC40032 X-Stat-Signature: y68dxfcip655cxru4wccqsuwizawif3n X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=drjmZFpO; spf=pass (imf17.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1650659718-434964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 12:45 PM Matthew Wilcox wrote: > > Syzbot found a nasty race between large page splitting and page lookup. > Details in the commit log, but fortunately it has a reliable reproducer. The commit message does mention it ("I have not added a new test for this bug."), but I'll echo it anyway, since you say it can be reliably reproduced - getting that repro into the testsuite would be lovely. Linus