From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C680C433E1 for ; Tue, 19 May 2020 16:08:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0108C20823 for ; Tue, 19 May 2020 16:08:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="HCXGSXVr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0108C20823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6E9DC900003; Tue, 19 May 2020 12:08:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69948900002; Tue, 19 May 2020 12:08:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B08D900003; Tue, 19 May 2020 12:08:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 404E7900002 for ; Tue, 19 May 2020 12:08:16 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EFC0F8248047 for ; Tue, 19 May 2020 16:08:15 +0000 (UTC) X-FDA: 76833950550.27.chain54_4820b72e6c53d X-HE-Tag: chain54_4820b72e6c53d X-Filterd-Recvd-Size: 4008 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 May 2020 16:08:15 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id x27so11595957lfg.9 for ; Tue, 19 May 2020 09:08:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yx5q8kTLmBrxy32bs18zizlzOjtx0vFts57BKijzI48=; b=HCXGSXVripfdjF3MiGwI8HqE63+BVnW9g3cwRZiRc5Emx+jBu6A4Nsobp13SbpFd6U Lyt8wvpLjFnfI845wbjgkTVZflwu9OTBrRm/9vher3ASfX9/MH65gZZ8ahxQbI/5jnLa wMfTgbalXvP1B/G3Ib0nnbu0+sXLvWt0bQgfo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yx5q8kTLmBrxy32bs18zizlzOjtx0vFts57BKijzI48=; b=n0pnlC+jfW4BaiqSA9kk2BprG5tarCp84i1vzUq6zi8jB+hONhkaB6OglydVuIlIdW ZPzrRcnj8b3CtWGlTpeK1d+VhTefa1TrLGDDWOqNyTCA07U8J5ex6LL53tFBKJo+MQez NPB0DeEnTqw07lpazGpBXOdbZRqyL2k4JkpJIfhNYiVs721X9UK6Zck8CzTKmwbdvDsZ +PH+1qf5gETTB1qkWR7L4S4Ac5pJY9oY3W85NFuLYs6jo0FcCwiHmt5nrYiaOYr9lk3a FnCYmJE/7pRa5YgP/TNrJT8+s58c9Fvr6tuKv+reaQsFih3c8G9bTsewQCS7mo+oWn7Q fpTw== X-Gm-Message-State: AOAM5336IfeA1e4vmiQ2z2xK587xV7AgI/jM28TplD5yluxHLRUdc0kR 8VMRW9QNHR2BiIllSy5nj0In7SgikwE= X-Google-Smtp-Source: ABdhPJzY83xaBXDqjzIG/+SEPYcPuejD9BAnFqD5RYznuIaqctLX09IMibZ3YvqOUvWhSVIVQc4fGw== X-Received: by 2002:ac2:4562:: with SMTP id k2mr741780lfm.5.1589904493381; Tue, 19 May 2020 09:08:13 -0700 (PDT) Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com. [209.85.167.42]) by smtp.gmail.com with ESMTPSA id w144sm7894472lff.67.2020.05.19.09.08.11 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2020 09:08:12 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id a9so11715956lfb.8 for ; Tue, 19 May 2020 09:08:11 -0700 (PDT) X-Received: by 2002:ac2:5a0a:: with SMTP id q10mr1343727lfn.142.1589904491650; Tue, 19 May 2020 09:08:11 -0700 (PDT) MIME-Version: 1.0 References: <20200519134449.1466624-1-hch@lst.de> <20200519134449.1466624-12-hch@lst.de> In-Reply-To: <20200519134449.1466624-12-hch@lst.de> From: Linus Torvalds Date: Tue, 19 May 2020 09:07:55 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/20] bpf: factor out a bpf_trace_copy_string helper To: Christoph Hellwig Cc: "the arch/x86 maintainers" , Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Andrew Morton , linux-parisc@vger.kernel.org, linux-um , Netdev , bpf@vger.kernel.org, Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 19, 2020 at 6:45 AM Christoph Hellwig wrote: > > + switch (fmt_ptype) { > + case 's': > +#ifdef CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE > + strncpy_from_unsafe(buf, unsafe_ptr, bufsz); > + break; > +#endif > + case 'k': > + strncpy_from_kernel_nofault(buf, unsafe_ptr, bufsz); > + break; That 's' case needs a "fallthrough;" for the overlapping case, methinks. Otherwise you'll get warnings. Linus