From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51E6CC2BD09 for ; Thu, 27 Jun 2024 16:57:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD54C6B0096; Thu, 27 Jun 2024 12:57:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D852B6B0099; Thu, 27 Jun 2024 12:57:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C74226B009A; Thu, 27 Jun 2024 12:57:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A6FA06B0096 for ; Thu, 27 Jun 2024 12:57:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2653280C08 for ; Thu, 27 Jun 2024 16:57:35 +0000 (UTC) X-FDA: 82277274870.14.C6F62AD Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by imf19.hostedemail.com (Postfix) with ESMTP id 9FB081A0011 for ; Thu, 27 Jun 2024 16:57:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=P4roNGMO; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719507444; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i9kjtJnq6QUCFXqe7TVzsRwtJHG6pu+RYcniY0xGCVQ=; b=oPp7Vml5yqG18gX7tG31gJwve+5eRUojtfgc1+g+fMOL3kA9fsTPUgMtPf1LAYQ1w8Lzmo y/iaE7+5pmEP+E/tkFJsM8b66d9rBYk3RS77ko98KSuNKp5EYJHV0wxXO4t7Ma3BbnielS PHriONP/+DhSZZrWwD4KEvkx7rss5Ss= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=P4roNGMO; spf=pass (imf19.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719507444; a=rsa-sha256; cv=none; b=b1oN4E1LoTs1l9k8PhOUx+Izu+ffpR9rISv4+94TPFCc4mfFEXfOyXqnk/QPVpSNvdG/pA bW9kU27+KFxSTvVtBJG7esV0ScF1FCp/3RjBnSHK5lSH2vmu2Vyp5x0RcBCSDxJYlpwJsE L4nyTFa8+ilogw+/wubBBAcEisnm+8g= Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-52ce9ba0cedso6490347e87.2 for ; Thu, 27 Jun 2024 09:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1719507450; x=1720112250; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i9kjtJnq6QUCFXqe7TVzsRwtJHG6pu+RYcniY0xGCVQ=; b=P4roNGMO0jCfWez0rvHRDMJqZwC8q4B2Jt7k8Y4aZJVM1TtlEkRU1HCWZsk1OEyoPw +Qx5/heuXKpd0Ki8JAy4XO/U7NRlwIJKunmFooKSHruFEtVaaVjiQ/bP7dSUtE6ltBAs xytQkwUySxoxExJr2q1Sox4fL/at3BFY/391U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719507450; x=1720112250; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i9kjtJnq6QUCFXqe7TVzsRwtJHG6pu+RYcniY0xGCVQ=; b=G+iTKQokJUOql321HkGD8MYT/DifEi/TrzyS6YOREOiLrWvVggfOO2Ecx+Tmyaj/RL mDEDdnMYhVfE+glw4kdpk43DQT6HjqzqBAE6zSuchXAk7X4HkiEIsJWLMnp4NfWoduVC w5WOSLzWDu7UVuClSA2t/Kw7+RkVT4nW1QcHHqeKeHPuKFa+nQNESywKBmDiZHtTYgDl 5kBPTLpdgXKRvamswOQrLWCRp8agf+dNJOtiuY5oUMh2j/Q+IxXyvQuVVBSNzkuk8vNI VoHoGp7f7Okj6DPKwYsk56uV9l67GY0nX1BLPE68jo61HJigR+lUI/MFv8UxIyg2oqpD 0KmA== X-Forwarded-Encrypted: i=1; AJvYcCVxMc3Jh5OxyAaSOnPZmEqL5qIp60jOutWqOF4ViB1Om2FME0bEcw/zG7G5SGcEfsLdxa6PfUzJMz04NGiqFTmF/Ns= X-Gm-Message-State: AOJu0Yw3rvfjeCEmXXSVqcQ/GuaZ3mrNKxCgfH9EvSHVGFhh600UMq9k lYZvIgkhndTpZjCYL08uHT2B5oWAC5T0anTuKssznvyHyMhcrdXOyo0mNAsIeo6tenFNb56d2Z5 RGCQDbA== X-Google-Smtp-Source: AGHT+IGEMtWDDAXvcqvxyS7f3RmNv6pa6fvCYLoGOaTVdkkRtZWRJ1HcnTVEwzmkg5YG7oJ+3Sd5DQ== X-Received: by 2002:a19:5e16:0:b0:52c:db76:2a7a with SMTP id 2adb3069b0e04-52ce183576dmr9961590e87.34.1719507450499; Thu, 27 Jun 2024 09:57:30 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52e712a7601sm261021e87.35.2024.06.27.09.57.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 09:57:29 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2ec17eb4493so112956661fa.2 for ; Thu, 27 Jun 2024 09:57:29 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXJ8ePBNtITAKd/HKrc0nqcfKBlgkY845SiX/QH0uhOSYNH7kR5/yl0b9mGNRPhz+5Z5AKUkHsGBqk0/Tk95GJC10s= X-Received: by 2002:a2e:6a12:0:b0:2ed:5af6:e846 with SMTP id 38308e7fff4ca-2ed5af6ea7dmr41715831fa.50.1719507449392; Thu, 27 Jun 2024 09:57:29 -0700 (PDT) MIME-Version: 1.0 References: <202406270912.633e6c61-oliver.sang@intel.com> In-Reply-To: From: Linus Torvalds Date: Thu, 27 Jun 2024 09:57:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master] [lockref] d042dae6ad: unixbench.throughput -33.7% regression To: Mateusz Guzik Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Christian Brauner , linux-kernel@vger.kernel.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 9FB081A0011 X-Stat-Signature: 4a5dccutrgtgp9pumfhq8366b5uotkmh X-HE-Tag: 1719507452-952081 X-HE-Meta: U2FsdGVkX1+ejQ/JYliE02plZZMy3rwjvkPg58/k6WUEOfqlshAry2wZgbAKHeaW9kNNAAAhZx+N5/K4oosOB3kuHtQ7+Fh4XyYGKyQlDJt2r0V43eZyXLaTGWKhgNCcRG1Q4RX46WjrzyxuT2Y8BOJLieGl0Ih4uVveLFOfMN/4WNqwYfQuY40t8X8L5nTU5/eQwyp98zM5IT7/YQaAAX+II1foEJnUX2uFnsdCDJX5rW2jT0g8Zc/Nx2iJ7c0eOufIwnX1rMovmsm1YR5iEE+uT08RvmDgIQX63VsdyEyvKwJ5eaKe7u+ea07c3HGXEFosm+m1G28bsiw5XP/IVzIjK83N4CzMZ2JUeJwcf8e5xMpBs/Py+Y3q5+LsYva73DR+9a53IDuxJi8Yj1ZCFVn9nDrY1A7rXX7vbg/Jy6tQfFhpD2emocLglBIOGRqsAs2zVglsZdQz3+j8E5rV8w7lua9JnjRsWe2Uz7Uz3bm+AyzalPLhcJZkwbt3XUlJrmzdVXGtippCwJJKgSPSYGGCPW2whilpE66TokjbAhRH8oYUIR4Ch7mlwHIaTzdss6blr4Iy+4yEEzbwOt+HVs1KvceHPiGF9zppjDE1hZMfY9UNINz/ANCX2N+/l/6TplBlayEJ/Gev5HQMqlvXAtIz0yFX90Wwti2FV5f2EcdDj4YUtuKPqE4EQ93nnTLZI4H/lztEFcoJkYsASqN/sHJs8mx8H7fcO+W1O7OUvCTHh44Ogyf8K37FvkyCEFVNJD9hmaz/jmZUKLrUHmQxgGQF+cw4WOqJjUL1QlFwRzHuRfXe65JVlBoXuiqHCwUlTVXEhCuKekizk+d5IWe9h6GusaUsDh7JWM//sFfwfZENs8U/2Fn0fgkvkYqjsUaNusRdaZ6yhNZRCDfT9h+H4lvYO10XBeauJSfvGxkvCUrLFeMVBLLAxH+Xp4kTMDnb44E5O0LaL866jj0o0xR Xjyp0Dys Dq3vAFm8T3/yGPeorV0f7cSTOZxRHFSUIPkkIOQbuzDQRr5DuK6YHVS7da9mEqN/eii4jH8BmUxftsPp4TLX4my5oyOTccRb9WWJ9JCdPw2wiTFL9a/rKdKCRSk9DmWhEC8sEBtg2YSSrC4iue7sOnxIe7WsW5YEDIfTFT3rQ/NqeIerdh62CFtGKpGb+bR4b1zXJ0Ja5GDut5/SIpbYpRQmb4oYQ+OD8TNMqfhFHxPlHs0sfSANZpl/mcQVA7TzFzBdIJzo3LmZ17o7sEJwhfv/zIh065DrpG9RR2Z6aEM5PguUSSopsDAk+jAg/4jLDm8I6vaZpgt6kXbVuGITdD0woAsiNl/qmyJ23eVYwQphTiMsiMvzy9eI62NOgfSshoFc40eNoCzSWUJHJkZi+EbPNYYIIEi8/5mKOo8wMeltvdLw3HHiZ3cRE/pQ5POMI6ixPWkCmyjXnm00auKKAm2cuMyGL9OC0zeXG2banaYTeVX7EaJ0ODqJXE9HFMmtsgbyr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 27 Jun 2024 at 09:32, Linus Torvalds wrote: > > getdent subtest: > +4.1 lockref_put_return > +5.7 lockref_get_not_dead > +68.0 native_queued_spin_lock_slowpath For this getdents load, the main call chains that terminate in the queued spinlock case seem to be .lockref_get_not_dead.__legitimize_path.try_to_unlazy_next.lookup_fast .lockref_get_not_dead.__legitimize_path.try_to_unlazy.lookup_fast .lockref_get_not_dead.__legitimize_path.try_to_unlazy.link_path_walk .dput.terminate_walk.path_openat.do_filp_open which is interesting because I would have expected the readdir() code itself to show up. But the proc_pident_readdir profiles have all gone down, presumably because there's just much fewer of them. That part shows no spinlock in the profile at all. WTH is that benchmark doing? The only readdir that shows up is for what looks like some /proc filesystem thing. Linus