From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D967D1813A for ; Mon, 14 Oct 2024 18:10:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93CFC6B0089; Mon, 14 Oct 2024 14:10:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED226B008A; Mon, 14 Oct 2024 14:10:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B43F6B008C; Mon, 14 Oct 2024 14:10:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 56FF86B0089 for ; Mon, 14 Oct 2024 14:10:56 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 42CBCAB6AE for ; Mon, 14 Oct 2024 18:10:40 +0000 (UTC) X-FDA: 82672998702.10.AE5BC0E Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 3D2B71C0010 for ; Mon, 14 Oct 2024 18:10:46 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KztJRzvM; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728929265; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pHeyIJea3ALM6cFmjzsfw35tNiBlMHJavKPAe3QhB+o=; b=o73Wm/jYCn3TlF6Nh4gNI3ioFvlX14VdAyFOHgGvb6nb6x6Sap4X/x2Lnd/eBrYsfYQeYg uu6qCgtyPmvX3z4uqtEq4tn3cuTblxDSKpXTSZ69mzTXNdWN2oeW5eaL0oiOzyb3F+2y2q hwLdL4/FN+guZrTYeXmZaSnjiPAC4sg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=KztJRzvM; spf=pass (imf20.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728929265; a=rsa-sha256; cv=none; b=yxo9K8IvuHBcotZHUZ9qT7xVrJd5nvOGZUsLUm6i4CEAAZuzYGZx8PlKV3mBJfqqdFRQde xapLqSC70VVKwefcrQ9hSbhz+jD9z7edIsuyuP3CVYpz7Oa4hpaq20hZnv7H9FWaK1/VZL KRST8BmfXSE7PZwZiEm9REkIHWNXwlc= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5c9388a00cfso5479948a12.3 for ; Mon, 14 Oct 2024 11:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1728929452; x=1729534252; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=pHeyIJea3ALM6cFmjzsfw35tNiBlMHJavKPAe3QhB+o=; b=KztJRzvMQLfR4C6NDEaCQlPM4OntndYbeIWZ6w4x3U75rW1BObIrgtztObIfX04jyU 6yuqeDNZSy2wiUxeCYwsNdGMTWOxYhan2wTP5MJVmy5jg0vZeBGrmYpmk94nuzYyoshZ gvv668mBFl4sN1p2VdzkC3GmChOAJTdlMFHdU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728929452; x=1729534252; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pHeyIJea3ALM6cFmjzsfw35tNiBlMHJavKPAe3QhB+o=; b=Nx6DaLJrl5Z3ngb9TgTIhNzRxTI8s/v/aBECv5d5BOkboo931uRFSz9JStkApOBRIZ UwrO0ESKGBr/QbEbycqfFD+JxRjThgf6l3T1Mive6TYQydTi5kEdZtG4gZQB1fxqpOEj +35Sw4QnnNvM2fJMqiSE58bh/K+kC5lwdJkZyLJC7Olx9EfIQqJywXS73REaoxH94IZV FogdQTzhzDZkuCY/Of8zpqcAHpOleUjFe9Sraj19cchBH3Aqhmo51movo+HxvUSh5dLB KkIpN9Jy+TyaPNyRB7BnxuANgPtyzeJ8dyyucUCu82xpuOI3jVCPrmWSIscYwB2JD/mj 8b7Q== X-Forwarded-Encrypted: i=1; AJvYcCWXtjqrPVl4CLWtz3d38HMKGn5z1vvjljL8lAumQA1h3jGExphegcOvxEVCgorTWaosxGXeDu5whQ==@kvack.org X-Gm-Message-State: AOJu0YwQdci3y1yuDAuckoydULDdLuga5E6k3B1KarlZpNHv1HaUzCJG Sx9AfoC107bdhUir1AzeyPDhnRser4pIi/6xjzfjNtsjpscPDdMBMZlfnZ1Hkcc2whsSZ+5yrVE ELf92wA== X-Google-Smtp-Source: AGHT+IGgYMaE79uJKUX9kkbccYkE3ccfOQKrG86K4aA7ZUqIFHTmIgaERQgK3byKq4PfUOt8Gxu5Hg== X-Received: by 2002:a05:6402:51d1:b0:5c9:6e88:e547 with SMTP id 4fb4d7f45d1cf-5c96e88e82emr4875487a12.23.1728929452112; Mon, 14 Oct 2024 11:10:52 -0700 (PDT) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com. [209.85.218.53]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c9370d273fsm5459340a12.16.2024.10.14.11.10.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Oct 2024 11:10:51 -0700 (PDT) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a99c0beaaa2so567118366b.1 for ; Mon, 14 Oct 2024 11:10:51 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUneRoqeIlYrB1RYn8v4kJtDKIGbKwgzFKgaQr7pk1ta8+FEQYtrV6SNJbmFK/povjTnFn1N0Z+9A==@kvack.org X-Received: by 2002:a17:906:df46:b0:a9a:daa:ef3c with SMTP id a640c23a62f3a-a9a0daaf058mr273908566b.14.1728929451045; Mon, 14 Oct 2024 11:10:51 -0700 (PDT) MIME-Version: 1.0 References: <20241014125703.2287936-4-ardb+git@google.com> In-Reply-To: From: Linus Torvalds Date: Mon, 14 Oct 2024 11:10:35 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Use dot prefixes for section names To: Ard Biesheuvel Cc: Ard Biesheuvel , linux-kernel@vger.kernel.org, Masahiro Yamada , Nathan Chancellor , Suren Baghdasaryan , Kent Overstreet , Arnd Bergmann , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kbuild@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3D2B71C0010 X-Stat-Signature: 4kdqmchzcdr3cpbjbz8jqz7bd4cyjnc9 X-Rspam-User: X-HE-Tag: 1728929446-708419 X-HE-Meta: U2FsdGVkX19E/AhtGSNJsAxV+No8WNWyUdePzb87J3H7Wr7mn19u3A8jCFtEKA7cCZz0fqO8ZeRbAivW6cWeZgZ4xheEcxgAlfic5FXK7Tbs8XaNhvdnsIPuosWfob8/bom/pYZtJC9FbOParAD0RJ6nFEtGToWEECTNjOkmhC6ZPzZ4Pp2Y/rDpXN2ntI6KV6l9T4JA/YFKQvwg8v+9S0Gr/zCpvGCxIai39Y0ncSlRJE2LAPQblnQlRUAh9BSudCRLGU+0dtDjfUMb9hJomvJnv42pnH1+M7kFw27PXQWnSCcM7pwK3m1ckMi8LyIQez6qaOnODgVY0FPoKXfMR1GxfEqKDwzMdzEhVGMOl27lwhO6eFb/32i5nN3poZ0hK5YM9DSC1+BCer13y3GJXzTj3REFd1TVnQk0Z3ejlsWrh3TyMq6m4TwQtR/N+1Jzgdtg0gfbKR9Cgr7F2snEEmPeWYlLyt4SFw4Cslc8SrHIx16dbUzjsNiWOHhLKoWt6NpFHMZLQllTQr+1MHeAzdBLILZyJ+d6of4BHPbvAfk4hoRZe0QZiQl8JHCSKP/3mmZU9UHS4qbBrfjfhY8OfKrpdlJN1SlmQD2D5fndeW+LHESaUtz9YIngc18FTAsKccOTmlczPCb855yC3JndygLG+86SwnvUBiGhoZdBH/gN2Py//yIbrXy0a63uuQuF87pL22mEd4FEG8LZzW47MrLzU/GTG+7PW5mVLLJwL6HDl5zCtcdiddsjootODsp4GoAXqcq6a0907+z0vPxj9Ey/6cOA49Dgq4h9nIiVEkSvY1VQMMy7tG4lM7yt9hQs8xFi61aWy5fiuXcgYmsO0lZibIPpF4LwTTfZ096B98zGoXKClTmn8XrPfWnAFgPdYsmpoLVqx1iwq2rekkL91N87eMa0Paju//tKRydLAnUWNcuT5p/nhanx+3YMgwESQ6yOllsquAfbpQLGFor 5DXxx4yd As+uv47EJyGoO3LqHQ4GeR8zHH9MKPWSEb8hzcIofRFBETVt5fztAXDHNXZ69bvU+gu1EDrVcHYj55ybX0vc2BHQda0+zhS2LUxrwvkAVZhjVQHv302Xiwn7Y4bu8zkv9W6kGJ9NrXQBQu7TSiT6mVsqkT3j/DJiLcUmRiVqUeuj3bE5MvhlSlbGJ7geEiM7pbgIagwYmxO+gcjUcr2dt9Vmr4QjcLjox3xGKe4cIUCZgOr43V9unkjWe7TDWj1hgOVzvYwcnSQdJPEFQUI934LbXDG4w/va3rqxi+Y4E+JqBWjNDPwAQokN2+sTjbjwiZcSLODFOIikP+ZLMm0R4gdoYS5BEobiT9XGJa5PTkc2k7QXjq9DNzPZN4mKtFTV97/2oy7OTPGVXBVUm3uOS9EPZf6+agqK45O+U/ouHDDAa6zElL+NlaTEO1UgqO8sYE8+AsSzGiP0FF9nm5VaZhdO11/CHnMF3pWU6Bk0hOFi20aPFXDRFP1JXuD+n/2p11wsJQqTm2oMCg3oQhZDLevvJOEuiJfi+8zxxg81PZM9HpM+51rlCUNJWG2exEVX0p7qY6+NRaMEpR8gm3T5CykwcCoXeWQjn1rCB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000239, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 14 Oct 2024 at 10:44, Ard Biesheuvel wrote: > > We have this code in arch/x86/Makefile.postlink: > > quiet_cmd_strip_relocs = RSTRIP $@ > cmd_strip_relocs = \ > $(OBJCOPY) --remove-section='.rel.*' --remove-section='.rel__*' \ > --remove-section='.rela.*' --remove-section='.rela__*' $@ > > Of course, that could easily be fixed, I was just being cautious in > case there is other, out-of-tree tooling for live patch or kexec etc > that has similar assumptions wrt section names. I'd actually much rather just make strip_relocs not have that "." and "__" pattern at all, and just say "we strip all sections that start with '.rel'". And then we make the rule that we do *not* create sections named ".rel*". That seems like a much simpler rule, and would seem to simplify strip_relocs too, which would just become $(OBJCOPY) --remove-section='.rel*' $@ (We seem to have three different copies of that complex pattern with .rel vs .rela and "." vs "__" - it's in s390, riscv, and x86. So we'd do that simplification in three places) IOW, I'd much rather make our section rules simpler rather than more complex. Of course, if there is some active and acute problem report with this thing, we might not have that option, but in the absence of any *known* issue with just simplifying things, I'd rather do that. I feel that our linker scripts - and linking rules in general - are already quite complicated, which is why I'd really like to take this as a time to try to simplify the rules. Linus Linus