From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BAEEB64DA for ; Wed, 5 Jul 2023 17:15:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED6D28D0002; Wed, 5 Jul 2023 13:15:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E87578D0001; Wed, 5 Jul 2023 13:15:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D75838D0002; Wed, 5 Jul 2023 13:15:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C74028D0001 for ; Wed, 5 Jul 2023 13:15:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 853A51404A8 for ; Wed, 5 Jul 2023 17:15:34 +0000 (UTC) X-FDA: 80978209788.01.26BC4DC Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf07.hostedemail.com (Postfix) with ESMTP id 2A97840023 for ; Wed, 5 Jul 2023 17:15:31 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=C1zCtkZe; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688577332; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gVbA+8Izu9ivmJZn/qB70KgKLBZPRbZJf6rvmQg+Ec4=; b=MH4U3hHwevCkOeQWQPhJ6aYvz5gLHv0+/VZxQZddsxzfd85SsY5ySpwerj61MEY3CisncN 9QcXdy8OOeEA5Kq1xrZ3cpcoBCRAhtSSG8TVMW5i+8RqBBBBs03gpD/AxHTfk5bROBlz9H v86cHKbwjwDjoq3KTXRari4vVEMEmtY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=C1zCtkZe; dmarc=none; spf=pass (imf07.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688577332; a=rsa-sha256; cv=none; b=N3w1GIHEnA8d/Qq+QR28PQIv9PePECkqfsgKvIFnoXDMUs/PYI3TLHcyRmhTUov9/q4shh ZN6Yd31/qg2w0IEtJ4iIac/pvmAENOAJYDHSkDu9jRqzVuCgk1SIHPBZBvjOapVz7IqegE GcGGdRXHYeMOeEdaTHO1294gGUJWAJQ= Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2b69dcf45faso114749661fa.0 for ; Wed, 05 Jul 2023 10:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1688577330; x=1691169330; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=gVbA+8Izu9ivmJZn/qB70KgKLBZPRbZJf6rvmQg+Ec4=; b=C1zCtkZe0cDfiF5Y3w7+zNdsQeOj8x8Z5PIsWL3IcPb8Iy+oz/p8plvukxsGIIs8+I cQXrNWnTp5T/i/SUzTOlVV/WrXM+5VXjU8IW664Ovk3TNnvSloHZty6gSD5BmhI1y/Nv QOzfGsziV/s7QshFwAwK4iMKLQi1Ttr5SFEhQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688577330; x=1691169330; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gVbA+8Izu9ivmJZn/qB70KgKLBZPRbZJf6rvmQg+Ec4=; b=ASt3d5eTGA06x2SoAvRPZZ3N5m0i1hOBZ/obpI1xsyQtLjkg8NH/04+QVj+1SaW8mv T+Nqzbj65QjrFdHBtt+bMnSk5iUq1tlNTWLlFGbrmrBNMzBE6er62u5HHvlB3MRTq64Z PVNE093pS7MJLcNsgWBpXMqJbl0hJqdgRDZ5Usbs/3++G8L3pV9HBbEvXSVY3EzEv4Io 5MbBckwY8d9b25G+k5h6h798RADncbPGmHZ0A3qnZ3jgCJk3RwU6jzY26ULxr4OGeVx1 RqRlR1ZUrycXBh0o8Jt/jjWXMYOXKODcASBqHy3pw8Sgnzcmz+v/00abuB//0imCb91n oHtA== X-Gm-Message-State: ABy/qLYpXUL1fYs5h4ePI3qy8fHJFYCBBAoKRp8AtIFCSq3urJaIn2MB Humhrd55GDkrORux3UImF5Tt94jlPK1Q1qEyQyYK3Kcm X-Google-Smtp-Source: APBJJlFO+v9XeDYEMnoxfM6/bJiqqS0VmP66dPQzHGdW6UA9PNlHdPoKjHV8L5o22UxUM4lCAo4JtQ== X-Received: by 2002:a05:651c:231:b0:2b4:6bc2:a540 with SMTP id z17-20020a05651c023100b002b46bc2a540mr10884288ljn.15.1688577329528; Wed, 05 Jul 2023 10:15:29 -0700 (PDT) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com. [209.85.208.42]) by smtp.gmail.com with ESMTPSA id lw27-20020a170906bcdb00b0099315454e76sm6491238ejb.211.2023.07.05.10.15.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 10:15:29 -0700 (PDT) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51dec0b6fecso6893832a12.1 for ; Wed, 05 Jul 2023 10:15:29 -0700 (PDT) X-Received: by 2002:aa7:d5c8:0:b0:51e:fb9:7f20 with SMTP id d8-20020aa7d5c8000000b0051e0fb97f20mr6131122eds.41.1688577328716; Wed, 05 Jul 2023 10:15:28 -0700 (PDT) MIME-Version: 1.0 References: <202307041023.bcdbbfc0-oliver.sang@intel.com> In-Reply-To: From: Linus Torvalds Date: Wed, 5 Jul 2023 10:15:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linus:master] [gup] a425ac5365: WARNING:at_mm/gup.c:#__get_user_pages To: John Hubbard Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2A97840023 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: amyb8p7qyw65fn8u3ds4y8nf153gdebh X-HE-Tag: 1688577331-891408 X-HE-Meta: U2FsdGVkX18AzYGkYhGI6/Qjt1V6m5s0+B8/SlzOXYpSX6l8xFe79IDjdn6LIOB9y7iSo1xRLKhah4NxZHhwFbaSaVGZYZv1JkNOQzBb2sTlkk2HlsS1s1Z7ckZ6t4woOJIkCsUdVG01KrWY6PYSu6zJ9vN9ob/uhkWz3w7dP5SL+E/w15etMhLOy7WPdzKjMad4/ZO8eL/iMnOYtHV3A21tCICth9ULPwlm/nSqw1hIHHS+Wfr+xtlU+Q2GgTbTzqqan08GGIvW/nMdSKNn5KUfGZoqd55Rrb0UYcm0Qk//guW+d17Qoq+ISxxXPcUyhQhyqAY0n6XImQsQH0CLQs9M5aV7QjDL7zzHi18qjgrSmvZ3rSqDismfq6UjXnuh82XYXwIaTGDeQryG2E9zt+8G+TK83GQtAPkM7JVxqbz30TMeJ7dFjIkGYls1coCHUcCFvw4Nv2HPOjftgjxt+mMXhgzyX9yvu0M/Uz11FhzYd93eUPZY7Kjq2DZnuwRUBMQv+7L6OzUOcLKFDGnRQtAw/DNyuijH+t4PeTZTJaOTTYbk33LEzUoiLYxW6Y/z2uE645+f28a8dP4AWQ8nzWynvL8Wb0tWZcy9+JP9l2ZhJxI2PgXH+TfnHNQFahGUbKrLTWeWF5w5gRw6sM9PF3PS0NT4cR7+I+49moTU0oRtSOm/I3NDEdIc87jMx/LcJgTLG5mR2tjPeHQAXkI/gXLzhUM5JteYPWj71vLeo1P2zK1y3NiWfv5fD16OGPvM2YNoHl/l5RdWHwr4B6lTLYnT3wvFD0amtCw1jL6w2+rsbkTMg50fm7jkjNYx6uv1MLdHZoD/WKkiMbai6MuPnE7iOBn994PDnqJkFP11F0j7ThEbZb761qO3+EqktTzFuICsihzAUeGQ/E+aqJd+r7q/atqqmrndqRKRI/D8u37wIcS2DOwJWylvHkT2RWloK2FOh/+P97fdPEvQJIh opHVYlmv qblS5CdPQcSQGna77II0bCyL2S1VkgrWngCZbGxtqeWwGEezkmmk/VRWG0Jq0G2A+vv1746Uw23vU9yZHrnRrRfZMyHGdf3ycy6UdnDeIiLRiqBGWz9vrPDcfRHLhzHf+J19iCaPq6ZUAnG3F3uzcinzcrPbWfJENfPEbGatJ40Sd+EstRfyyO1+UY3WELxVz09OQDPPZcIxN22Jvd0Q3OAza0MvfFDulOWm/0fP++8i7wPk6dJzNZOmSzgm/6+8ytYxNImlqFjR6S20ZWpLs1ly2mUEVeIZeodNM6I+XKJpn1Uz/31s6Ea6oBV2wDOIs9IU3H3T2Tuj+Pqz2ALr90Szj7ZmlAuIB8vggsXfe3lMy8mF9+G24y+nCXXD6I/j18hNMJTGeIvUhJgCG4BITUrFZCkO4w+a1Ws4SUe+ynToAkQFgLOSBmSyQfKOp01fW5483bs/66zWt2pjL7Y1iKAo1b4UaTrUQdhUtHbN6yIR47aRlafC3gXZE77eAqhOSdJNApRA+OwhBG6+8vSRUeUbyxu+ejqn+fVXYQcnL0a1ghirCXUCeC8d9S0x7g7c+GOtr37cPz+OmJsqYuR8M5yr8U43OR7IutNPW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 5 Jul 2023 at 08:54, Linus Torvalds wrote: > > I'll tighten it up, and switch the WARN_ON_ONCE() to just do a > "dump_stack()" so that it won't cause problems with the syzbot tests > either. I pushed it out. It's based on the thing that Oliver already tested, but expanded a bit from that (and with a better calling convention, so that when we're done we can just delete the whole helper function and replace it with "find_vma()" like it is supposed to just be). It's lightly tested, but I no longer have any trivial ways to trigger the warning, so the testing was literally "now it doesn't say anything at all". It should still trigger the warning by literally doing some direct-IO GUP below the stack - but at least the obvious cases of false positives hopefully don't trigger. At least until somebody comes up with another obvious case that I didn't think of ;) Linus