linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: kernel test robot <oliver.sang@intel.com>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	 linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [linus:master] [gup] a425ac5365: WARNING:at_mm/gup.c:#__get_user_pages
Date: Wed, 5 Jul 2023 10:15:11 -0700	[thread overview]
Message-ID: <CAHk-=wjieeCJd+XYWHs9bR_-Bcw_OJiHDtK8NKGDeA_C_SuBng@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wgi--892SZiqC8JWvF-vE7C+82X0VPHTCwbUpmbJWT0fw@mail.gmail.com>

On Wed, 5 Jul 2023 at 08:54, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> I'll tighten it up, and switch the WARN_ON_ONCE() to just do a
> "dump_stack()" so that it won't cause problems with the syzbot tests
> either.

I pushed it out. It's based on the thing that Oliver already tested,
but expanded a bit from that (and with a better calling convention, so
that when we're done we can just delete the whole helper function and
replace it with "find_vma()" like it is supposed to just be).

It's lightly tested, but I no longer have any trivial ways to trigger
the warning, so the testing was literally "now it doesn't say anything
at all".

It should still trigger the warning by literally doing some direct-IO
GUP below the stack - but at least the obvious cases of false
positives hopefully don't trigger.

At least until somebody comes up with another obvious case that I
didn't think of ;)

               Linus


  reply	other threads:[~2023-07-05 17:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-04  7:02 kernel test robot
2023-07-04 14:12 ` Linus Torvalds
2023-07-05  7:27   ` John Hubbard
2023-07-05 15:54     ` Linus Torvalds
2023-07-05 17:15       ` Linus Torvalds [this message]
2023-07-05  7:41   ` Oliver Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjieeCJd+XYWHs9bR_-Bcw_OJiHDtK8NKGDeA_C_SuBng@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox