From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212ECC2D0E4 for ; Tue, 24 Nov 2020 23:25:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5382C2100A for ; Tue, 24 Nov 2020 23:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="eMtd8miS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5382C2100A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4E0E36B006E; Tue, 24 Nov 2020 18:25:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 469186B0070; Tue, 24 Nov 2020 18:25:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 330CD6B0071; Tue, 24 Nov 2020 18:25:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 195406B006E for ; Tue, 24 Nov 2020 18:25:16 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CF9541EF1 for ; Tue, 24 Nov 2020 23:25:15 +0000 (UTC) X-FDA: 77520894990.05.sort77_1905ac827372 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id B8AB818027A62 for ; Tue, 24 Nov 2020 23:25:15 +0000 (UTC) X-HE-Tag: sort77_1905ac827372 X-Filterd-Recvd-Size: 4818 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 23:25:15 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id u18so483935lfd.9 for ; Tue, 24 Nov 2020 15:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vZpDzZfRGW5JQ+z/SLaL70l0Y+Id271dyPmoJFXV3Yg=; b=eMtd8miSV5Q4HzVm9lx1snZ252JU2LUG08CXEG9MZekZ6i7RMmkka/lMY+IPVuJ23L PqhYtLLZg6ffJmiv3yaDYTznuv3dIQ4YBw1pOJz9r2vKjiack1bfddd/lir5cfbryUH+ /Jt2/UYsF/gTRVYdgZmuNAbHMgKvTDtyzGHaA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vZpDzZfRGW5JQ+z/SLaL70l0Y+Id271dyPmoJFXV3Yg=; b=S7D5Cu7qDRh3/1a174/2mAg9DSinh9NgHETNcMlnxR8+YsaYnwr9RhIA1XOWmjFzml EDIEa1P0ZMP+WC4JlMHNmmW6/DMvs86S8xluJucU7kvFcMpjGx04utpGFF0VBxDpZUi8 1OjbMZj8WmzSVVN4FeTIAvJ9iOC5F+WVI4IX9QhpkW1GbB9PMC0kwMkNvSf2Pp5UFW+q VrVAYz9C7yWNwJQq4jS1vmRwZItJD6UB/bBtgPXSaVHO+UNHhrfztN81XFresFcwXPz7 8nFKwQp5dObxvvmleDhkXzz89u46nS/AoMA0bS+l+ZVpeZDjKauYiqmDCxffpwiRouBn G0bA== X-Gm-Message-State: AOAM5332FVL0CjOGz6F0R7g+fD70SXSTyJgWfVhwfvBwGsos7pOOEviJ t+z7i/IihUZRLQvmTC60ouG/PTCn93uV6A== X-Google-Smtp-Source: ABdhPJzxSxF5jcas1GF8r8vc1XnbIDJbG9xR4V/atu41MB5RvJO3SxB5j+IOVlnN/R7+8wDub7DpkQ== X-Received: by 2002:ac2:5e72:: with SMTP id a18mr191953lfr.220.1606260313573; Tue, 24 Nov 2020 15:25:13 -0800 (PST) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id t2sm45894lfd.59.2020.11.24.15.25.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Nov 2020 15:25:13 -0800 (PST) Received: by mail-lf1-f43.google.com with SMTP id z21so463221lfe.12 for ; Tue, 24 Nov 2020 15:25:12 -0800 (PST) X-Received: by 2002:a19:ed0f:: with SMTP id y15mr172684lfy.352.1606260312243; Tue, 24 Nov 2020 15:25:12 -0800 (PST) MIME-Version: 1.0 References: <000000000000d3a33205add2f7b2@google.com> <20200828100755.GG7072@quack2.suse.cz> <20200831100340.GA26519@quack2.suse.cz> <20201124121912.GZ4327@casper.infradead.org> <20201124183351.GD4327@casper.infradead.org> <20201124201552.GE4327@casper.infradead.org> In-Reply-To: From: Linus Torvalds Date: Tue, 24 Nov 2020 15:24:56 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: kernel BUG at fs/ext4/inode.c:LINE! To: Hugh Dickins Cc: Matthew Wilcox , Jan Kara , syzbot , Andreas Dilger , Ext4 Developers List , Linux Kernel Mailing List , syzkaller-bugs , "Theodore Ts'o" , Linux-MM , Oleg Nesterov , Andrew Morton , "Kirill A. Shutemov" , Nicholas Piggin , Alex Shi , Qian Cai , Christoph Hellwig , "Darrick J. Wong" , William Kucharski , Jens Axboe , linux-fsdevel , linux-xfs Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 24, 2020 at 1:47 PM Hugh Dickins wrote: > > I think the unreferenced struct page asks for trouble. I do agree. I've applied your second patch (the smaller one that just takes a ref around the critical section). If somebody comes up with some great alternative, we can always revisit this. Linus