From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55262C27C79 for ; Mon, 17 Jun 2024 20:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE0386B010A; Mon, 17 Jun 2024 16:09:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8FCD6B010C; Mon, 17 Jun 2024 16:09:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92FEF6B010E; Mon, 17 Jun 2024 16:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 721826B010A for ; Mon, 17 Jun 2024 16:09:47 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 199311C1BC6 for ; Mon, 17 Jun 2024 20:09:47 +0000 (UTC) X-FDA: 82241471214.20.0E65846 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf29.hostedemail.com (Postfix) with ESMTP id 03003120010 for ; Mon, 17 Jun 2024 20:09:44 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Uuw3T0LV; spf=pass (imf29.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.171 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718654979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=32irAGR56mVNB9UGYg2c/DMgiXDqjQ+y0dbB2T9WACs=; b=Kkuv+4nOoPDrTAU1Wrv0m5wNfNxAaSqhvXkuN5LALNT9KS/2xAteeehrrI3j/85FutKM1c H4OTIbABeFXlQumO4Uq6dEKtISSHHvUKVUwzs8Nz1ephEbTRe7CJDvzGv3tZTHhPk8UOdW gx0pmEYszJUKOxvSzlOcL10WrXXa3Iw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718654979; a=rsa-sha256; cv=none; b=twHnLZMP7rdveia9nZHNz2OXzhDfC2pZ2xnKOq9/Cgd0Y6ld94HZgKvhV+cFEeq10BxV6c NRWZxsbwekNwF2DNs4TT49K25ERT8nTE3A2CFfcZ32T0JcDz9hBHvvzmMZDeAwgadFVgNA 5jun2cYYfaLbu3TwHz5yGnqLS6bw5aQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=Uuw3T0LV; spf=pass (imf29.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.171 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2ec002caf3eso79131051fa.1 for ; Mon, 17 Jun 2024 13:09:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1718654983; x=1719259783; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=32irAGR56mVNB9UGYg2c/DMgiXDqjQ+y0dbB2T9WACs=; b=Uuw3T0LVn7BhzOZ56fkJkbyeHPn+UalpzVnahlMHcKmdl5vxxT7HLV9LXuGqySJYzf Gd8gH5Zh9BPIXtx9QrUs/BY+o/a7n/BldO2yYGZUQLc6ZTO8MEWC5TqS/IW5/pre9gSz cHkvjK/R7H29tbDTC+VFiNT1G40dM/YmXnRbg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718654983; x=1719259783; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=32irAGR56mVNB9UGYg2c/DMgiXDqjQ+y0dbB2T9WACs=; b=C5yxLNpRfjj1izWY4TwUcQBsBNOG3u5py4si5NmFOu9YXzqlMgKqOI6Bwrc/hYn9DP RlGkPLwt+2d0BH41KgzivaRnzlCIIZYlfz8CQCEIuXURoVzA2peg7gJ0vTtWvkW3UXLD 8i2UI8gJ+TP2/aBZlM28Esmu1qjxTKwZrQzom9TrbjPKR8cxLwDeTD1LEAvoSDuh+8Ky pX4UsFEU5BByfHGKwmIb+3kF3MS6dGvPAGeHzEi/GYfIKjvbL43ULUDjNb6Sc5MufLYm /Y2OEq6tYTdJ9n2kmi4mK0r8r4UGSvVs9vMRzHR6bD1eGozljkzzrWvSlKI19pMtw7p/ ru5A== X-Gm-Message-State: AOJu0YzwYQC66nIz5F+/xB/Y9vI4cXX0ayjdyJKeHIuSzfNJaFW4TT+4 1dMH8R2ahtloKB3A+Ci8hsgdWyTceEPlwvi9Qd4sn6y6sr/aR7Qc4FzmNPmKITuufJnrsN5X0TO Gs3uAeQ== X-Google-Smtp-Source: AGHT+IGScGAXAlT6fZUu369Ly22UxEKS9UnoDqPqCMfNKbLqYN31KUNTH7PaJHIa17db8L1tpyr3Hw== X-Received: by 2002:a19:e047:0:b0:52c:804e:e831 with SMTP id 2adb3069b0e04-52ca6e929edmr9064873e87.47.1718654982855; Mon, 17 Jun 2024 13:09:42 -0700 (PDT) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com. [209.85.218.49]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56f42882sm544791466b.183.2024.06.17.13.09.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 13:09:41 -0700 (PDT) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a6efacd25ecso287911366b.1 for ; Mon, 17 Jun 2024 13:09:41 -0700 (PDT) X-Received: by 2002:a50:9e85:0:b0:57c:6031:8ebf with SMTP id 4fb4d7f45d1cf-57cbd6c74c8mr7654997a12.31.1718654981431; Mon, 17 Jun 2024 13:09:41 -0700 (PDT) MIME-Version: 1.0 References: <20240617114712.45d4743f8bacb832dea4b5a9@linux-foundation.org> In-Reply-To: <20240617114712.45d4743f8bacb832dea4b5a9@linux-foundation.org> From: Linus Torvalds Date: Mon, 17 Jun 2024 13:09:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] hotfixes for 6.10-rc5 To: Andrew Morton , Matthew Wilcox , Rafael Aquini , Jiri Slaby , Suren Baghdasaryan Cc: linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 03003120010 X-Stat-Signature: uosg7msa55k9i1krf7kwpurjwm1mhd75 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1718654984-318758 X-HE-Meta: U2FsdGVkX1+yZq6tRVAXVoNoXgKNXAAN2mtkcFiTsOYnov5Vp03aGhGUMNd1q1TqkbjSUmw0HdMgysITIVnhvzQHqpS8OaL68WnXWKGUJdSWNBpWye43VnGOcuTXB20o8sWEPeo/uF9VnKTOEyGDXykdop7+T3ULPZKfLSgDckqjp10ZMsMABsHQ45y8WqNYYxhmTvWCcz7nrKYgHz/JaQq+1Sa6ccI/iG0ffdW3MwaUHddXdtO3rFVieduW3/U2sy/gwc73oOcna/PtARgoE4yAE4WN2vb4hpBRymFf8DOXb2BpvdRUEGiTORs4KqTlVzWmmhaZYeXU/VQ8nTXlhsfTM5iUDW1AU+M+pGgAFjuraSRwpPBAVb0O1w3wpyTwFHSX5nIL6LXuaM4kFTER4Nhxss2VB37dDqZ8q8Y/jKkjZKL3jWXdNkncrgkZggobmVGto7Swdr/RnJh4pEFiyIIrYc35oej1reAvqaNMoeAq7XG91diRxUza97F4A5NAZ7R/pVkX3JqJVpFaAlUdMIqqMxN+ANO8Ig/YaMUODoRH8cd7ZoGjPiqoX3Et8WsovCFgQUOTwnj5f48gMsS9dHx7Pj+QTP4/cw7BVdkKDrwI7EHYMCHKRkxjzgDtIX4XnLiJFovFGWsDQqO7I+WMIhc4RxjDekHltxgETpuImeXX2i7TPFx0aLQOsPrwkroF1JkI4w8I2aY2PVxOVH9y+HX76a18ZQNDHLcuBD/nsDThYOWJm6+ilrNEBL+IJIyc4whHZkKxJgTpDWliD4kihx9jJ3d8T8lQmDbkMMiUUPOmjUdhx0bk/BDkcO6DIgvaG3cJ6OaBJmM0E6keEIAmCMPUaeClnZV0634Z0QTEMNnTJlv/lzjDY+Mjd7YkmSo6zXoRFC+VGIM1Dc/ph7Wzl178Zlfm/qS0YyK44iJDLxlbteVyVkJzELfriZ88/ApbjvtzFFs4xg7E07/KSmL uSYjgYdh bXU3FoMadpgzAKjnqkicjNuOJcwB8CV2o7YO18mZ/zHt21Ih6DVxUUTfZJNxAHr2hk+20bXPlqsYiEixD2zVVH3Zd1iDHvtnKPJoQ6nMmhMm29IH980IxLGBnO0eJ4FcC6C4NbZjvv6tjkr+uR+9mX7O7ukvsKbcFGC4TIVnpo4CAF3xP1SfchlnKDDWAtaXXV8DSYqPXD0/R0mtLMjgJV+UgexFPoyntCbDlqbwHKNc1PAJmJKqWKHZO048o6oy7iKRjkCpUj+Xz6vjNn+Lu9a4DBm1fqJK4Y1kPAlVKBs4KqKDRMHgNlYqHK36O2rW5+IuRmCZ+okqct4BHNomqYvmYGl88DOo9jQG4Tsngy4jDCqiJF5rYG5cbTCjoCuvn1C6vZ35vQ1R9PtGtRhit0IVparugb1htR7GF72ZNGTdDvHzRszgMKCOATmS4c4jbMQ6WWPcor0TEMSthMFPXQmt2cOD5eBomqdQdqQ+3tGiuVAGEmFi/yTp2t1brnCTfZj/S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 17 Jun 2024 at 11:47, Andrew Morton wrote: > > Rafael Aquini (1): > mm: mmap: allow for the maximum number of bits for randomizing mmap_base by default No. And HELL NO! We're not adding *another* new random incomprehensible config option that tries to fix a random case that no normal user will understand. Our kernel config is too damn complex as-is. We're not making it worse like this. Anybody who cares about this kind of crazy esoteric detail can damn well just set their Kconfig manually, instead of forcing this kind of insane questions on other people. This Kconfig insanity needs to stop. Why do I need to be the person who says "STOP ASKING POOR USERS IDIOTIC QUESTIONS THAT THEY CAN'T SANELY ANSWER" I've pulled, but I'm reverting this commit. We are *not* going down this path of insanity. I'd also like to note that the reported 32-bit issue was ALREADY FIXED months ago by commit 4ef9ad19e176 ("mm: huge_memory: don't force huge page alignment on 32 bit") It's possible that we should extend that - much saner - fix to also look at the number of bits for randomization even outside of 32-bit processes, and judge things on the number of bits we're expected to randomize mappings on. So it's very possible that the if (IS_ENABLED(CONFIG_32BIT) || in_compat_syscall()) return 0; test in __thp_get_unmapped_area() should be extended to take requested address randomization into account. But there is NO WAY this is fixed with another completely incomprehensible Kconfig option. So I'm really unhappy about this. The whole "add idiotic random Kconfig options" needs to stop. Those options are not something a normal person can understand, and as shown by the fact that this patch was already bogus and superseded by a much better patch from months ago, clearly said Kconfig options WEREN'T EVEN UNDERSTOOD BY VM MAINTAINERS! Christ. Sorry for the shouting, but dammit, people need to really internalize the whole "we don't add crazy Kconfig options". Linus