From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8602BC19F2D for ; Tue, 9 Aug 2022 19:08:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D26818E0003; Tue, 9 Aug 2022 15:08:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDF948E0001; Tue, 9 Aug 2022 15:08:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4D298E0003; Tue, 9 Aug 2022 15:08:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A5B658E0001 for ; Tue, 9 Aug 2022 15:08:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 779FC1611C8 for ; Tue, 9 Aug 2022 19:08:07 +0000 (UTC) X-FDA: 79780989414.28.C8CED27 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 17BF640181 for ; Tue, 9 Aug 2022 19:08:06 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id a7so23897320ejp.2 for ; Tue, 09 Aug 2022 12:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=vMeWdqqUKrZihbEodx8DwkpktZOsjqJwuhJAUzg6EtM=; b=fsrqe+6vo9uENLGFyCV6+pgoTqjKv1mEg1PRj6og2Ud/MBa8diFjRhLhNp/FTkemmU vUWMlyD0tpPtsXxRgtuml1g7Ab5JSwvzh4+5oeiGYZVt4iAWoilXnit41pgP1cvRktE8 SjaI6/b5+Nxv18jobwJDWK6xFLulMWU2a18Qs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=vMeWdqqUKrZihbEodx8DwkpktZOsjqJwuhJAUzg6EtM=; b=R9fTIeAqYe+j8gYVrOrmFqre64cbtdU5Jvqho+GR4YUDlNf54LdbLeQZkz403mdFNn mF1Png5myEufyPt2U6Adb7wTOr7Es7FgKzK1A9MSjrAMpNhFAfMsmISqL8OFYOLdte+7 ipXX+W9tkElSBL2ccdfi0pNYmynonHN3NX3bA6PU6w1IfXngodzGhSxDHWBr6J5Wj16o v2nHOaiCLtr3Nxf4RP8/vNNnegFVekaZnleBJeE05NrKJiYFCJ7qO6c5AQz7egECLje+ j2TytaWdvRlLG495YC2Kav35yeGx+VWk8Votr/OneF4cRKdDhOGThhcU0Q4TVHhHDzEk uTgg== X-Gm-Message-State: ACgBeo0kboJ8eJqSIYDANBGKJgeDVKTCLyeM4BwnNQSRxgdEIFYB2Xu6 T/Fg90p8BNpNowvnX4qei80pBdK4H3sPQ0NidS4= X-Google-Smtp-Source: AA6agR4On50OyTCfrN/kr9ht4ZqIaALPHlSdUk2PNfQ/rIT19sbwyqofcEG0ClX7Wtai7STyYir6VQ== X-Received: by 2002:a17:906:7e43:b0:72b:52de:b039 with SMTP id z3-20020a1709067e4300b0072b52deb039mr18231903ejr.198.1660072085683; Tue, 09 Aug 2022 12:08:05 -0700 (PDT) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com. [209.85.128.42]) by smtp.gmail.com with ESMTPSA id p19-20020a170906785300b007305d408b3dsm1442005ejm.78.2022.08.09.12.07.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Aug 2022 12:07:52 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id b21-20020a05600c4e1500b003a32bc8612fso6314247wmq.3 for ; Tue, 09 Aug 2022 12:07:48 -0700 (PDT) X-Received: by 2002:a05:600c:1d94:b0:3a4:ffd9:bb4a with SMTP id p20-20020a05600c1d9400b003a4ffd9bb4amr16389223wms.8.1660072067208; Tue, 09 Aug 2022 12:07:47 -0700 (PDT) MIME-Version: 1.0 References: <20220808073232.8808-1-david@redhat.com> In-Reply-To: From: Linus Torvalds Date: Tue, 9 Aug 2022 12:07:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] mm/gup: fix FOLL_FORCE COW security issue and remove FOLL_COW To: Jason Gunthorpe Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, Andrew Morton , Greg Kroah-Hartman , Axel Rasmussen , Peter Xu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Vlastimil Babka , John Hubbard Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660072087; a=rsa-sha256; cv=none; b=Pl0mZFDGRBSXj9OCKXvFAZv45ZrKM4UbCAh1/YqENO7VE8I0+JrmmVstLjE7ys7HIDmzwK hknxdhZ0lyrxUn8j7hjPALUhyTw52a5AZqsSD+m11sg0Ohkr+qPMj+5mtPRN5jpOOdlTX+ cn/QRJvXYb0tx75jFKp0C86KyRw51S8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=fsrqe+6v; dmarc=none; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660072087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vMeWdqqUKrZihbEodx8DwkpktZOsjqJwuhJAUzg6EtM=; b=e6rXonb20NdZsXHbBt1TMNGkJgxywPrtfwK8RoB85aFJlQ2pSWJ0vPyWpi6LJFAA+uUQuo i8Z/WdEYDWtzNnIbwUksZv11uW8IWamuW3fw81eDwd75SOGX+QJqlWWdTPpuYh8rGoKFE6 0bs3k2kGNystgHe7bpQINHp2tQI3oHk= X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 17BF640181 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=fsrqe+6v; dmarc=none; spf=pass (imf01.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.48 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-Stat-Signature: btx4cr4j33hea4tjcw1u5erge97axzya X-HE-Tag: 1660072086-204597 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 9, 2022 at 11:48 AM Jason Gunthorpe wrote: > > It is because of all this madness with COW. Yes, yes, but we have the proper long-term pinning now with PG_anon_exclusive, and it actually gets the pinning right not just over COW, but even over a fork - which that early write never did. David, I thought all of that got properly merged? Is there something still missing? Linus