From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89EA5C433EF for ; Sat, 13 Nov 2021 20:16:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A9C261168 for ; Sat, 13 Nov 2021 20:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A9C261168 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 56D856B007B; Sat, 13 Nov 2021 15:16:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 51C2A6B007D; Sat, 13 Nov 2021 15:16:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C1C6B007E; Sat, 13 Nov 2021 15:16:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id 2E7776B007B for ; Sat, 13 Nov 2021 15:16:25 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E1DBE8249980 for ; Sat, 13 Nov 2021 20:16:24 +0000 (UTC) X-FDA: 78805014288.11.815973B Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf18.hostedemail.com (Postfix) with ESMTP id 874114002088 for ; Sat, 13 Nov 2021 20:16:24 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id v11so52627062edc.9 for ; Sat, 13 Nov 2021 12:16:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fUJ4RyiarGckKo6VaSVoc1S73NVAy1M1UHBUtVn+dXA=; b=EaXFmIPMUnTgemqp00jPWEfQekTJEO+Ri6p4PaQ/16UHBdOb9ItZ0WOZOFZUkNiiRi FZyi/kGYjiDPRfQKh3bwlsZq+60tiJynG7F3+ibuuppJcsSf9a30BqwExZcV38EvafA8 JIIu4eL7YOOKdKpH1945V2GZXkPy7E8ziEZDE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fUJ4RyiarGckKo6VaSVoc1S73NVAy1M1UHBUtVn+dXA=; b=rnC39DWsq5U3NdZpCp660LnA0ajbAB+Pmnp+Bqz8Dsp76lXJCxSJus4pPH5Cx0k6dS I/MSQIyMovnqwAF+EeWK9sS9iWpM8mHOLx+sCKzmwFjBUjxzO1dqcPMevOe2T4Ui24my MeMEHs9Mwu5pokZBqoA3GvPN4dDGBKmCUJQms7TFzOvEfDjRtuKq7DcMreGRcdHcYQDl vRNKHkiU9112BxBDn4JU0nxEj4TB+vsmU9d5x1DuBD08Diqpc4B3BEMBRG0WFi0vFRYS wNGIZcGVe53sLudryjit6Z3cbup9QqEC4aaCwuiBPmXYOtZph7azT6kNzsPgRIAJduWy F0Wg== X-Gm-Message-State: AOAM532BrxdGnYJR0I/jczus1ODhdoAEY4fR2QvuV+Nz0EHZzX6BSuxd eoOXNIl3jP5noJ5LcJgAF5yUbUvTdABynFkmfYk= X-Google-Smtp-Source: ABdhPJyruVPwxqUYF4txckHOlVzPl6Y6pImLT5ISARlRP2N7sc6D04gILYgU/gQYApgTDa7pVR6few== X-Received: by 2002:a17:907:2da3:: with SMTP id gt35mr32857461ejc.314.1636834582579; Sat, 13 Nov 2021 12:16:22 -0800 (PST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com. [209.85.128.46]) by smtp.gmail.com with ESMTPSA id e15sm1933261edq.46.2021.11.13.12.16.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Nov 2021 12:16:22 -0800 (PST) Received: by mail-wm1-f46.google.com with SMTP id i12so9684322wmq.4 for ; Sat, 13 Nov 2021 12:16:20 -0800 (PST) X-Received: by 2002:a1c:7405:: with SMTP id p5mr44079154wmc.152.1636834580292; Sat, 13 Nov 2021 12:16:20 -0800 (PST) MIME-Version: 1.0 References: <20211111084617.6746-1-ajaygargnsit@gmail.com> <628a49dc-f6f7-5aa4-8a4d-4f2ed19b7f3f@kernel.dk> In-Reply-To: From: Linus Torvalds Date: Sat, 13 Nov 2021 12:16:04 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm: shmem: do not call PageHWPoison on a ERR-page To: Jens Axboe , Arnd Bergmann , Yang Shi Cc: Ajay Garg , Hugh Dickins , Andrew Morton , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 874114002088 X-Stat-Signature: fidou7cknc6kc7gnki7a3swpmryf4mu7 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=EaXFmIPM; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.45 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-HE-Tag: 1636834584-509274 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Nov 13, 2021 at 9:21 AM Jens Axboe wrote: > > Maybe Andrew is out - Linus, if you follow this thread, there are two > proposed fixes for this. It'd be nice to have one of them in -rc1. Neither of the fixes were sent to me, and honestly, I think the real issue is that the original commit is just too broken for words. The error handling in that commit is just entirely lacking. I've reverted the commit rather than try to fix up the breakage. Because at some point it's just better to say "that was broken" rather than try to fix it up. And that original commit was too broken to be worth fixing up. It already had one fix for uninitialized variables before it even hit my tree, and then caused problems and had obvious broken error handling. Linus