From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4ACEC433E0 for ; Sat, 26 Dec 2020 21:16:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F47E207B3 for ; Sat, 26 Dec 2020 21:16:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F47E207B3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BEA208D0093; Sat, 26 Dec 2020 16:16:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B98B78D0080; Sat, 26 Dec 2020 16:16:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A86F18D0093; Sat, 26 Dec 2020 16:16:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 88E408D0080 for ; Sat, 26 Dec 2020 16:16:30 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5107E180AD811 for ; Sat, 26 Dec 2020 21:16:30 +0000 (UTC) X-FDA: 77636692140.29.form74_5114b9c27485 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 3343218086CCF for ; Sat, 26 Dec 2020 21:16:30 +0000 (UTC) X-HE-Tag: form74_5114b9c27485 X-Filterd-Recvd-Size: 5423 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Sat, 26 Dec 2020 21:16:29 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id a12so15971568lfl.6 for ; Sat, 26 Dec 2020 13:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GQiB/N6vURjg6dOpOwGpn1IZbShpuFXt1LxjdVRRQl0=; b=QrKZyWIlQNpwpRfYAap3JBcf1Rgjp9mla47l8nPjUk+LtWkutlhkno0HRaeI8l01ze 7YIPTHmo7LEq6IcMWLNMdhZlYCfg4QQhLa63QwOUx0LM6Bq2XGpMey/60px88MgTnk+d uD/J9oj4ov7JCZjqnNkqKHZ6HLd20toudEO48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GQiB/N6vURjg6dOpOwGpn1IZbShpuFXt1LxjdVRRQl0=; b=CxSHxJyAVyq9QJWkT4N8hWuVUo/g2Ecpp7+iU36i4OyGQd+rwcdJITvP/qGXL8HIle BL6pEbBS7iU10fSsOkFDclKgRrzQd/Nb3RbvxlktUpsKIiNrpsubCanIFhgGyCrxRdW5 8GNTCIo8Ko8r53uLeUPSyTKzjFTlsuNTq7Y7N6ApcbkKXDQ8LE9NY6OUDo7T6rv0IxCc xtvQ0iZ2ZAu4me0X/Zv7xLEEg8I5TPs0Yqk9KE78HGy0La/Nr9FhQEeT1ZDKmKxYjZv8 Jc6lOBF3swCq/XJAZD37CQJQJvQhQ0LPuFd7TbxyTY1h9iGZb3+FDVbmjy9TEONsVl7m b4EQ== X-Gm-Message-State: AOAM530H5ptQ9Jo5t4x9CmAVIItEf/FiDWvPm1gJdvZdVKLc2V6f0TWp TnjpJ0PmYjVrBC9fSHIWmyDpJsjOc/mMeA== X-Google-Smtp-Source: ABdhPJzKwR7xeRS0YQlmP9qumCRM1Mq+q6fJTPzVWKU6I+kFYSCMsVQlDDO/5vQGIgdGSbiW4mYYwQ== X-Received: by 2002:a05:6512:689:: with SMTP id t9mr15543566lfe.78.1609017387467; Sat, 26 Dec 2020 13:16:27 -0800 (PST) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id j1sm4716462lfg.225.2020.12.26.13.16.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Dec 2020 13:16:26 -0800 (PST) Received: by mail-lf1-f43.google.com with SMTP id h22so16025836lfu.2 for ; Sat, 26 Dec 2020 13:16:25 -0800 (PST) X-Received: by 2002:a2e:9b13:: with SMTP id u19mr17749625lji.48.1609017385687; Sat, 26 Dec 2020 13:16:25 -0800 (PST) MIME-Version: 1.0 References: <20201217105409.2gacwgg7rco2ft3m@box> <20201218110400.yve45r3zsv7qgfa3@box> <20201219124103.w6isern3ywc7xbur@box> <20201222100047.p5zdb4ghagncq2oe@box> <20201225113157.e7hmluffh56fszfc@box> <20201226204335.dikqkrkezqet6oqf@box> In-Reply-To: From: Linus Torvalds Date: Sat, 26 Dec 2020 13:16:09 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] mm: Allow architectures to request 'old' entries when prefaulting To: Hugh Dickins Cc: "Kirill A. Shutemov" , Matthew Wilcox , "Kirill A. Shutemov" , Will Deacon , Linux Kernel Mailing List , Linux-MM , Linux ARM , Catalin Marinas , Jan Kara , Minchan Kim , Andrew Morton , Vinayak Menon , Android Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Dec 26, 2020 at 1:04 PM Hugh Dickins wrote: > > > Hold on. I guess this one will suffer from the same bug as the previous. > I was about to report back, after satisfactory overnight testing of that > version - provided that one big little bug is fixed: > > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -2919,7 +2919,7 @@ static bool filemap_map_pmd(struct vm_fa > > if (pmd_none(*vmf->pmd) && > PageTransHuge(page) && > - do_set_pmd(vmf, page)) { > + do_set_pmd(vmf, page) == 0) { > unlock_page(page); > return true; > } I missed that entirely, because when just reading the patch it looks fine and I didn't look at what do_set_pmd() function returns outside the patch. And maybe it would be better to write it as if (pmd_none(*vmf->pmd) && PageTransHuge(page)) { vm_fault_t ret = do_set_pmd(vmf, page); if (!ret) { ... instead to make it a bit more explicit about how that return value is a vm_fault_t there... And see my other email about how I suspect there is still a leak in that patch for the previous test-case. Linus