linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: "Jeff Xu" <jeffxu@google.com>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Pedro Falcato" <pedro.falcato@gmail.com>,
	"kernel test robot" <oliver.sang@intel.com>,
	"Jeff Xu" <jeffxu@chromium.org>,
	oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-kernel@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Kees Cook" <keescook@chromium.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Dave Hansen" <dave.hansen@intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Guenter Roeck" <groeck@chromium.org>,
	"Jann Horn" <jannh@google.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jorge Lucangeli Obes" <jorgelo@chromium.org>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Muhammad Usama Anjum" <usama.anjum@collabora.com>,
	"Stephen Röttger" <sroettger@google.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Amer Al Shanawany" <amer.shanawany@gmail.com>,
	"Javier Carrasco" <javier.carrasco.cruz@gmail.com>,
	"Shuah Khan" <shuah@kernel.org>,
	linux-api@vger.kernel.org, linux-mm@kvack.org,
	ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com
Subject: Re: [linus:master] [mseal] 8be7258aad: stress-ng.pagemove.page_remaps_per_sec -4.4% regression
Date: Mon, 5 Aug 2024 17:13:34 -0700	[thread overview]
Message-ID: <CAHk-=wjeWqr+0Ktzbwqrw17aESe5dZm5Kt6nwqtKJX00VsDqWg@mail.gmail.com> (raw)
In-Reply-To: <D38D6LJZOIQK.2GV58PGVL5K85@gmail.com>

On Mon, 5 Aug 2024 at 16:25, Nicholas Piggin <npiggin@gmail.com> wrote:
>
> Can userspace on other archs not unmap their vdsos?

I think they can, and nobody cares. The "context.vdso" value stays at
some stale value, and anybody who tries to use it will just fail.

So what makes powerpc special is not "you can unmap the vdso", but
"powerpc cares".

I just don't quite know _why_ powerpc cares.

Judging by the comments and a quick 'grep', the reason may be

    arch/powerpc/perf/callchain_32.c

which seems to have some vdso knowledge.

But x86 does something kind of like that at signal frame generation
time, and doesn't care.

I really think it's an issue of "if you screw with the vdso, you get
to keep both broken pieces".

           Linus


  reply	other threads:[~2024-08-06  0:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-04  8:59 kernel test robot
2024-08-04 20:32 ` Linus Torvalds
2024-08-05 13:33   ` Pedro Falcato
2024-08-05 18:10     ` Jeff Xu
2024-08-05 18:55       ` Linus Torvalds
2024-08-05 19:33         ` Linus Torvalds
2024-08-06  2:14           ` Michael Ellerman
2024-08-06  2:17             ` Linus Torvalds
2024-08-06 12:03               ` Michael Ellerman
2024-08-06 14:43                 ` Linus Torvalds
2024-08-06  6:04           ` Oliver Sang
2024-08-06 14:38             ` Linus Torvalds
2024-08-05 19:37         ` Jeff Xu
2024-08-05 19:48           ` Linus Torvalds
2024-08-05 19:50             ` Linus Torvalds
2024-08-05 23:24             ` Nicholas Piggin
2024-08-06  0:13               ` Linus Torvalds [this message]
2024-08-06  1:22                 ` Jeff Xu
2024-08-06  2:01                 ` Michael Ellerman
2024-08-06  2:15                   ` Linus Torvalds
2024-09-13  5:47                   ` Christophe Leroy
2024-08-05 17:54   ` Jeff Xu
2024-08-05 13:56 ` Jeff Xu
2024-08-05 16:58 ` Jeff Xu
2024-08-06  1:44   ` Oliver Sang
2024-08-06 14:54     ` Jeff Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjeWqr+0Ktzbwqrw17aESe5dZm5Kt6nwqtKJX00VsDqWg@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=amer.shanawany@gmail.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@intel.com \
    --cc=feng.tang@intel.com \
    --cc=fengwei.yin@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck@chromium.org \
    --cc=jannh@google.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=jeffxu@chromium.org \
    --cc=jeffxu@google.com \
    --cc=jorgelo@chromium.org \
    --cc=keescook@chromium.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=oe-lkp@lists.linux.dev \
    --cc=oliver.sang@intel.com \
    --cc=pedro.falcato@gmail.com \
    --cc=shuah@kernel.org \
    --cc=sroettger@google.com \
    --cc=surenb@google.com \
    --cc=usama.anjum@collabora.com \
    --cc=willy@infradead.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox