From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E30C2D0C6 for ; Wed, 11 Dec 2019 20:03:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B6936206A5 for ; Wed, 11 Dec 2019 20:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="al6iELda" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6936206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 23E3A6B33A5; Wed, 11 Dec 2019 15:03:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6AA6B33A7; Wed, 11 Dec 2019 15:03:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 08E546B33B6; Wed, 11 Dec 2019 15:03:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0089.hostedemail.com [216.40.44.89]) by kanga.kvack.org (Postfix) with ESMTP id E39BF6B33A5 for ; Wed, 11 Dec 2019 15:03:47 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id A9BC3181AC1F5 for ; Wed, 11 Dec 2019 20:03:47 +0000 (UTC) X-FDA: 76253936094.15.song45_5b4018a169850 X-HE-Tag: song45_5b4018a169850 X-Filterd-Recvd-Size: 4532 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 20:03:46 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id e10so25480693ljj.6 for ; Wed, 11 Dec 2019 12:03:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ARg/+L4b2QIR/B9zIQc3US5T+eVRe9Cf50TlETDyNaM=; b=al6iELdaRQuI0zpwDdTfK6nolqCFFm3GeyTbURFnuQx3l3Gazb6Tek0ArH9y2SX5mj ifsQj5G0solgyBXOD8mZItnFHBffKhpIKNK26Ergh9hSZEoHOJWUgHwG+n3+CPziqfcP XZM+UMagtUrNJXK+iqlOjo+Rihu5Abb63zLsQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ARg/+L4b2QIR/B9zIQc3US5T+eVRe9Cf50TlETDyNaM=; b=QsJgco9avzHvI27kQCkwj3DvQbrYAaX36DUZLqOmGgJQ+rlVLsZcvHMK7maDqM464Q okovk2gO+83FxZtsHUOxTsz7yF8MlwRT6xhBR9btpGdDTt0esguUiLq3zL2l62QQ0ECN 4ZtdWV8vGS6FIil2ytGqveFDF7kyF9JSYb2OfV++VlgerkYw6PlBlcmCVBpGLzrdYuvB 1x3vyKO3ROBAnTEXk0sgs/y/yQTEZ0cGp+C/YW9SSZR9naYNGHc8a9CdAKYIB34UxBTa hr0Iaw1Aig81k084WihAJ/vDBteqd9OOGRFkVwi0s/KeNZwMpaKlpb2IPQNSX8Af8SN5 pBVA== X-Gm-Message-State: APjAAAUKfzua0c6/YIZq90/Y8gTtVF0ONCwNk0px50JFUNG7G6UVphZy 7o4QNFg6gmk7agd0Hy5MQEJ7eh3FntA= X-Google-Smtp-Source: APXvYqxD634YKIgI9f3xgbnaIeRUUlq9dWg489SUKN+ALnHpURIMXAtFcDGaatxHNUGzIC/zGzdUqg== X-Received: by 2002:a2e:9b52:: with SMTP id o18mr3341190ljj.205.1576094624841; Wed, 11 Dec 2019 12:03:44 -0800 (PST) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com. [209.85.167.50]) by smtp.gmail.com with ESMTPSA id k5sm1707840lfd.86.2019.12.11.12.03.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 12:03:43 -0800 (PST) Received: by mail-lf1-f50.google.com with SMTP id 203so17625642lfa.12 for ; Wed, 11 Dec 2019 12:03:43 -0800 (PST) X-Received: by 2002:ac2:465e:: with SMTP id s30mr3498008lfo.134.1576094623187; Wed, 11 Dec 2019 12:03:43 -0800 (PST) MIME-Version: 1.0 References: <20191211152943.2933-1-axboe@kernel.dk> In-Reply-To: From: Linus Torvalds Date: Wed, 11 Dec 2019 12:03:27 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHSET v3 0/5] Support for RWF_UNCACHED To: Jens Axboe Cc: Linux-MM , linux-fsdevel , linux-block , Matthew Wilcox , Chris Mason , Dave Chinner , Johannes Weiner Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 11, 2019 at 11:34 AM Jens Axboe wrote: > > I can't tell a difference in the results, there's no discernable > difference between NOT calling mark_page_accessed() or calling it. > Behavior seems about the same, in terms of pre and post page cache full, > and kswapd still churns a lot once the page cache is filled up. Yeah, that sounds like a bug. I'm sure the RWF_UNCACHED flag fixes it when you do the IO that way, but it seems to be a bug relardless. Does /proc/meminfo have everything inactive for file data (ie the "Active(file)" line is basically zero?). Maybe pages got activated other ways (eg a problem with the workingset code)? You said "See patch below", but there wasn't any. That said, it's also entirely possible that even with everything in the inactive list, we might try to shrink other things first for whatever odd reason.. The fact that you see that xas_create() so prominently would imply perhaps add_to_swap_cache(), which certainly implies that the page shrinking isn't hitting the file pages... Linus