From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F01C433E3 for ; Tue, 18 Aug 2020 19:02:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 663992076E for ; Tue, 18 Aug 2020 19:02:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="OdFylsap" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 663992076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D836A8D0003; Tue, 18 Aug 2020 15:02:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D338A8D0001; Tue, 18 Aug 2020 15:02:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4A7B8D0003; Tue, 18 Aug 2020 15:02:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0162.hostedemail.com [216.40.44.162]) by kanga.kvack.org (Postfix) with ESMTP id AE8C88D0001 for ; Tue, 18 Aug 2020 15:02:04 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 64B0B181AEF09 for ; Tue, 18 Aug 2020 19:02:04 +0000 (UTC) X-FDA: 77164609368.18.grass70_4d0f1fd27021 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id 3547E100ED0FE for ; Tue, 18 Aug 2020 19:02:04 +0000 (UTC) X-HE-Tag: grass70_4d0f1fd27021 X-Filterd-Recvd-Size: 3811 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 18 Aug 2020 19:02:03 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id h19so22634106ljg.13 for ; Tue, 18 Aug 2020 12:02:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nQVuZWCOnlFwQnX2Zqx0X5sy3pLItQeKoPELobHQVGQ=; b=OdFylsapCoULupAOYKw2uxh3CBvd6ctb0Q+oE4KHDc7exoz8gPT0JzpVzCs2UFYloZ pdfG98SZ4TKORf3pZEGIPjJidGca60aMQLOi2nen+7fHRK9fQJKdqmCu+AFXvUdhjWjx E0UpiJcscdcfZTXaD9DYNr+NvdEPSVQoYZIRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nQVuZWCOnlFwQnX2Zqx0X5sy3pLItQeKoPELobHQVGQ=; b=RYWSgu3C3uRISXxwcW2+/K3nfF/FOMqk6OZ51qmh/z2gciwKjQknq5gVTuVDoCTog+ G+WhTMNDmGsrVCTUUY3eVPeAVYHWRvS3fNn/J/uDEnd06rPRNpOYB8YqAAU4EPleIKG9 O5hsIZIFCFU2g827B50Xn42p9dh8a++f9Ya4xsbI8OO7f2v35PPJzkb8cn6JKl8AMgP2 S78cn7vJ050bhNTD7/6xZWInuoZJqOZPM+ppMizrurk4wmZM+x00Js6nMzLa0RCH54YJ +dtNZ9Ea2LbHZcgJmhfMU/Nou7Ebeq3hsBODaupEuWeVKb1F2r3YTxfIvc5yoxdvLDtv cTjg== X-Gm-Message-State: AOAM532aFWma3nBJU6azqUrfyuXzloUWQdlFtknR5owuOXLf2w+R4jaz +bAZaA2YWLvnGgrpYSzJJGsXB1Rcz/o//Q== X-Google-Smtp-Source: ABdhPJzzFJR0LUOO2Pcn6EDpSOmH3mzc6OVrR7hu9EfdYHXZ+q8Otrb83wdFeBguLDGuH7xBveIEqA== X-Received: by 2002:a2e:9e97:: with SMTP id f23mr10441944ljk.216.1597777321065; Tue, 18 Aug 2020 12:02:01 -0700 (PDT) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com. [209.85.208.174]) by smtp.gmail.com with ESMTPSA id a21sm6159023ljh.114.2020.08.18.12.01.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2020 12:01:59 -0700 (PDT) Received: by mail-lj1-f174.google.com with SMTP id v4so22684724ljd.0 for ; Tue, 18 Aug 2020 12:01:59 -0700 (PDT) X-Received: by 2002:a2e:7615:: with SMTP id r21mr9769511ljc.371.1597777319256; Tue, 18 Aug 2020 12:01:59 -0700 (PDT) MIME-Version: 1.0 References: <20200815043041.132195-1-shy828301@gmail.com> In-Reply-To: <20200815043041.132195-1-shy828301@gmail.com> From: Linus Torvalds Date: Tue, 18 Aug 2020 12:01:43 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v3 PATCH] mm/memory.c: skip spurious TLB flush for retried page fault To: Yang Shi Cc: Yu Xu , Johannes Weiner , Catalin Marinas , Will Deacon , Andrew Morton , Linux-MM , Linux Kernel Mailing List , stable Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 3547E100ED0FE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 17, 2020 at 2:04 PM Yang Shi wrote: > > We could just skip the spurious TLB flush to mitigate the regression. Ok, this patch I will apply. I still hope that arm64 fixes (maybe already fixed) their spurious TLB function, and I think we should rename it to make sure everybody understands it's local, but in the meantime this patch hides the regression and isn't wrong. Thanks, Linus