From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [GIT PULL] non-MM commits for 6.2-rc1
Date: Mon, 12 Dec 2022 18:44:18 -0800 [thread overview]
Message-ID: <CAHk-=wjaO_S-kMb1n00suvnTBQS=mY2tH-YG9Tti_5pxnn_tzQ@mail.gmail.com> (raw)
In-Reply-To: <20221212183554.e0a2536e860172282b189ca4@linux-foundation.org>
On Mon, Dec 12, 2022 at 6:35 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> Well here's a hacky thing - just look for duplicated patch titles after
> stripping away the hashes.
Please don't do that.
Just use the git machinery that Vlastimil pointed at.
"git cherry" uses the actual patch ID (which is just a hash of the
patch with whitespace removed), so it actually looks at the patch
itself, not just eh first line of the commit message.
If you insist on writing your own shell script for this, please use
that same "patch-id" logic. That's made available by "git patch-id".
But do "man git-cherry" and "man git-patch-id" before you do any of that.
And in no situation should you go "the first line of the commit
message is identical, so the patches must be the same".
Linus
next prev parent reply other threads:[~2022-12-13 2:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 21:44 Andrew Morton
2022-12-12 22:16 ` Jason A. Donenfeld
2022-12-12 22:27 ` Andrew Morton
2022-12-12 23:16 ` Vlastimil Babka
2022-12-13 2:35 ` Andrew Morton
2022-12-13 2:44 ` Linus Torvalds [this message]
2022-12-13 2:58 ` Stephen Rothwell
2022-12-12 23:33 ` Linus Torvalds
2022-12-13 1:32 ` Linus Torvalds
2022-12-13 1:39 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjaO_S-kMb1n00suvnTBQS=mY2tH-YG9Tti_5pxnn_tzQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox