From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F75C4332F for ; Wed, 2 Nov 2022 18:02:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D1C18E0002; Wed, 2 Nov 2022 14:02:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 081B18E0001; Wed, 2 Nov 2022 14:02:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E643E8E0002; Wed, 2 Nov 2022 14:02:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D41098E0001 for ; Wed, 2 Nov 2022 14:02:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 94A9FA11D9 for ; Wed, 2 Nov 2022 18:02:10 +0000 (UTC) X-FDA: 80089271220.04.80870CC Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by imf25.hostedemail.com (Postfix) with ESMTP id CECD2A000B for ; Wed, 2 Nov 2022 18:02:09 +0000 (UTC) Received: by mail-qk1-f170.google.com with SMTP id z30so12260451qkz.13 for ; Wed, 02 Nov 2022 11:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+tfgl/2wz1H/8UpZUR1BGxO9QY8fMwSWN8ozNgnnwNo=; b=NeK0NeRjuTAZUtHhMjgNyr6bYudXXk6DWAHX3bTjmN4JSWdzL6JeZGWMcTF+HKB1jh MxgfTRp94CqtCSRHcGW+QimC0eY6cr+M+yV1ssIcn+3APuGyZYLufIf07JWzaUc4957/ eUOIf2N32qzKN+9Hwta9aX6xiuqzbYaFCmZks= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+tfgl/2wz1H/8UpZUR1BGxO9QY8fMwSWN8ozNgnnwNo=; b=DsKR3wKFnMI5gTtsqQHE3cD4a6CjY8STZlJ/bDDx9fW8Z6eMGdACyAsoboIwWd/fyv MJivN/drML8PuxKTH7jOQQt0XOVS4jl+qxiWJM3gBid0qldcaFruCOc8mSPV2rjn3eDO u+oy14IX4G8zywPuSYkZdMGPNTHyYi/l2ctT87MKhJDayFb0Sg7KSNdG3CiIv+1f33WJ dQXE4o2HWmAMj8RtrimQnoWue9busc2KCtUbTsJ5qk1wSX0JnzrEaymnqhFFEeHVa18x 8gytLklCyWKxeSEslO3zS2iBJcnt8QfoYOQlfHNgrxR3zrCX7DIh0jidWQF38QIJiOMV IuUg== X-Gm-Message-State: ACrzQf1hjzZNZB5bQMfOF9gkYutH7NbD9kQc09vzczuCKCY3NE1fX6WP wV9u6WxYil8ZXm4MwCuPZC5berqrhhk4lg== X-Google-Smtp-Source: AMsMyM7lmwVQM1VRCNVSjsz0Yhx4n3DLOcKuU0lL0XPeJL5Wa3F5hku7+UpRXSuBUVVuhOpszGSsbA== X-Received: by 2002:a05:620a:1293:b0:6fa:4e62:ad8 with SMTP id w19-20020a05620a129300b006fa4e620ad8mr6195303qki.128.1667412128721; Wed, 02 Nov 2022 11:02:08 -0700 (PDT) Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com. [209.85.128.169]) by smtp.gmail.com with ESMTPSA id n6-20020a05622a040600b003a51e6b6c95sm5759741qtx.14.2022.11.02.11.02.08 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 11:02:08 -0700 (PDT) Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-36cbcda2157so173358417b3.11 for ; Wed, 02 Nov 2022 11:02:08 -0700 (PDT) X-Received: by 2002:a81:114e:0:b0:36a:fc80:fa62 with SMTP id 75-20020a81114e000000b0036afc80fa62mr25201108ywr.58.1667411726040; Wed, 02 Nov 2022 10:55:26 -0700 (PDT) MIME-Version: 1.0 References: <47678198-C502-47E1-B7C8-8A12352CDA95@gmail.com> <140B437E-B994-45B7-8DAC-E9B66885BEEF@gmail.com> <50458458-9b57-aa5a-0d67-692cc4dbf2ad@linux.ibm.com> In-Reply-To: <50458458-9b57-aa5a-0d67-692cc4dbf2ad@linux.ibm.com> From: Linus Torvalds Date: Wed, 2 Nov 2022 10:55:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: mm: delay rmap removal until after TLB flush To: Christian Borntraeger , Gerald Schaefer Cc: Peter Zijlstra , Will Deacon , Aneesh Kumar , Nick Piggin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sven Schnelle , Nadav Amit , Jann Horn , John Hubbard , X86 ML , Matthew Wilcox , Andrew Morton , kernel list , Linux-MM , Andrea Arcangeli , "Kirill A . Shutemov" , Joerg Roedel , Uros Bizjak , Alistair Popple , linux-arch Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NeK0NeRj; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667412129; a=rsa-sha256; cv=none; b=OXrRpQFW9cIg9spGxzseVgm9WbqNBxBc1prLLZkNByqTksHELASbcLQRl10EsQbKJrYjg3 0yieKM7SupD2KcvBUyDpesRK4kOK8RbaMSrdcFNVc2ApzGZz9SqeiUuUqdMyRyfBGzQcuK nvoe4CRYrzOiuYw0GFHHsFcWZ8Vn5v4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667412129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+tfgl/2wz1H/8UpZUR1BGxO9QY8fMwSWN8ozNgnnwNo=; b=Lt1EVmKQvKqPeSJhHdOqx6cJvcuCfTXfRa9qN7xCkzglZZpobBj30+kostUYKVftQAv3pt mOUN7dvxjEFLyydx4oqkALdJHeWGzKYicMXLBq2zM1fHxkyUyDUJaSVwXupYljRFITmvGJ gFF651d/YaE8tR/GYDxltvbNUGE7oMg= X-Stat-Signature: o8h1oa6srzgquc1whj68kzn4cbnh1yhb X-Rspamd-Queue-Id: CECD2A000B Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=NeK0NeRj; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1667412129-158764 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 2, 2022 at 2:15 AM Christian Borntraeger wrote: > > It certainly needs a build fix for s390: > > In file included from kernel/sched/core.c:78: > ./arch/s390/include/asm/tlb.h: In function '__tlb_remove_page_size': > ./arch/s390/include/asm/tlb.h:50:17: error: implicit declaration of function 'page_zap_pte_rmap' [-Werror=implicit-function-declaration] > 50 | page_zap_pte_rmap(page); > | ^~~~~~~~~~~~~~~~~ Hmm. I'm not sure if I can add a #include to that s390 asm header file without causing more issues. The minimal damage would probably be to duplicate the declaration of page_zap_pte_rmap() in the s390 asm/tlb.h header where it is used. Not pretty to have two different declarations of that thing, but anything that then includes both and (which is much of mm) would then verify the consistency of them. So I'll do that minimal fix and update that branch, but if s390 people end up having a better fix, please holler. Linus