From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1AEEC77B7E for ; Thu, 25 May 2023 17:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0EE26B0074; Thu, 25 May 2023 13:53:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC1D66B0075; Thu, 25 May 2023 13:53:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8552900002; Thu, 25 May 2023 13:53:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CA1756B0074 for ; Thu, 25 May 2023 13:53:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7A2DC40C10 for ; Thu, 25 May 2023 17:53:19 +0000 (UTC) X-FDA: 80829524118.01.8C9DDBA Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf24.hostedemail.com (Postfix) with ESMTP id 7A547180011 for ; Thu, 25 May 2023 17:53:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=D6d6iUjk; dmarc=none; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685037197; a=rsa-sha256; cv=none; b=ajYpJcsKRKB5b2MlRKuteRAW1Aqipr3igrvGrd5WTRxZNx88WSyvC8jU1RGPEcsWhn3tUZ hbOKuIPsH27CL9p0TogXhSOb268MkNI9+LnHwDY3c340eunmRB6CFLfGXwcYEFLjIHtyKA v8YchdeNQ6Z998fGwv52ikEjFZ1qMyc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=D6d6iUjk; dmarc=none; spf=pass (imf24.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.44 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685037197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cki7nTSfn8V9Pz9bjx+wUZ3Q24K9M6RV4kOzAoI4Ezk=; b=T0dWwOaw2rpmC0o+AxOKV+LWc2h2lXQV5vebW0i/XZmbvBkNZw2pKDrpV1ng+C3v8lYJNb 3knuy8BCPSnsvUpryZDDXXZPJzwwf3oU1UEeQR1jvbJjG9c2yD0ks766Ek3NzoqQOBbkQT bV1josS9SFoqBXUheL9rkye3qkcaYkg= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-96f0678de80so164421066b.3 for ; Thu, 25 May 2023 10:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1685037196; x=1687629196; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Cki7nTSfn8V9Pz9bjx+wUZ3Q24K9M6RV4kOzAoI4Ezk=; b=D6d6iUjkz46uF5lcM4xKnjVBYMFgwmzQC2Gv7q7jtoXAmTPH31SoeNZ0EYsFNq1HCL FHpt6Dqayp7iUP4uroXvnZ9Te7yirPRkuvgSsmVXAi+VukHYxVB1yXCM7U/snsD/n8G+ YDlUCHjvQ7SUxSCmocrK/cFYALfbBFxqZRtjQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685037196; x=1687629196; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cki7nTSfn8V9Pz9bjx+wUZ3Q24K9M6RV4kOzAoI4Ezk=; b=XsuQ70a3N46YRJA3co0pY8CR6Xuf/Vup2s+7B/dZfyxaRBEF7gkT9uRzVxhCuwFvOl 6oL1Lc4HD+S03vc99Hzsg9BXZcnxPb8kZUhVlJ7oBWbT/0XCS2W3o7aTpzwkUUiaaT3n zojTQEXaXKouye/CPaSl0c60q6C7cP5tZUyGPOFE1t9gngidmcLhSoCCulBK1PMeivQM xDzqvNgFs8bPiOsKXDBMq5mP2bTCSnQyOXmPV3hJ3tAufNf2ocF+FKKntNBKSaYJ5Ct7 u2LtDV4KTTiTApYzGtemGyJtwVvq/75njRrk+KAYuBkmQ7a0R72j1af3+ixPJcC1Cbom mZ6A== X-Gm-Message-State: AC+VfDzK6oMEXiWKNT5O9Y0zDWIg4U8DZAOelS+1qQlF6LL5xfCQiXvp vTZo5IHl0KYPcuJ/hE6scTvO/gG+/hS8RDhAminrcET4 X-Google-Smtp-Source: ACHHUZ5eEObS8DNS/slKO7ew/ItlAI5E6KAwufB99VobmtOIp86s3l21eXdt8ak32smmyaHDYChrTA== X-Received: by 2002:a17:907:3e9c:b0:973:9196:5be8 with SMTP id hs28-20020a1709073e9c00b0097391965be8mr2352750ejc.45.1685037195635; Thu, 25 May 2023 10:53:15 -0700 (PDT) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com. [209.85.208.41]) by smtp.gmail.com with ESMTPSA id n10-20020a1709065e0a00b0096f7e7d1566sm1107346eju.224.2023.05.25.10.53.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 10:53:15 -0700 (PDT) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-51426347bd2so3906281a12.2 for ; Thu, 25 May 2023 10:53:15 -0700 (PDT) X-Received: by 2002:a17:907:9493:b0:965:fa80:bf1 with SMTP id dm19-20020a170907949300b00965fa800bf1mr2195225ejc.32.1685037174582; Thu, 25 May 2023 10:52:54 -0700 (PDT) MIME-Version: 1.0 References: <20230524213620.3509138-1-mcgrof@kernel.org> <20230524213620.3509138-3-mcgrof@kernel.org> <8fc5b26b-d2f6-0c8f-34a1-af085dbef155@suse.com> In-Reply-To: From: Linus Torvalds Date: Thu, 25 May 2023 10:52:37 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] module: add support to avoid duplicates early on load To: Petr Pavlu Cc: Luis Chamberlain , gregkh@linuxfoundation.org, rafael@kernel.org, song@kernel.org, lucas.de.marchi@gmail.com, lucas.demarchi@intel.com, christophe.leroy@csgroup.eu, peterz@infradead.org, rppt@kernel.org, dave@stgolabs.net, willy@infradead.org, vbabka@suse.cz, mhocko@suse.com, dave.hansen@linux.intel.com, colin.i.king@gmail.com, jim.cromie@gmail.com, catalin.marinas@arm.com, jbaron@akamai.com, rick.p.edgecombe@intel.com, yujie.liu@intel.com, david@redhat.com, tglx@linutronix.de, hch@lst.de, patches@lists.linux.dev, linux-modules@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, pmladek@suse.com, prarit@redhat.com, lennart@poettering.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7A547180011 X-Stat-Signature: kqe38fjyeicp5scng3sfczqbfucfijmc X-HE-Tag: 1685037197-97616 X-HE-Meta: U2FsdGVkX195aSRT0nolR02OytgR943QTCfczVwenX9EEta3foK3k6YdU2C5rMK+j+FJNPz6lBzGPAQR8R/NAtARLSEXTfCdc87ogOvPXiigIuitIQ0iwdVblkkbUqKV/mM/U4JhJaTycQNKf00dL+YGugRPpEpxFwIcLLNmL2TIhDz32Idybh00hlmoQ6RCXDXhHIVIdGQNakxpVLsR1w/32gnP6ptdrbl1YVxEfs/PSVfL+Po4eff3E5SSuLpWNFbvJbCTqCvlHSiuiCD3o/hQvSFqN2D9RoiYkKdQ9txCj3jxuqmkYPqmIVAYX7Hev9jIDsOnYQBaPyD7RYEM5Lo4NYPVNDqsaDr6Vm/v+8Oo/41J9o8B3FogVtg8umXY4NgahdqdI0QhrxNYRWoVPPDi3cjVgXcfb/kACHvAk3aI4YDAPzmc1/23EXMr1J+JMHIbeA/27HA1moyKh9RRthjWfdUUuHQR0u7S+unMJjVsWc0S9M6XJMaNpAeWthteRuB8U7FP7v0DpkHvAGFaLf0nrVVKJdg38RWmiuz1Pnkiuplo2Gvsx1h8RPQbrO7lvUDn9kX6jy6AEvyMnZyZXvDaYW4E1ZaUF7y/HBtXZTqtvChJQ5XqVqTFtJSxlJcb2WzfOQhRyBsLwEUYS2Yqgm1/u0YlfXTOME+TSM51/TyBC8tAbxVJBQ1kYQ9XG5lGh46rkWB/PSRxHDkNLfztrFci8hU8fhKRRC1/EbMu0Nr5IJ058+AUOPLpwpNZcXDygmec6DvgTg3SrMd6sxxUhK/FefwYVcisQuRX8b5swrrxbaJ1XAtL68WKWs429jvtdxg7k3rVgTglN0oarmrGGxkxhvq7F4MQio8mY8JgXvNzb1DADjDgJm5UaXv9WkwhbN/eGVlEoORlnLN4thciom5ao2TAiiNY6mX2Zzf+az5upJmpK1wruT1K6Q0hu5ZKF5cJivzTYzWJW2UT834 vPZojVRh UU+C4N8MRxV3Jrtb8vyCr8T4hQkKl/zESTZiuLZohfABKZlexk42IrujKksyxafAzQbe8XR8coQs4jP92Siu0hYBgGXBTiy4HtH0tb5NL7V5bCXmkp18QZVDzLZ5/IVvzbms8fLAK5Rsnc2zUA8Jx3Is5A4ediuDc15RrkhRfsJ3C4VChhdknYaEpQZY0pBeNUGEaDVaQAhGl71qgQ30XuuF2JF3/g0HaURRbZ6gnMF7SMqD1rdDLFYXL8BgFmZE09jP/9GRtmkW8mhhrDrfTyltyVR1Q989ZPzO13nK+XcF792DniQo5QbWHWq6XbmDocHrgRbpJHG+NPXuhCI2veXnK6o1N1WZusdBhRB0cFKa3T0XOIMbBTKKKbqCUz4amS5PBPJ/wdWsDFzK0/Izh6ENLgz085ojN2Jv+2MM/OWJYaT/Hjvi2Op5/OeVL9PA0XdXkmAjYyaj+jQAfbmulH4JAq17+skFaggiMlD4ez6Arr3wCV45FAEuVtSWImwGn30t55lx8/lmkPLtiydncx3sFdGAspnighAD2NcaWCSo8g4X5L5TIQD5TeiAmYXB9jxA99j8dmbT7ffi+tjc1rtJCW4pu3cr60Kk57W5GpoNxerjG8FPex0qtxffLdleGQBNw+SMoNPCcRPPwAQOeUe9hJ4zF31rq+iV/RLvTWkBn3+heHujv8QZjBgsIt5DSi1vDR9KpUN7RCqnz0vtvboMnAOYnbja5Esr1Ym6XPHmBwic= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 25, 2023 at 9:07=E2=80=AFAM Linus Torvalds wrote: > > That said, I posted an alternate patch that I think _is_ valid as that > quick hack. I don't love it, but it sure is simpler (and avoids the > i_ino bug): > > https://lore.kernel.org/lkml/CAHk-=3DwgKu=3DtJf1bm_dtme4Hde4zTB=3D_7E= dgR8avsDRK4_jD+uA@mail.gmail.com/ > > that patch hasn't seen any testing, and for all I know it won't even > boot because of some thinko, but I think it would be acceptable as a > workaround if it does work. Well, it boots here, so it must be perfect. That said, I didn't add any debugging code, and I didn't test it on any odd setups, and I've never had any problems before. So I don't actually know if the patch *does* anything. But it did boot.. Linus