linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org,  mm-commits@vger.kernel.org,
	linux-kernel@vger.kernel.org,  Huang Ying <ying.huang@intel.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] MM updates for 6.12-rc1
Date: Sun, 22 Sep 2024 09:34:42 -0700	[thread overview]
Message-ID: <CAHk-=wjUiO3qUVR6ydhGjby3yf_KQO5+m7Hfb4H09kXXPogZ7g@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdW-4_WvazciLPedP6R6XnEnHqsEh+3s7M5159zcmHit9w@mail.gmail.com>

On Sun, 22 Sept 2024 at 02:32, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
>     kernel/resource.c: In function ‘gfr_start’:
>     ./include/linux/minmax.h:93:30: error: conversion from ‘long long
> unsigned int’ to ‘resource_size_t’ {aka ‘unsigned int’} changes value
> from ‘18446744073709551615’ to ‘4294967295’ [-Werror=overflow]
>
> Due to
>
>     #define PHYSMEM_END  (-1ULL)
>
> not being correct on 32-bit without LPAE.

Hmm. Can you check if making it be

      #define PHYSMEM_END  ((phys_addr_t)-1)

fixes things for you?

That said, it would probably be even better if we got rid of these
games entirely, and m68k just defined MAX_PHYSMEM_BITS instead. Maybe
as a config option, since I assume it's going to be either 24 or 32
depending on CPU (or are there other choices? I used to know the old
m68k, but...)

                Linus


  reply	other threads:[~2024-09-22 16:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20  9:33 Andrew Morton
2024-09-21 15:49 ` pr-tracker-bot
2024-09-22  9:32 ` Geert Uytterhoeven
2024-09-22 16:34   ` Linus Torvalds [this message]
2024-09-23  8:09     ` Geert Uytterhoeven
2024-09-23 16:13       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wjUiO3qUVR6ydhGjby3yf_KQO5+m7Hfb4H09kXXPogZ7g@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox