From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D110DD3ABF4 for ; Mon, 11 Nov 2024 21:55:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C9846B00CC; Mon, 11 Nov 2024 16:55:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 049376B00CE; Mon, 11 Nov 2024 16:55:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90466B00D0; Mon, 11 Nov 2024 16:55:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B175E6B00CC for ; Mon, 11 Nov 2024 16:55:55 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1E504121B78 for ; Mon, 11 Nov 2024 21:55:55 +0000 (UTC) X-FDA: 82775170170.03.937D9BE Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf26.hostedemail.com (Postfix) with ESMTP id F3F49140019 for ; Mon, 11 Nov 2024 21:55:21 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bSIgWIKV; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731362011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1yUAbMKFGFD+r6n6bBm/WiyB3YmOPXFQ3bg8vJC1p2Q=; b=KnvAAYaPp5v6I+YXA72pgD/kFVpIeflM4/Y9S/RgIL+/hOO7to81B7NqBYomwKO+ZC5H+v k2Ob3SibpACMEWejBc0yCnv76j/BPB5oDxZiPC60FkB3ImHsnCYhXUR6TroXGbDKmuNED6 gxyGikv9mFvL9j08A4Tf14Vih+Uhtdo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731362011; a=rsa-sha256; cv=none; b=lCOcQahtpcO90+OxSC2bYQ/8o+AUxxhNfz0O16DSiKiwvvuIwFbP0g0f7YunzdzZyB5LRE G9ZbTPBnbyEVmjFEdHD/ALhqx1dL1I85Xrq6qlTQ1PFhK0hxDVKaoAd1fPX/EsCuGeyAML FGImwyl8NgEXY+9iikkx6/oZItP6EpU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=bSIgWIKV; spf=pass (imf26.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a9a628b68a7so899019766b.2 for ; Mon, 11 Nov 2024 13:55:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1731362151; x=1731966951; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1yUAbMKFGFD+r6n6bBm/WiyB3YmOPXFQ3bg8vJC1p2Q=; b=bSIgWIKVHcdgAzfcdMhm0utfXwVzaphq/yPtMEpVOfX/ztiDPf8oce1pxLezWAqVWo RhzkfJqjy8tvmXS5e2n2Sy65VEsi8Iet9Lg80Sr8hWj8NaFBawSC7RM7ritBcGCtusfv 2TnQMZrLXyt4ULfWQYG+9OlyhJLeTykhMLC4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731362151; x=1731966951; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1yUAbMKFGFD+r6n6bBm/WiyB3YmOPXFQ3bg8vJC1p2Q=; b=lxjb8cQ2qwbxDrCOUIlqgcTDk8rOE/MV2NU1suD9RbQ419l/L+7vzP3kMKTBvpMA6o iKijPjAZ5couGv6FaHstDOSlT9jok4WVkNKSg/LMR8zlpnCweJwctgLeFdyt7eYS6VeG NBNOqJ2YgC/jaDcvF/55r/3GvDsetoRM9dhK7zVn83Qf7wnyxPwNgdS+wWt5Fa9/24q6 qOWwS9l0VBy4JrcGeERw/8bWQ7lvI64xxrcQZP9PhyY+sbC4AWncxBFJuljSj17XUr7r pw9LS64STFhFJWsY+deojQPWo0tv4RbAOA7sf5jKQ0L7MbKssNur5iqMzHy5KzWc0Mjb k9Hg== X-Forwarded-Encrypted: i=1; AJvYcCX+IdkYEIk/UWIqktUJ09i+lwiRxcXynY75oiRtX5WEe2gBfSIadB4hG25CZPo2HoQF3Ug4/DP9RQ==@kvack.org X-Gm-Message-State: AOJu0YylthFPRAV9TlpXqebdU+mfIFXOS1gmD3U/E+D1mghHdIcQWgun oNbkWBwHBD1T/E++XxFeypbccXBanCpn6fEeJSZnfV0OG84ujyWGwCu3t+dpZNqTFyybhPZOAr9 GvRU= X-Google-Smtp-Source: AGHT+IG7gu0gRg5AtSFdDOLAqxhrUOYU1Jr+1k4ZxhjDD8Gj1JDaSy+9/rq2ll1TiatNjSub3wDJlg== X-Received: by 2002:a17:907:9344:b0:a9e:c263:29a7 with SMTP id a640c23a62f3a-a9eefeecd74mr1228672066b.23.1731362151110; Mon, 11 Nov 2024 13:55:51 -0800 (PST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com. [209.85.208.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9ee0dc5112sm637700066b.112.2024.11.11.13.55.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Nov 2024 13:55:50 -0800 (PST) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5c9693dc739so7296956a12.3 for ; Mon, 11 Nov 2024 13:55:49 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVU129Lz+rYtSIuIkswlMh7wVKIYocjbYSslrcCHuqNVuYIuIaeZSb8JHsBeXaGHL/SSceI3YMBlA==@kvack.org X-Received: by 2002:a17:907:eac:b0:a99:379b:6b2c with SMTP id a640c23a62f3a-a9eeffeee33mr1449197766b.42.1731362149380; Mon, 11 Nov 2024 13:55:49 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Mon, 11 Nov 2024 13:55:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 00/17] fanotify: add pre-content hooks To: Josef Bacik Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F3F49140019 X-Stat-Signature: 1r6wtibbaxszwp718m9qfdjipxff8z99 X-HE-Tag: 1731362121-95008 X-HE-Meta: U2FsdGVkX18TyXYyLSKXXkfOuinfQH6L53NOAfoMNdxHVl0kwn3YGfw6SSQSFQ2KSkUIZ36tCdk7LWQYd3PdIo4rxN5Fc+eN8wpxiIENcsMBCmb7MoPEz0PGPd9a657xqbT5alw42/XDoQqp386R5dt7bopunvuRRX+b726akth84ZRMUDfkjK5RBPqOrTMDPfHZg0L8Ayf7X7nAbLrI06YIdL6bbxtofEMyUk/TlL4fITUTwC86aKp1nunBEpkdUY8GbHX86GA3mwTccht47RsnHdoooy8ZugAqwcn8MleXZEiOiv3yMIvF5BamfiejzE4z9AeTO/oAK5McyEpudu1uMxmViarECshbjakyjmRHzk6lgbhZA6XvNoOp8TFZOZA5dz0Siq+eZxnzgKw3qXZ5DjJ5CPjFFACgXglUm8YHe6ZEJ8i37/Uloj0h1gjCNoTWFY/LHoPeRLPgujMW3pB28rZwFRwEQuXGv96Bo370efZPm5o+7pIfgkdUMNSaV9LFcSGQlQrbn51kJzC6qrHCBUxbdIYl1KsBf28c5ep0JB76/t8B6QPnBftblrxPzpeRuTmIgCGSbK6NVSIdyBS7OMBXVab/PLUP5uU1aukfoT2tQYFzEr/04RKxgY3yJ2fTDBEOPXO09xMbFogSO9HFWg6he/XEhlo4uNeTkryzCoFyeaq+CwwOdisl0RZXwWuvOdy+txGw/LVK0pKP2jkBBIEQRJuKgTCO24m6p2Ce37Fnr+eZzaZNgEwfZbuhamFFhkLkf/+kisKUXPKCiGh49vAqeLwwQOqG0c5J852RC/xZHevy8H8xs86GoFJyfJrOs1vg5B2vuu7skVu5QzCxzRpfJAINnlNVQvyzgHJXFY4IGHkuVjNc13aiGva925det5+EigBJZ3Z6c3ojZyl2FrNbacYNWVeahbhTb4n11pRcDrakGJUs+DG48T439LO2c4ChShnZw2sI2Qt 2FpBhzIX D+p9I7I4nw5pSbxra9Cq2Ssdmuw1l2QKXwCleywwl1elZs21uKGUbRHJfOPkmHhJJDxdrVmwMpr9OK2g7nL39ECOSCQzInH3dBFJa+B2OYu4ZpE+lVH2R3fEY1u3rgJ5nLAl44LqyX47B88nAaB58oa8xDTXIr6snBUF8ySJdL9i5eOmW18sIkHn+0ZEpz3DFKbUTJbSJ3yJa2XNfmdwRJB0+pm1N/ULnbz++ZOTR0DPrfis91DkrvALwDv/CNlVKX4JuVvTMrzRbeEJ+ZUeJp1J/FCT4Ze6CJtM8erfvl2wLM5FDnvGO3m7p7RWateYlA3xnJNdTSl9YmMEJcf2UIr/Say95eKMCBIXWIc9I28QA/oV0w/hT1PyV/YIIQeAybPyjbq9lWN1xJERe04x3AKDh+XT6x4xDCZ9J3WVpetF14LSjeOHKzulZYKy7G0PgvcP2wXUKh4cMJBG2INnknCaepqxo0wej2VzekOYK3Zu4cbbI6win34+P6TtErZCSdbiOuQnpJ8NC9G3AipEJEIPbf7tyPB+dF5VsaDM4JEdG5IagIhfk2cLT4O2EcV7J2g4yA493m+1xxdB3UZPbnbkRtStgqi209iAPmtSK5Kge5eZc9+uS29cCLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.005216, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 11 Nov 2024 at 12:19, Josef Bacik wrote: > > - Linus had problems with this and rejected Jan's PR > (https://lore.kernel.org/linux-fsdevel/20240923110348.tbwihs42dxxltabc@quack3/), > so I'm respinning this series to address his concerns. Hopefully this is more > acceptable. I'm still rejecting this. I spent some time trying to avoid overhead in the really basic permission code the last couple of weeks, and I look at this and go "this is adding more overhead". It all seems to be completely broken too. Doing some permission check at open() time *aftert* the O_TRUNC has already truncated the file? No. That's just beyond stupid. That's just terminally broken sh*t. And that's just the stuff I noticed until I got so fed up that I stopped reading the patches. Linus