From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C5CC77B7C for ; Wed, 26 Apr 2023 19:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9B556B0125; Wed, 26 Apr 2023 15:38:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4BA66B0126; Wed, 26 Apr 2023 15:38:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 946526B0127; Wed, 26 Apr 2023 15:38:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 87D046B0125 for ; Wed, 26 Apr 2023 15:38:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 373BAAC8FB for ; Wed, 26 Apr 2023 19:38:48 +0000 (UTC) X-FDA: 80724554736.14.07EABB4 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by imf08.hostedemail.com (Postfix) with ESMTP id 36F1A16000F for ; Wed, 26 Apr 2023 19:38:45 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QtE4gSNN; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682537926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iFQA6ltmpMBru5G5YdgB88Q73RhVYiSbzEcgxUrcch8=; b=dJD1mZ6vaTdYeRYn8DjnioPjOSbLraneW4/oJ74KxoxOsf9+LmwCeJrxqpz4U8zvTvbQLd 7PRdpB4WwWXZIL5d7flnX1EAcvxY4ZFpKW51tnFDNUXbcvZgZTZPC6qyIH3CL2lwkx1nxg svFI15UqIWQJTMNlyRt+NPwfdNW2vmA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QtE4gSNN; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.218.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682537926; a=rsa-sha256; cv=none; b=Iy65VT5N9chUeI7Z6L/rlO4benSUHY0UkxEk028jI3DralaZVow8FF7QwC82eO7KKtCeRd pbnrt0TmdPj9OjSaPHgzNcZGowlnKIrSBgHjLLF3X7P5rwK97wLGvHIt3ls7wqGl5oB9lX 8PN5gNqDyYV+IpCFqTicxk8INU+PDwI= Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-956ff2399b1so1343710266b.3 for ; Wed, 26 Apr 2023 12:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1682537924; x=1685129924; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iFQA6ltmpMBru5G5YdgB88Q73RhVYiSbzEcgxUrcch8=; b=QtE4gSNNNQLpLlzwx06VI5DTc8V9Q0T2Mpqo80NBTCCHRL0woPdOIK58lVnSND4QXW bzOqJ0/NXzL4O9mrEE4a8dCORYdVJVlI/fIaEpVyKT0+/3iSRa7cRXqDgSGEVuoiypyL oJyd4pX+EyzYekYxwbeHuDQeubnLFSoNz5MtY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682537924; x=1685129924; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iFQA6ltmpMBru5G5YdgB88Q73RhVYiSbzEcgxUrcch8=; b=LAv32o4qwwbqm+tYbrVzH6VxV6X+j3t4Mkeq04NjPDgNrw0Otnuw75tDB1X1bRfnhe 34IC1YZDqBJ1s2lLVcCj76FKVoNvaYAGd1opNsQPL9etlcWcaBtIfyprwu1lCTQCDNTC g47JfP5fQ4H8W4Ftw9xZox/zNyejtOUBBKAqQCpY2Eed2sVQh8t9wiB/SHoSqPD6OHYI kVKoVz8/fAUkcYC7bzyq/LndBfFg5Z2nlFDxYalyToC7N0t/sQ/Mb+I1OfEp9kmt5YG0 9QIbNWNe7YYaju3i46DAmCZG7HEq0cwIbqKvPBqDqyUQSWF2NjhT4vlyLJ71sue8IW7O ySqg== X-Gm-Message-State: AAQBX9ciJf/NUrmwSrXuRKli6ZBygGdgU4yOI4WoeamSEZN7W8RyuJ9Q E2g69k65kqfTF2PWt44rJP/GKJjlCz790PZ9ObV3/A== X-Google-Smtp-Source: AKy350Z30ZLkQGTeK0LfLKWzMbgqrA2WvMbiiwe10Se+LQxJqBcibNym7A6Bbh+3wtnyNCZVyqYoKw== X-Received: by 2002:a17:907:c082:b0:94f:4801:6d08 with SMTP id st2-20020a170907c08200b0094f48016d08mr16507614ejc.71.1682537924300; Wed, 26 Apr 2023 12:38:44 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id s2-20020a1709064d8200b0094a86ccb634sm8578542eju.210.2023.04.26.12.38.43 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Apr 2023 12:38:43 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-95678d891d6so1367594566b.1 for ; Wed, 26 Apr 2023 12:38:43 -0700 (PDT) X-Received: by 2002:a17:906:c416:b0:953:37eb:7727 with SMTP id u22-20020a170906c41600b0095337eb7727mr17746802ejz.43.1682537923395; Wed, 26 Apr 2023 12:38:43 -0700 (PDT) MIME-Version: 1.0 References: <20230425041838.GA150312@mit.edu> In-Reply-To: From: Linus Torvalds Date: Wed, 26 Apr 2023 12:38:26 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] ext4 changes for the 6.4 merge window To: Matthew Wilcox Cc: "Theodore Ts'o" , Nathan Chancellor , Nick Desaulniers , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dan Carpenter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 36F1A16000F X-Rspam-User: X-Stat-Signature: u96hpdizqotko5mqxwyp3xtc4bw4cks5 X-HE-Tag: 1682537925-203295 X-HE-Meta: U2FsdGVkX1+p4vbX1Jrxt8VmTW2e+REvMRYRZszAlsxF5WCKbrFZ2LKcLdud8CFODlXRWgJUfWpcKCjcdF6g0ujo21ZKvSxGdeC0PDz1km56EtgDAa54c4S4XoGkh2wPY0zMsRL06OzkLODrPEWDY8MMJ7ZVKVFVkWiyiVKaQD0Zq0P1oORd3G7aOY7NBhGTVFewfJ5+5sHKCWffXdbijLZ//nDosmUq0y+vZ1m8dQTUt+3gqu9Hkn8WfX4w08nPmDTJWP/Ff9BnnSBRkZ9xxujWpwtPveQ3/fDak7jUH7Am6zlO2SbVQllxGip6zmF3CPQ6oXSLPY02wCtlKf9hIBvK3KLdoS8YS0eRM8mB+EotX0ssfhbfwcgG1nLHhdsP7lKIaK2+fFuUh/n2FWDmC8GXGsqRb2By3aPSMMPNPs1gdEFXGrQHCtqWSKwdTmIW9YIZTUDDQl4Syd/ERZXwMhAxJtlgyQ3Jy4+r6wOTP60LbLdV4IJvZGwkjPNvU07/11H3mrCn/DKvckepni4IO8cvrGIA1x2OOG88F3iaMMLcC4sfZtzqiHPKDFkm3DNWj0XSGwXCJYHVpGE7/u2e9WD9rTZnVMX3W1oXEzPHhnMYG5uIU2bdahFM0xcc64bkWahm2Nxf5MFg8FgO+c5xHZPO0FgpSZ8XssauNihDYc2IfZmgM4opBgJkuUOzEnkspNSvpFaAI1F6xKRROwCo2SrzcfCE1wEOnCnNP4h9wPchXCXitbbGltux+TODUIjZV//qi35h+LI06MMLDR95EkotSd1++XJCoRFonFw3akVgoS/ri2NbANcLelpSezD6OzGDWTOoNQ7wMisRlwOBBHVzR2pUQAO4W3lmNDSPZ4GRRISfpvDMTNHrq7e21N3vrERxMzbD02l8Cq8KK2uhUQbeUWTuDqGJosY0SA+A9+aAbQ672Ue/6SxAiQd5ySHOssgMWrwdE9DXxm8yOk9 2IKnf9+Z 9mQpEOK3UVZtWPleMzo+9cZldOfjsUx1S/jfOkxIh2Lkp5X9n1Zgy5OjTXx3bl1QbZ/6XIKvU7I5jYpYte0gnonMDEMnqVuzlf3gcS0JIW/Oq45Gap/5I/boZUfpeOjQq2TLctmIcCbna6Qzm28u8QcmNP5Ojw6T66PO0FwOY2W7+nhNFMtOAvjfVXl6AuMMUZj2U14DI9X51u2cl1HyhartomedAlArmaONMed9R1zecYEU9IwEA0kKc0EHLd73wBzC3omxQU3usz1G11Z428A+Dilz5YUkfoe/g7dboZzBZdmD4HcUqm2PwIufTP/hmSRYlxNKEqHcwqXwMD2to2wLaUTMd60nl04goKN3du4dyc9wWWX9hSD565zFyOp9ZdWEJXSLJ2o6IVcfczdyz17j8hGZYUnu9NsTcvwXHe1HP9VowLfqIeqoTxf9f4Iv6qIWZEHG9MetLgwqNobQo5RVHxgrTXr8AhwBxj+IFRDLQEPOunM5JtsaJ8SuOSPMeqLCjTJCnJtiG+fPpOZFX3FdnVmDQmMc4u23uNZtPC98E9gvKrCqWLORvb3EfFLG484gAuqbsc92+a1E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 26, 2023 at 12:11=E2=80=AFPM Matthew Wilcox wrote: > > Unfortunately, I don't know that we have any buildbots that run smatch, > and most developers don't, so it'll always be an after-the-fact patch Yeah. The advantage of compiler warnings really is that they get caught quicker and developers will react to them much better. They might cause the code to be properly re-organized or rewritten to be much nicer, for example. The "trivial tree" kind of fixups for random other issues that get noticed separately tend to be much more about "work around issue". It might be the proper fix, of course, but it didn't end up being taken into account when writing the code, so it often ends up being just a "papering over the warning" kind of fix. Particularly since the person trying to fix the problem generally isn't the main developer of that code. Linus