From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7E9C3DA49 for ; Sun, 28 Jul 2024 21:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038BC6B007B; Sun, 28 Jul 2024 17:01:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2AF46B0083; Sun, 28 Jul 2024 17:01:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E198F6B0085; Sun, 28 Jul 2024 17:01:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C6F696B007B for ; Sun, 28 Jul 2024 17:01:37 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 453471C09CD for ; Sun, 28 Jul 2024 21:01:37 +0000 (UTC) X-FDA: 82390382634.04.CC1F463 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf05.hostedemail.com (Postfix) with ESMTP id 2254C100003 for ; Sun, 28 Jul 2024 21:01:33 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Z3f4bVk3; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722200453; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hYdIiiGBVvGk8kUk5DIY8kS1X5q82rzPw5nWwBId3k8=; b=WhbL02Zzl0swh3p5sr1nyGn40Dyf0rLZDNzNb2oxKxv0M/JNXFbbgk7NZ4RHp8pl11G0Ow xFv0LkCGhYXeWiTJfecCUJd8Sehy/qdpB+aEoDTr5yAUnVfyiWnsCAoGO5++5SAokXAHCK LLDDA1cRMAg7OznmvkSu5z+0GmR3d/w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Z3f4bVk3; spf=pass (imf05.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.54 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722200453; a=rsa-sha256; cv=none; b=1bIj/0qE7gY1UCdnXYGmOR6a+we6Cc9ULTJk6+mvMOZ3uqoz2uZT0Au5UFHGi8HFpJqxUb ZN3X9lmAcLVcb+FeRVtuExuxupYFlGw5wS1MgoyzEAQV7vH++xaowPFzSOw67y6/gdIRDU lf2WxKBNgBqJKQ4g+xmf6MMDn17whYs= Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-52efc89dbedso3315563e87.3 for ; Sun, 28 Jul 2024 14:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722200492; x=1722805292; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hYdIiiGBVvGk8kUk5DIY8kS1X5q82rzPw5nWwBId3k8=; b=Z3f4bVk31wLOWuUdKGyDyZ6uEdx/YVYkcRA3+AnMKvKQNhU1TEN+O7bWvxabEvHh6/ W/ize6dJmJ7TzTq1w/vHuLC7dNwXBq2SxTCI8XtyVaDNfDZj8jB7TllBf72ccwuzbzAK EQzZLCop7DU2A1gw6EHK7VCJoxX8ps35VOAAc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722200492; x=1722805292; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hYdIiiGBVvGk8kUk5DIY8kS1X5q82rzPw5nWwBId3k8=; b=P1yNu2s926ui4762sncky5T4Gin2jV6bo41DHO0LkOdFq6m00ANZGsU/8WuQFkgiIp 9NW0kUZ2Z5qrVuHAfyiB5pARBmTB86eounFZQQxgtWB63RR+gy1z0nuGrlzXJeGCTGAh pjcUVOHeIPYOCVsQfv0i+CGRWnnlobklrNKbTW0yarv+SvdsjZKQYWWTIy6z0dGRmtMO N8aYwWQ69rdjXz89Tsd39hYblXWCx7foeF1ROPiPJjkqIhLEvQVaeEZ2CHy+BwpM9VXh yb8t3PCEtqNDtNcIUkbI7y6xaFXfg8tPKBg9V3Av8/jzeq2b6N9xaqjfCGhk9VocixBC C/NA== X-Forwarded-Encrypted: i=1; AJvYcCVXWfCdHHDyvpK5kYCkO1ndx0l6V2gGkOefxYbUoKKzIfd6ap/fXq9Sd1z6MKeEucw7ikkimtC87XZBEB/a6F2mDQ0= X-Gm-Message-State: AOJu0Yw+bICxDltIhnxrNmQ7u4sJjx/7m2+FQh2mU7mUbCO4ogBB5sBr Kd0ZTdkjFNvqVucdgsytLWpLri8um+wADXVhbRfADqdBvw9cFKp+bKzv2POxUo/lzL4fL0FrEuq cXP21iQ== X-Google-Smtp-Source: AGHT+IFSDwePwq2qRfPrJXN2H+zlWQMCb69LO5EJqPRQep7igMxoMdog1iYfG+5Tssefed5NQvQAYg== X-Received: by 2002:ac2:51c5:0:b0:52e:9cb1:d254 with SMTP id 2adb3069b0e04-5309b2ca2e3mr4076123e87.46.1722200492170; Sun, 28 Jul 2024 14:01:32 -0700 (PDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52fd5c3925esm1212363e87.295.2024.07.28.14.01.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jul 2024 14:01:30 -0700 (PDT) Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2ef2cce8c08so33404481fa.0 for ; Sun, 28 Jul 2024 14:01:30 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXJ3c8AMM95K+9+nO3OUY2Wf4ONm7PBJJju6Xqh0/mziLP811Ij3EJAHjbc8+tDVW1VchCecyxsV7ilKqRt2UXaTnY= X-Received: by 2002:a2e:3013:0:b0:2ef:2c20:e061 with SMTP id 38308e7fff4ca-2f12ee1933amr34604311fa.22.1722200490156; Sun, 28 Jul 2024 14:01:30 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Sun, 28 Jul 2024 14:01:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: "linux-kernel@vger.kernel.org" , Jens Axboe , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: nag9gxmg9ztnd9aog31gnp89p1s3kj5d X-Rspam-User: X-Rspamd-Queue-Id: 2254C100003 X-Rspamd-Server: rspam02 X-HE-Tag: 1722200493-623820 X-HE-Meta: U2FsdGVkX19osfNERtyAmrKNZNP9ZXFFXgPxn1DIj8OZh/uB15Pmvl60xQy074YP0OAzb33QUtUaNHI7Lk6c9OCdPEbRvC5dg+RmA97/mQKnWBeDwDxsp2IFEBkErr0faN5ewUmO5tyIGthJ6haLqaM97GkreO+Ew+tqshBRTlnOZZ0pzhhSoVjqAaXD8w8SYz5xw7OXgk2E2RqOmANMMVBeFknK1NP9zYdWTMdpE+syVbwEeDeaiuXB22g5jCrVZsOjJkrLWfJ7YcSRrb3R6Uiw1qWej1weYdinGdZJn+7zK17bLpDeKJfOc8v7o7nFDB9+thtzP26jUtGrKnRkc1n1y+38okTXkNjkBOUzvppD0gRJKP0y5X5h680sjurb8QBLzimsolfdx/YVJkvCfZjHUNobHQ7Vo/cBByqooBPMG06cptjm++CbZSjTpOOyFeDFgtH/TWtLm+6cvUpn8O/6W12RQ6r+bIh7Stt07ppiMuC33VxdL92+/7D1/BdpA9Xqg93/GLSYkXFgeLeGOAm2YodPBs93A/wEWWtUViuA7DkVINcxbGzf5fti0BI7Wpz6mkoi1tQl6z7Fg/Qg1cFuAQN5GoxQIh9S/5vwJ661cyR7ynohwiwLAzzzqrzwt4QZVPsVBeO3n92HlW9HtZRcgPxQQISIRuJA80Dik5ZwEQI2QwQN9Kxfw1V+6vh4jzgKA8GHHTSAxoMC86pj9g5jiU4+SoyVyQ0lO13BrQ1kovnEAovDBZrjuklM5uOfKIfrG+p2s7HN5un+vnlulkUNI2ezRtJXSfUoCHoYfmlRqlqT1tqPQBCYKMEgdnY6rWab0k90eG/7f+8sjoCnGhXqdSxxnZ5bcvW+INWfGDexgmzeynyYvELDWgiyk2tqPcY5i9ISBy6I5LxZwdvNOE939F9s47ybe0rtn5+Vpe174xXurhql+AXVGJ7XDLrUvJvhQhCXU3AalOr8kjV 9QAooXcY VIsSMb7sO7RzWxmNAIyctOq+PmL8Wj2DDuQhmfbw9ox8Lq54CEwNNOTbxOgDsVb11++k/er0YstvE4SZTv8EEUD8ggJ9hRVwKWYdK1UWaipb0SkEr31vDxbC8uH8vcKtyNkAZpbjW/r87fzhrR4xE/9L/8TOHvArjL1Gn5vEAVXko02S6rCHMbaYrVxm27Fwh+RO4ZF5sAy0x5UB/WwMl5caWCCamwhNwPUKYEaQtZFXVW8phi2UN6WQuWR/lIP3a39II7Ky491jeDAiRQidH9ZSFQuwjhpwi30GTfyFLntqpEFw2b1lyv9vthEsrQrCp3kZN/AvDRrp8Hmqdo7+Nkq5ZvZNoKi0HRurj//hsQEF8KycArVCRFVAFMgTCbgz9ZHggZkZC4xRLSWIH48fP74apaVm/DjW6wJ4z0tKOO8JOfrftWQQ53aY6yrHc2tGxm3e3U392i4S5bLNqwvXM551Mn5KLO4Ogsk6/S1qSoos3d5o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 28 Jul 2024 at 13:23, David Laight wrote: > > At least you can 'just do it' :-) I decided to use my powers for good. Or at least goodish. I went through a lot of 'min_t()' and 'max_t()' users, and I think I found them all. There's a possibility that some driver that I can't easily build-test has issues, but I tried to manually check all the architecture ones, and did an allmodconfig build on arm64 and x86-64. And by visual inspection I found a 32-bit x86 PAE case. Which makes me think my visual inspection was not entirely broken. Anyway, I don't love the timing, since I'm going to cut 6.11-rc1 asap, but I also don't want to unnecessarily leave this pending for later, so I just committed the simplifications for min_t/max_t. Doing the same for min/max (no more C constant expression worries!) would be very good, but I think that's going to be for later. Linus