From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C55C04A95 for ; Sat, 22 Oct 2022 17:55:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D5E28E0002; Sat, 22 Oct 2022 13:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 286CF8E0001; Sat, 22 Oct 2022 13:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14FAC8E0002; Sat, 22 Oct 2022 13:55:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0430C8E0001 for ; Sat, 22 Oct 2022 13:55:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CF0BC80A1C for ; Sat, 22 Oct 2022 17:55:37 +0000 (UTC) X-FDA: 80049337914.21.196AF38 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 7B6F980011 for ; Sat, 22 Oct 2022 17:55:37 +0000 (UTC) Received: by mail-qk1-f179.google.com with SMTP id l9so1397707qkk.11 for ; Sat, 22 Oct 2022 10:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PbMp9nRV4Rb1lNBp4ackx21snQ7p1o3AwWoBrCj3z4o=; b=YEvmspKkGkWBhn47N+fWxLUtC3jfzU4GqR7K00ks1EDc2cklpxvqvo0QWLjKAXbKRr z4iR+l75jIZEi+o+Dd0yB0w7OadiYkedJGd245WsA1+U9lWmMVvXf/KgKLcqV1dWYl7d Qcyxzs/vKjVZEuc/FwHAQYErTqXn7/0sE6WsA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PbMp9nRV4Rb1lNBp4ackx21snQ7p1o3AwWoBrCj3z4o=; b=xFqDZHxyMI+PgeVG98+x84HFX2SzNyFiCD3aD8MC8qIfW2jhQhSSJO+OV5Wni8el/M bKQkAHouIlSrxi6GDUL8yhHrqp3EVSzSMZ9pXoIG8u2UC2kfqk2xIiZ9OhHlIX9SR562 wTztHiHbOumbUFVGNgRH5nEEoZZyc1LIhljEngh/v5CkXz5xklUnDvZaf8BHpWYHAutG KNx0wrAfc8JjPyYWkOIbJ5Cs0rP7FDAdB+o7c3qmUuuXRVg1BPptyEK7KahqNnB22ZJM O4M6jDex9GY/nPWKbhMNSkCHd0dqMpwQf7lB4RztIwPyAMryA0bIWU9QJ86JZUDugfzb jYaQ== X-Gm-Message-State: ACrzQf2ksByz9QMyDuTEdGBkhTNFLZNB9PhA3lZy5vmKl3RhI/9DoB8o nhHJVASi0HHaCzBsCE7Ev0PUUlPjZVoAdQ== X-Google-Smtp-Source: AMsMyM673lPN+Cpcb2lNoYs2x1Drc1XMupfuYN/TzC7jVdPFMiRvVInR9W5n7qEdl5j5WA65s9rp1Q== X-Received: by 2002:a05:620a:4310:b0:6ac:f9df:178d with SMTP id u16-20020a05620a431000b006acf9df178dmr17982650qko.773.1666461336581; Sat, 22 Oct 2022 10:55:36 -0700 (PDT) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id br22-20020a05622a1e1600b0039cb5c9dbacsm9797865qtb.22.2022.10.22.10.55.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Oct 2022 10:55:34 -0700 (PDT) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-369426664f9so51456227b3.12 for ; Sat, 22 Oct 2022 10:55:34 -0700 (PDT) X-Received: by 2002:a81:1902:0:b0:36b:2578:f6e2 with SMTP id 2-20020a811902000000b0036b2578f6e2mr3138851ywz.352.1666461334165; Sat, 22 Oct 2022 10:55:34 -0700 (PDT) MIME-Version: 1.0 References: <20221022111403.531902164@infradead.org> <20221022114425.168036718@infradead.org> In-Reply-To: <20221022114425.168036718@infradead.org> From: Linus Torvalds Date: Sat, 22 Oct 2022 10:55:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 11/13] x86_64: Remove pointless set_64bit() usage To: Peter Zijlstra Cc: x86@kernel.org, willy@infradead.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, aarcange@redhat.com, kirill.shutemov@linux.intel.com, jroedel@suse.de, ubizjak@gmail.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666461337; a=rsa-sha256; cv=none; b=FdYkG0z57EohkaehFl8fTb7NNCT9KQcyK+2D50YlS2+nbvO9UtPs0Ue72Fv0JM3kzxQhqD kstJM/qh7JX1Z2EzGJYziK8L51qY0VprEJZIHP6hpbDGYVpLl5XYrhu0yK3/nLtbaz8isw jfHv7KS5QoyruPtDZIY7GfcG5JHiClI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=YEvmspKk; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666461337; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PbMp9nRV4Rb1lNBp4ackx21snQ7p1o3AwWoBrCj3z4o=; b=gwvFWQVSp4kSvFqjqV6509I9vz0frgPwTAuXrIbNk9MDcwSy2x2YXvh4be4DAGWn2U0H10 fzDQcPiPxQuRVMX/ShZx/FvS001Krm7wqj/f5a8Xa9y4K4nRrZQeRB9J0ENmq6zcJBLj+w PbpNFBXrdxKWfLnVdCaY5bTeiLE2og4= Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=YEvmspKk; spf=pass (imf30.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.179 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none X-Stat-Signature: 1qfpnuhscxyxdp9o4xt7y8wxfxnbixk6 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7B6F980011 X-Rspam-User: X-HE-Tag: 1666461337-375862 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 22, 2022 at 4:48 AM Peter Zijlstra wrote: > > The use of set_64bit() in X86_64 only code is pretty pointless, seeing > how it's a direct assignment. Remove all this nonsense. Thanks. That was really confusing code, using set_64bit() in exactly the situation where it was _not_ needed. Linus