From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D21B6C6FA8E for ; Sun, 26 Feb 2023 03:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A2D86B0074; Sat, 25 Feb 2023 22:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 653046B0075; Sat, 25 Feb 2023 22:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51A866B0078; Sat, 25 Feb 2023 22:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 428BE6B0074 for ; Sat, 25 Feb 2023 22:53:26 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 03CB6A9545 for ; Sun, 26 Feb 2023 03:53:25 +0000 (UTC) X-FDA: 80508073212.09.FDCD7F2 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf22.hostedemail.com (Postfix) with ESMTP id E2900C000D for ; Sun, 26 Feb 2023 03:53:23 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QLHt3ynS; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677383604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B3jzL0y6Ler5qUbb1nqA59NxYv4O7GPc8dG7aoiVSCI=; b=zKESWt4bOCQH0l+6Vt98V7907P5E2hmm/ncmzo9f6fv0tHdK1UYs3cEkBtlUeKrvrl5jRj pbMutI4hSnzaJttvKnL1wx5TCpZJnozj78KIggsZuZVozm5QcuPSxmTAqKaZNdYYHK6pMo sBApFVV2T0OzdZUxJZ34cttg0ZpZmEI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=QLHt3ynS; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.41 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677383604; a=rsa-sha256; cv=none; b=NDnXs19DvmVUBe3KL0PJKzA5mFzqzgRWfavpAcm864bwIXMKdKQoB6TFlH3/hbqwjUcNKV 77eD3lt1+o7/UY5pPxhwg0IVKTUbTcFr7s3ab9E0VKNlMC3+hYMCewwQbP15zfjMl4mr3n FiGZ8ufNPxIBDqk0Dl0jGRo8eUqeTEg= Received: by mail-ed1-f41.google.com with SMTP id i34so12771486eda.7 for ; Sat, 25 Feb 2023 19:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B3jzL0y6Ler5qUbb1nqA59NxYv4O7GPc8dG7aoiVSCI=; b=QLHt3ynSiWLdbW+mwY8WM0pFw+QPheMzsqFmcvauKPsFIdlaYmeyyVLbA4lQawcg4d rsoeJffGH7ki5ChbK3/YyLOGD/nrs+Uww7HdhEyNe/2b5z2lJy4TJ8RoemtH7InNWeDZ TpAqTpWyI/4aS4+2CnNU1BZoUUG1asBgcSfAQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B3jzL0y6Ler5qUbb1nqA59NxYv4O7GPc8dG7aoiVSCI=; b=0WfThh5GTrxcdZDtFodlDm3nf1OVkRJyb0yBL9ahWJFbUnIbmbezSlsifvAXUljCN5 xGaX1MbXTbDxNyWbwMrRcE0DNhsWjNhOizw7A+TN7N8FDKBp1M3yem5aICF+f2ERreMn HOldpzqo1KdX+OJ0dvt4eS0lZU+7M0UFgR9HZM/C6lUIIFbwyRVDHi6WoEQpUpwi20hF hssZCLe2A7avmEE4SuyzQJ0EzLEYLsw9LCbSOvgJ9PYHFgkXsA5/e2leNAS2TeFztQVA 4YPFA8Pl5GEfnjV/EbNHpOsJc7LXtElMHynIc1tVfBYDgJLCYImiPP5RI4IcdU/B8iNv T0vA== X-Gm-Message-State: AO0yUKVPivI/QQhQvQEXUNQqN4YUpgXzu89Bkz4QoKUGkuSYr9cJb0Up QYtQyw+ySAQgwXEXninbd3tL2aZd3Y6hDH8FX/GKSw== X-Google-Smtp-Source: AK7set/9ZqCKxwESUSumA6+28gJXX1wmioMj2iTUjEZYhEFVGW7EQb02CjEbcZbpUZRjJV7xv3TxeQ== X-Received: by 2002:a05:6402:1356:b0:4ac:746e:2edf with SMTP id y22-20020a056402135600b004ac746e2edfmr21076381edw.9.1677383601787; Sat, 25 Feb 2023 19:53:21 -0800 (PST) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com. [209.85.208.51]) by smtp.gmail.com with ESMTPSA id s24-20020a50ab18000000b004af6b93f00asm1475985edc.23.2023.02.25.19.53.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Feb 2023 19:53:21 -0800 (PST) Received: by mail-ed1-f51.google.com with SMTP id i34so12771386eda.7 for ; Sat, 25 Feb 2023 19:53:21 -0800 (PST) X-Received: by 2002:a17:906:9f25:b0:8f5:2e0e:6def with SMTP id fy37-20020a1709069f2500b008f52e0e6defmr3062810ejc.0.1677383601014; Sat, 25 Feb 2023 19:53:21 -0800 (PST) MIME-Version: 1.0 References: <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> In-Reply-To: From: Linus Torvalds Date: Sat, 25 Feb 2023 19:53:04 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] MM updates for 6.3-rc1 To: Andrew Morton , "Liam R. Howlett" Cc: linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E2900C000D X-Stat-Signature: i18i5wsq7hj5wo8z4mb1yz6d8ef983zf X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677383603-104714 X-HE-Meta: U2FsdGVkX18d7YDJhsVc5kOerXvYoNsil6CLUWC57Wq2XtBOexhFTmVgqAObEZQQckMcw/GdeUnK5nBiyCW3/6O6kNp7jc0xvapeadFLk7x2zYNmKtmIIs6L794TeuRe+fPn6/4/S6+/bmxTLqwXukTYSX/Bjze/uudm7lx4Anyq7LdbCs095kKErDSJ4z7B6zv+qU/F4mteYFQ3kQDl8PQxZCR0lSEFBVVT34LGdRVMXYWIGjmr0bYnvM1FbamqWs8tEtm75uGi9y/Esyc5ldV/gJp0N4vx9g418yCA3zDux3d6O9F38sM/1TBZqjBapg/cgEGs9aIE/73TnhNN+n/dT6Gv95XWgLI+dWFTlf1rTKkKEs4cLAJN+oQX309YStNrWLmpnCVWegaU/X67VzV2bOqK+L4K5ny3sHxRowYpTfH4mTY1a67HVlaEGfjNGSg3kzjAzlKwNaGWbLRc17kLJaWQRBcRlHKOLz0rn9XoOgxkVdJ+VEuNHQGNysbKfIowHssiV1foQhnjIvrVj4Na8cCwYGtEKHRjUfVKFl6/U5VkKrrhej+yssCF2EqC2UM0J3FhSrJ0IPe0tYc4bzbRU5OwmkNO5qyKtmiHFGu6RIMd5W+qykpiK+cRGm2m+XEKG+aKIQ2V1VoW+kB3UPLyyPoJkGSVqK+LMCIxdpfCwvIP+YLRI9gWraedxpW2fz1bpsltWNrGQWJjwoafvHLBVc8+9hnjQx4qzWUjybH8q00/5btjppAnr5cVr4TYMjma9vMqReY8uLSLEVFcNtD4vvoBiLL6XNRh0KxyZ6LG1yAzB6TrOER+h9jmdPKcSflqxHIWvWsDLbP8tdkSFlvLiTs8aQ+TZA/qr4nSrk0eZLNHbuQDN0bniQyMZJem7/kdEXVGmu7tXbQuQZzHcLa7lDeN94EsHmTjwKGBB5KtpHfwrDsAytZG8lua8JouKZP59+uwR8F/9zjbZWu OFGqfSZx kVoLCEgqCALiOquofvUg0oBNp87BowVkQsynpJY20xEKSzjM96/Q+wEHFnWDLiDvXARkigc1cmmCoerxsTf2jHx4dvkzCx0qNdojuw7tVelUmDuAoobLHaYzMZwLQO8p8iLrTieaMBpJ0EHcmG+urjhhhXXY0EpovwC/5k53Cj49dFlVnNMsteslbdivM4JmbnOOiHwxWa9tsA5Aj+HvnzAhRgh1y6B8lzul+F8mu5S9BM05sUhwQzvan9WNSzpXdNljRtwlDBTNvWxAmaIaLuUyrgbeKwzD0z7nA63Ax9dc6gz76cQi7taVay9Ywz3nQrhNQ7igPk7Y5hY71y4oTXGIx+7KMTWdXZb62Pt8IT8p5eMLTwjLepCayS3vc7eoc/HrwZFnHkw/NevRBFIFu3q7pKpwsxI48zgE6oMNASkcgDr43YqDIU5/nFF5VPi1/HcZlL3+ZUQJa+0F8ra0I/pEq+3ARKd0eYp7b7LkFZR+zaR213RLTXHo/kus8hlAevyrZXPVPe/7uhHX/+gYkH1AOefTWXiuXpCyJ0HdX76E6L39VZSAWujPHS6cEGlipo67UXhKfFpX3CEiO60o9NCuJfNQvAE0pS+xfmRANtUlg2yN83snPtHTQAIzv9Cte3XvLpi1dsluMjSYM7zDFyCrEBQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 25, 2023 at 7:27=E2=80=AFPM Linus Torvalds wrote: > > Will bisect further, but adding Liam to the participants because it's > now narrowed down to his changes. Ok, it's commit 2286a6914c77 ("mm: change mprotect_fixup to vma iterator") It was entirely consistent, and bisected right to that all the way from my current git tip. Without that commit, google-chrome works fine. With that commit, I get "Aww snap" and a traps: ThreadPoolForeg[4337] trap invalid opcode ip:55d5542363ee sp:7fa5e04f1f80 error:0 in chrome[55d5537d3000+a14c000] message in the kernel dumps (and core dump noise in journalctl). The commit before is fine. Sadly, it doesn't revert cleanly on my current top-of-tree (or even _remotely_ cleanly_ because of all the other vma changes), so I can't test just reverting that on the current state. Also, it's not like I can debug google-chrome very much. It presumably does complex vma's and unusual mprotect() stuff to trigger this, when nothing else seems to care. Liam? Linus --- 2286a6914c776ec34cd97e4573b1466d055cb9de is the first bad commit commit 2286a6914c776ec34cd97e4573b1466d055cb9de Author: Liam R. Howlett Date: Fri Jan 20 11:26:18 2023 -0500 mm: change mprotect_fixup to vma iterator Use the vma iterator so that the iterator can be invalidated or updated= to avoid each caller doing so. Link: https://lkml.kernel.org/r/20230120162650.984577-18-Liam.Howlett@o= racle.com Signed-off-by: Liam R. Howlett Signed-off-by: Andrew Morton fs/exec.c | 5 ++++- include/linux/mm.h | 6 +++--- mm/mprotect.c | 47 ++++++++++++++++++++++------------------------- 3 files changed, 29 insertions(+), 29 deletions(-)