From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956A6CA0ED3 for ; Mon, 2 Sep 2024 21:03:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B7BE8D0112; Mon, 2 Sep 2024 17:03:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 267188D00E7; Mon, 2 Sep 2024 17:03:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 109AC8D0112; Mon, 2 Sep 2024 17:03:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E077C8D00E7 for ; Mon, 2 Sep 2024 17:03:18 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5A3FC402DE for ; Mon, 2 Sep 2024 21:03:18 +0000 (UTC) X-FDA: 82521023676.13.2D54CEA Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf18.hostedemail.com (Postfix) with ESMTP id 4C7CA1C001B for ; Mon, 2 Sep 2024 21:03:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TWE51HuO; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725310902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=po+MmfD4nq5cLkClRRslOxFglpMwsYkFajj19L5Hzi0=; b=hAYXROrLrHMDixSuM4XPUCLpjnoXeH140UP2szGCsH8LJ4NwS/pyFpLLcH7OyOgsVsvbDB ETxiSQUbPD73k3rIA4hUB2aGpgIVUF4p45RAveTlewxTtd8jNG9uZI4WyaZAzXLoAKcbDt 5gWfYOklbvDYYqZBBbjsZ+3cy0bFDyY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725310902; a=rsa-sha256; cv=none; b=PXRANozMkbXz07uVdmzOx78c/68Tq44DfUDR00MC7HzKBQYxTgqtvjgg9Wy1xUWNA7SuiI YMIQI2xtrixLlouskQ8YBNkwPSApHB3v+SZsYrYX+M66+lW/ju3oADMb1qdk1Rxiuwa8q/ 7m8kZ7lxkWWh6lRq2nhSKl3izNF+G20= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=TWE51HuO; spf=pass (imf18.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.174 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-2f3f163e379so75075941fa.3 for ; Mon, 02 Sep 2024 14:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1725310994; x=1725915794; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=po+MmfD4nq5cLkClRRslOxFglpMwsYkFajj19L5Hzi0=; b=TWE51HuO137dbzriiG3tkJsQs0khC6fpn7ZzthBl5cdzLiPqMp2y5+St+mxnYm4w9M 8ReqMjz1rQHo7TkZX9Q+aAWWjQvoohg8mZpv5Z0ZDF84tD1ZWGoIoGgYEcXEFtr7+gKI 4LLrUVpKWZQQ1zDL6E22VAoHeMbdakPrIvmWY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725310994; x=1725915794; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=po+MmfD4nq5cLkClRRslOxFglpMwsYkFajj19L5Hzi0=; b=vjXXUt2URLO6ab+it8qapNHQgJ49GpqUTQ76izg4OHD+bBiZosox2a+Hdov6/6MOVq F4KLX06SJGSQ7hmS0cPlUJFDqYu7c7F9Ch4iUPGhbmuOZkSJo/eZYij5LHEjaynz8EF8 1VQaKXjPP5Bjx4vbebPFzZw316nWpBWtCgc3PGQ9zO3N/0Hd8hpbAc1GcPqTfOmhB7wL O7XWYeMp4SpcQRb5vSlVCD9u8Zt8doBiRSBmUqvtvrVgcywudHefnoG67/7LC1Y3CSdZ byVYyJ0VFnO1o6itoAfA4Teh+jPwMrkp+lKXw9rKtLeFZ2XX1D6M2tADfHyZKEIWzBT6 jKEw== X-Forwarded-Encrypted: i=1; AJvYcCXRU8Qo1z19pi2Rk08vrqSvlaOBKdZxMNi3EXpOIfk+irnHZBG0SHx8wWjCQEDl9jhIfjwVjXpLlg==@kvack.org X-Gm-Message-State: AOJu0Yx5PNHum9QTg4qyfNzEcOc0ceSqIcAozxsNbztShVzipGnH49eP gwBRrth/8XgIaebUB9TxG20dWk6Z3pNyCye8vCwxMyWB2p8FjIFfExlVuoUWgCAEYiYH00ZsOa1 09D6YOg== X-Google-Smtp-Source: AGHT+IHJTWlolZReGX5Ur1PMVMpUJbJAG2XH+Zj1uN646ozWjtVBPYUECIA+C/7cRkHim77+0iXD1w== X-Received: by 2002:a2e:a546:0:b0:2ef:17ee:62a2 with SMTP id 38308e7fff4ca-2f6105d8726mr128721141fa.14.1725310993684; Mon, 02 Sep 2024 14:03:13 -0700 (PDT) Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com. [209.85.218.52]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a898900f25fsm599718866b.75.2024.09.02.14.03.13 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 14:03:13 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-a866d3ae692so265361966b.0 for ; Mon, 02 Sep 2024 14:03:13 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCU0SyaO3fxA/pXKWJDTgShJVIzOi4IW3yqKuO6QrGGZfz/6poilStMBR/b93m+/0n0rvJZZd9WXSQ==@kvack.org X-Received: by 2002:a05:6402:34d6:b0:5c2:5d34:a45a with SMTP id 4fb4d7f45d1cf-5c25d34a63fmr2793579a12.2.1725310993097; Mon, 02 Sep 2024 14:03:13 -0700 (PDT) MIME-Version: 1.0 References: <20240812082605.743814-1-mpe@ellerman.id.au> <20240819185253.GA2333884@thelio-3990X> <20240902134953.e834bc2e57d36b1d3b1397e4@linux-foundation.org> In-Reply-To: <20240902134953.e834bc2e57d36b1d3b1397e4@linux-foundation.org> From: Linus Torvalds Date: Mon, 2 Sep 2024 14:02:56 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping To: Andrew Morton Cc: Sven Schnelle , Nathan Chancellor , Michael Ellerman , linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu, jeffxu@google.com, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, npiggin@gmail.com, oliver.sang@intel.com, pedro.falcato@gmail.com, linux-um@lists.infradead.org, linux-s390@vger.kernel.org, Ravi Bangoria , Steven Rostedt Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 9ukyypubj4spu189wrogsru4ww1iujky X-Rspamd-Queue-Id: 4C7CA1C001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725310996-24744 X-HE-Meta: U2FsdGVkX1+SE5jHhyjF13ntXMUAJwBP7Fa5ubrSMo3mDk9pLHqLtbjKk1GtxhDOPd8S4hkkGJX45u78IkQLX+V6RjGCV6fKv13n5/X+f83o6DlJw+1Nm9NmVY4YYbly+dE4uXtIIS+lm5RpNdkNMM0vOGJQI2I1KYmXTyzwc1Cfj1WIOkhSHMGjQztT5sL0y9C7NJipTZs5ZnrV1TAUX10p674Abewze/JAtIEu2yNL4AtddWojHGzYwBAvAdDintb886RFxBd7UQvcZVazVZWGQxfAY1mhTb2irCYf1xRxGQXo3jzIORIE4sqbmzJ6iCeydVQgN1KDBmIRQ6rqSgwzLJemBVvJnHsaFlulFB+g5skJpUmCS0POvOnKhlCAFNz6AHF2SV8vhoTD470adlfrS3vd9q+gueSua+GiAdEfsOt4M260EE8A2n4oY5wh6YtzxbaQ+7MLMqLamX8hc85QLQKWGrmff8bOUi5BX7hsU1o48p2vy13+mcxIXDpkhmpqKY8QZTcnbhBJQL8eunK5+/QOhN9941AUmlWTQ6dqvM4TRUjnCM5WOmm0lnAnzsqcGYCThSaDFngwRU711RVivN/M4vyzfa9qu31F8RVe0jS+xoGoPQPw86Bx7F6+iDvuBZeNIuGHWgekbK6vigAdKOrhoJRAMQsIuVU7nzocde8Og6HT0O5/tTIa+NF7U5a0bbDYCDkVJfUgaBrsMJ48WkJwKYYWAmZEkr59cgwPUooqL75lGTiNNiOQcIbMx0NZ7butHflJ33YFYPp2eVKMAFKrUNrqX1hfjoAibzqV53L01pGwXliwOkHgB437//dKn5tuCN0QPDC+l+95bjyq8ThaB4t4qfLqqvzdt5DnznHWCtfZ7GlaCzimue5POLScPcsWkQd0y+DQ1aX9PFiWesxwM4KN/pruIQ0xcfYH8Of5PawgK3yegHKUCb4DYnDl+IORrDeLYUXIJne k/JT2qjG 3N8ebsE0pdtqJ5R1C3YM9qOD06E7N0xJXIJR/GQv8UZusQP3rueyUIQTAkVemjy4Ot/kJRT9u39x9LZDpgM0W/wzGeFneEws/+n/gdtdAVVU2jFQ9ciQ1QjBUIqzpBmxMpiIp8MEakM1IjkFe/JKsWzHkxq2KlQETEK4eGiY2qcuWXxxLfc13l8hFzR9C0aw/PUMNN3VaMnXJex4B90cnqIJf4WRcye4uPGtqVreBJMC0EHTJYm1Osxhpb+7hjJRQQLZyhgeelhg/jQLWXkY979jRjxmr1jWi955kHs9mDyyFc8131iNU1ESfrAr3vgNXgKC0UjNSOPQXOQiQvbU+zDh3U5jTaaPpJsc6rYREzFJ50eTRLV8+U810ZBeU4Y2zily8KAwIKhQsakPp1VwuuoAbf3qkfO4fRwWmzpZEoYYGXiaJG7q9TMG0hQqSY0+7tGQhbDlcaxKh17HnppFvwCViIes40g1LPMqrEBSjs+0jm04OfofkHNXaR/6UTEkSmwX+7oiJN178j5+FZRF/2GTfuWcKJT/Hy239PK7XeYQMYuSWvZLLrslcOZIAeS/vSsbyhg22nbGXsmaaVtjHcnGBwqi7xVk78SwLA0s8jZojBC2n9qfD7NXA6xRgzxpq1sktxL60NIqGu74= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 2 Sept 2024 at 13:49, Andrew Morton wrote: > > uprobe_clear_state() is a pretty simple low-level thing. Side-effects > seem unlikely? I think uprobe_clear_state() should be removed from fork.c entirely, made 'static', and then we'd have area->xol_mapping.close = uprobe_clear_state; in __create_xol_area() instead (ok, the arguments change, instead of looking up "mm->uprobes_state.xol_area", it would get it as the vma argument) That's how it should always have been, except we didn't have a close() function. Hmm? Linus