From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3DDC3DA63 for ; Wed, 24 Jul 2024 19:52:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 345076B0083; Wed, 24 Jul 2024 15:52:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F4786B0093; Wed, 24 Jul 2024 15:52:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BCE06B0092; Wed, 24 Jul 2024 15:52:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EF2566B0093 for ; Wed, 24 Jul 2024 15:52:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6106D120BC6 for ; Wed, 24 Jul 2024 19:52:34 +0000 (UTC) X-FDA: 82375693428.18.F1D3C63 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 46D01160014 for ; Wed, 24 Jul 2024 19:52:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Xiqsjv5a; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721850698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7JcAEcAAGSH/Vwm48mQCH7JL77mTwpetHzT5LsEik9w=; b=SDwFFXiTWX2gGMuBVZ+W4yjYBS9ZikteryXrv/rjyW/clVYdwI1yGwnZu7m5UK8L7ztQN/ 2lHjloGCSBuYVR8zJVV2Vx3WBvzxdKHEGZgHNxICLNzsc1G9a2uGyHXo7FWrs8yJ1Fwdgo ciwc4EWVA6l5twN1h7ZSQiXvgC0Gmac= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721850698; a=rsa-sha256; cv=none; b=72hxoI98Adv4Ri1fm0JLUAby2qWjk0dICNaWiAnjHYMzqbQnNpbmPfWm9cnZG3PlviioMR S0eoQGZX5SXKToww6OSH+sqOufKlqwThL8XEWbGohPDPRgXlhaj2yLd3zWXhkJp0aeCUg/ CSPwQFG6Aa331RFuZz28/ZkikapislU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Xiqsjv5a; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf08.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.42 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5a1fcb611baso256405a12.1 for ; Wed, 24 Jul 2024 12:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1721850750; x=1722455550; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=7JcAEcAAGSH/Vwm48mQCH7JL77mTwpetHzT5LsEik9w=; b=Xiqsjv5axVHwSHjMp5XOFBS/ThEqpYHYeCTmo+J217tINp5VTqEAKX1j7VTQUw1eHZ Fp3ThGIWuXt6zcvHgyc1Uxy35wMmoiTpyrOkwqELuaMjXhzt13invR1nCv7XGkluOY65 xa7s4XkaRGxmL5Uar9bB3vAK7984fuFVrPQdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721850750; x=1722455550; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7JcAEcAAGSH/Vwm48mQCH7JL77mTwpetHzT5LsEik9w=; b=b+dxL8lhFtl/f3r+9MkZekgUpiOrukbpJoiQDjU7xTmxcBb80gM2gAe0lSV/ksFxPt 79apSryB9xD0XrAuT2Nso/QLUU416Vgir2ksricT3PtttxYWlrgB2/LaYpREa9tyAdKn tF63xO/eMbxZJBSW5N3X7cuP4E6ToyioEW+PcgcBlXTU8VCzGtZIgjK3zSVJwV96nAEr fJ2N+7ppfEXDa+NWWoyoH17WiNk20TGQC0HLu8rGLuDM1yl96pbGcoxmHkQfsAng31m+ Ft3GDYCBjJRF8dxMmqeduHOmUCR08xrmpLmomtVEsvbo6o9fBW4sTEFUFcy1djOIQsW0 WBaw== X-Forwarded-Encrypted: i=1; AJvYcCXPwcD69qsUBWPS5voAWkkArw8sPnMl5KHYSY9+wEjLMVir19YZlSB0xnHSgDeIlcsBLH9FqeEh8G5FDUkFVwRJCUA= X-Gm-Message-State: AOJu0YyKM+oEkfT+xGiwnGTgZmhrXPz4kjJyjq+SKpHo/UsQT1Ag2wR1 RCHWzGdPzizHNsSwpN65hjSljIVC32Gzd1fWguYH64xrrv47WbXYIRgQ+e8ADv9FWk3U7efNbT9 5uHM= X-Google-Smtp-Source: AGHT+IGtgcYqV4jzZetDVzfBIEK8kCzv7csBbSLpGzTUMA05FNm/OuuFCETJigUPMTxpwsUBBr+7qQ== X-Received: by 2002:a50:9ec3:0:b0:5a4:18ab:fd47 with SMTP id 4fb4d7f45d1cf-5ac2a8ac017mr285014a12.11.1721850750614; Wed, 24 Jul 2024 12:52:30 -0700 (PDT) Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com. [209.85.208.43]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5a30c2f8808sm9227585a12.78.2024.07.24.12.52.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jul 2024 12:52:30 -0700 (PDT) Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5a10835480bso273328a12.2 for ; Wed, 24 Jul 2024 12:52:29 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVKKZlXRfTpCxL7l7z+2BH2qXrEbaTpxQWp0zoH6nCstnDcQJFG55UNUYRGbM8/N37cKwEhqteeB3Bt4baQfXRR1t4= X-Received: by 2002:a17:906:c113:b0:a77:cbe5:413f with SMTP id a640c23a62f3a-a7ac4d5bc37mr30498366b.4.1721850749532; Wed, 24 Jul 2024 12:52:29 -0700 (PDT) MIME-Version: 1.0 References: <23bdb6fc8d884ceebeb6e8b8653b8cfe@AcuMS.aculab.com> <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> In-Reply-To: <902a9bf3-9404-44e8-9063-03da3168146a@lucifer.local> From: Linus Torvalds Date: Wed, 24 Jul 2024 12:52:13 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/7] minmax: reduce compilation time To: Lorenzo Stoakes Cc: David Laight , "linux-kernel@vger.kernel.org" , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 46D01160014 X-Stat-Signature: 3fpd1mpnc4fdjie1ywx6qnbc6h3keho1 X-Rspam-User: X-HE-Tag: 1721850752-790082 X-HE-Meta: U2FsdGVkX19w96bSt/kmSxZTZuip5VOzDdDbTeO9eTiojYBhdNwo8dDGWYb+QRZSqiez0CpLItMrrHIA17Nr80brRiNGpYK6DfJUcKqIN9sM5ESIPTRW5O5K0toA9sa4vqr5fkaoU+kR2DWKDfpKDfPW/nees2gYI2fBsGaYCkyM9BQCehXaSAFUnenJ4woU+4mESyhiOr8HKdvGq1UZRnKLyTzDcuDyoeYC3sQu8mfrBMPwaOOoW1jh6YM6hBBX3RwezhghUAxTObyYq/o5LC8JKf3tt8C2WsbNwzRG1rRq1hBJqSO7rIcXUmaqVysCq8/k4+dAU49G1kVfgzhkHmkfZuXoJKJJowkpgm25IC6GPcJS+4Ww9K27mGOOWpfNK1DQrOuRCEnMJS0yIEWFc2/ckQthChrKwuX3T7u7joeNKz9QbbRQ08cLnK8XqsjzfEbJ4V7PKThgEWDmPhJXlJpo/us19md4h2tBKUqECkfJ5M1P27eAjnicXgMxdJvZ7P+9bo5y3nnnuJO2IbTGhAZdbss2jOynHqvYf7lo01gz/HAlFdCWPZtEubIzXbKm0TMZjz5ZV75KuZ7hOQOr2dzx4q3D92Trzb+ESajJOcjFFwq1eLiMQdKzhPwdWmMmKfqiRJlOsv9bn7oDf2W3Yyto9CdYeImk+xeOTWcIb08jWFkgQ0QWaj22vqxHbEZJDI/Pz3wOQFzHHESHcQkmEddrhj7P1dSamsD5Z2hIvwKC8+npQFBuHZy1fRASEfiMIye7xUT4bNmhqqgkgUmyZjbSa4QHs2lmCV9H+drR3Am7xnwA5SZO6hz0ZcU6Cgp2/aNJd/W2uhknyYTrcZGEHfq8x7cqgxsLMCzi/wJ2SxirqsaTCSaYqZvrsf3rAeWHFS2tvCIj+Be1Z5SUKXLG+Tw1y45WYJcYUBjiPrUwOlE8h+n1ApE0dBLjRRxLpk7lFMSxsiYLid72FqYKVyK FIbGinOG ikb2Jkqasz4E5B8M3kQhmaCZEyoE4GmmTrJ43RvwljPmLTPy8RkSZC7ayJTLwyKCWA0ZB9xBbdbsWwrwoKKeRBmjtPN6m9IgIDA25buSjQ7ByQyMUMhkoelulgVH0mW6iN8IPTlOiVDzhjCafRPZZNKXnnS0a5xFuQX1sqDLfmiNA0B4KegJ0RqZ/KybmKR+e3zEcy3l+y0PhZgAL5wkmBH3Z7bo8ju6W/kYmDeA4FN15w09pKQzdRqbHbBnUIixNFKAPFbKwgM9s5GjE4ILOMJn8Bn0K//62ahob4mP9CU0ge/htbDsmmywiD+NLQwISHZqFJ+Isa+ghZrSJ4pQhr97C9HZyO0f36PnEUd52u0BOGRn+PxiprRYcwJm7H5HANVVeRYnWnj822Y8RcygFGtrQqXc9Xu3b3/9JvNFaJm+ad0vSRT1oVLPnsQQ4UVsKhw8s X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Jul 2024 at 12:35, Lorenzo Stoakes wrote: > > My rough numbers below, on a 32-core intel i9-14900KF box using defconfig + > a small number of debug flags I use for compiler development: Side note: I think better than "time it" would be to simply generate all the pre-processor files, and look at the size. Because to a very close approximation, all the overhead from these things comes from the deep macro expansions. And unlike timings, the pre-processor size is going to be (a) entirely repeatable, and (b) will also perhaps point out other worst-case scenarios. IOW, maybe there is something else that looks like that "min3()" horror, that can be more surgically fixed. Linus