From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B1D1C4332F for ; Wed, 9 Nov 2022 21:39:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 597C16B0073; Wed, 9 Nov 2022 16:39:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 548506B0074; Wed, 9 Nov 2022 16:39:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 410B48E0002; Wed, 9 Nov 2022 16:39:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 337976B0073 for ; Wed, 9 Nov 2022 16:39:37 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F1319ABD73 for ; Wed, 9 Nov 2022 21:39:36 +0000 (UTC) X-FDA: 80115220752.26.E950491 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf25.hostedemail.com (Postfix) with ESMTP id 968F9A0002 for ; Wed, 9 Nov 2022 21:39:35 +0000 (UTC) Received: by mail-qk1-f173.google.com with SMTP id f8so68745qkg.3 for ; Wed, 09 Nov 2022 13:39:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vsuxWWcLBTsKK8/tKqd6R9Q9SBeixSSI7f1tIJOfP3Q=; b=W7nJiSHStUafbm8wEUI0XvsruUyQ63k69u3kaAuU2Ej1IR8KHrcOVBNI7CsCTNA5kb DKI0z6tPEdE4UyxnX6xKBHkCUiWsmqSlQANTGRxoNyLcrGx0+Sr7311DiwsIv/wfYqse OCvh3V2m7rIxAC6P1iPynkfNees+Tz2IP3DKA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vsuxWWcLBTsKK8/tKqd6R9Q9SBeixSSI7f1tIJOfP3Q=; b=xfDl/IS64cH7/L56qRZKT4I9aU3huXnnPfBEHb6JFtDWyGYfjz67z/IzppBPLxR/wh wY8pgvEk6QSN4lZqc8dEBej5CH4GClsb8RTnRM7YbeEweBxevl6OGMxPVsgVDiybzlSY anERDB0Pm4vMQyjY1yXDtLlxYZXgybRVbOpO6T8Xc6h9Wh28PNgcO0iXoBMWfbDRXbmK BncS5vJMHoV118C8xmd7DRTk6+u4g4AKtSy6WUtVblKqCkFrdJWLOi3PoB0lUGD5Foew B6QagKpKToA3p5N54uOO0RpjBXuD/VNdDdRQsygJlXY/eCwNgQK/OV1ioq673w9e0HsG 3pWw== X-Gm-Message-State: ACrzQf3jF1OIoNsXzEaxmy5RRKmMZQ9Dc2RibJxDncfjCc+MwjDuKa6Y 2LLQXx442yCVv5NUztbCnVpK8MAvRg9fgA== X-Google-Smtp-Source: AMsMyM5G539zeLFCjd4BsxyZimEa580149fl/3ULbFZlk3FRpE7p5titVzMXC8jYWLsywOmQyB3uuw== X-Received: by 2002:a05:620a:254f:b0:6bb:dcb6:4279 with SMTP id s15-20020a05620a254f00b006bbdcb64279mr45454752qko.79.1668029974642; Wed, 09 Nov 2022 13:39:34 -0800 (PST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id s21-20020ac85cd5000000b003a55fe9f352sm10398075qta.64.2022.11.09.13.39.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Nov 2022 13:39:30 -0800 (PST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-368edbc2c18so174378917b3.13 for ; Wed, 09 Nov 2022 13:39:29 -0800 (PST) X-Received: by 2002:a81:114e:0:b0:36a:fc80:fa62 with SMTP id 75-20020a81114e000000b0036afc80fa62mr60778035ywr.58.1668029968753; Wed, 09 Nov 2022 13:39:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Wed, 9 Nov 2022 13:39:12 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Deprecating and removing SLOB To: Paul Cercueil Cc: vbabka@suse.cz, 42.hyeyoo@gmail.com, akpm@linux-foundation.org, catalin.marinas@arm.com, cl@linux.com, iamjoonsoo.kim@lge.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, rkovhaev@gmail.com, roman.gushchin@linux.dev, willy@infradead.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668029975; a=rsa-sha256; cv=none; b=SXDXcPZBfz1zb5lYx7GxXzMazaeMXB/z+wP4xy8e2FSlxoXhqXmpVjM0bPjD5HpiL0rBDY mkd7hLW59MFTV0jC5nra5ZdZdTvTDz6WXFfxqlnueP6cNH4nLkpnIrRrd80GNY8Yr3EXJz zkOn8+70jnHoveHCUXrdf3vaGU08/8U= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=W7nJiSHS; dmarc=none; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668029975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vsuxWWcLBTsKK8/tKqd6R9Q9SBeixSSI7f1tIJOfP3Q=; b=rTWgatIWd8YNjlWvmyTXekY7ycv5bw45Km5DboRIJwo/z+GV61pmzdqjSzxYkERMAUL57G zFAgTgRb8TMt/rJzYod1TSPFj1x7OWPgSOV8ebBiKrEFJGpYk1GNiVlrgwOC8usSfMscXg skOQt0VKJDPfzOAZ9GAAFVmvj8ed3og= Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=W7nJiSHS; dmarc=none; spf=pass (imf25.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org X-Rspam-User: X-Stat-Signature: xjfsjdjb9zjaauoq3eamtqec9ghm7b7j X-Rspamd-Queue-Id: 968F9A0002 X-Rspamd-Server: rspam05 X-HE-Tag: 1668029975-960942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 9, 2022 at 12:56 PM Paul Cercueil wrote: > > It worked fine on some boards, but on others it had about a 25% chance > of booting, and 75% chance of hanging at boot. I tried printk-debugging > it, and was coming to the conclusion that it's memory corruption of > some sort. > > Then I switched to SLUB and all the problems are gone. Same with SLAB. > > So while I can't say for sure that SLOB is broken (it might be > triggering a bug somewhere else), I am highly suspicious that it is. I have this distinct memory of having seen other reports like this, but my google-fu is not strong enough to back that up. There definitely has been recurring noise about SLOB issues. There's a reason people have wanted to remove it for years and years. Linus