From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AC67C001B0 for ; Mon, 3 Jul 2023 20:07:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D32B280034; Mon, 3 Jul 2023 16:07:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 583CA280030; Mon, 3 Jul 2023 16:07:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44B19280034; Mon, 3 Jul 2023 16:07:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3303E280030 for ; Mon, 3 Jul 2023 16:07:02 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 049CBC02B9 for ; Mon, 3 Jul 2023 20:07:01 +0000 (UTC) X-FDA: 80971384284.30.C360644 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf15.hostedemail.com (Postfix) with ESMTP id A16F5A0013 for ; Mon, 3 Jul 2023 20:06:59 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=GbiixYMX; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688414820; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V2f6CeVEYoIPtaOwjl6002xqVQVMjkJu/zyh9V6eFF8=; b=UFwKpI+uARTk9aMQtFBKclzLS0z5InmyZbcZqpiGFplaCjmz4xl4fBfyiotvdBqSoLzkdc YhmWCIPLjPDnyvYC5A8S1REbpl+u/BvSxwOEfgsfDhUQXiCmHKcx2TToKmf9r1ReEhSz4L bcfHwAFo9OWRNDili95Fa9IucPB05mQ= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=GbiixYMX; spf=pass (imf15.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.170 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688414820; a=rsa-sha256; cv=none; b=CKSd0w+ilxr08TyLt64S6i0KppA7FNxdXILgZKJoCVlZ6ftIWa+BXpkwHfFCROdefaUwAq 87G/2G6mc7KAXx+eVQ+BA1ck1riKO1qJptn03srfoewUPwq7+o7XhBlRUaOvs0CB0II/Zf a+8Crb+pTktDF7UtUYioImOhYH6sd4k= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b698937f85so80747041fa.2 for ; Mon, 03 Jul 2023 13:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1688414818; x=1691006818; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V2f6CeVEYoIPtaOwjl6002xqVQVMjkJu/zyh9V6eFF8=; b=GbiixYMXHHXBZ0ltURl5XxNTqpskB/3OMUg048je69dh8+JxT+T3r3eD/BqXas7qYx LKkcIDq7y/pUlsz4WpX8ZJTeHGxZLHf9mvTDcVOFURBp4WqoIk04HaoSVd0PKmu5UGG6 98/OkPcPED5fnoVN38EEWY7PfST/j4SohBbU4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688414818; x=1691006818; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V2f6CeVEYoIPtaOwjl6002xqVQVMjkJu/zyh9V6eFF8=; b=UdX0ya5ZTCZ+EUA/83NykbWLt6blZ1PL1q7YHiWsZGZv0FMhnQ4cpC+aMrR6zGZf9P K/IYIhLpSVrk39/ErN+DPgooE3ur5+NNru9yLTWAyBSGziOXN9853HlssM03vjpNEivT uRmZKVluG2+IppR+vB7yPxJVCUZ1DJSqoiHkzbTXp334D5P5ingp9ToRmZf4CXNqp5QS QQ/vEPNXCAcUmIXhNYGz+VDd3HyfyT1yxeKkHwlDoVJOKxyrZ9wcA3p4qokXLYhZ5w8D 2KRTQVBUxeI1ocPZO4O8DvoRXjnSBrql6GPtm2vYsQPSRhRtITbvet4lkYRPxrEcWMA9 3uiA== X-Gm-Message-State: ABy/qLb4mm+jl42Txp7EBPgauowqXDTHYTbRYI+GA4cd2ZdJ3daV2Z96 s41S0ZN1QEnihq0ZZxSbxCdq6KQXsugFd77ZRiL8e5xO X-Google-Smtp-Source: APBJJlHiDMtyuv+vAShCk2FnM2FN3FZrkatkU5JLygaamjkQ4GPaI42PgFJ0cm+IIJCWxP8Pfzgw3A== X-Received: by 2002:a2e:8607:0:b0:2b6:cf31:5e81 with SMTP id a7-20020a2e8607000000b002b6cf315e81mr7908517lji.20.1688414817580; Mon, 03 Jul 2023 13:06:57 -0700 (PDT) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com. [209.85.208.50]) by smtp.gmail.com with ESMTPSA id gv18-20020a170906f11200b0098e0a937a6asm11737416ejb.69.2023.07.03.13.06.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 13:06:56 -0700 (PDT) Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-51d810010deso4570814a12.0 for ; Mon, 03 Jul 2023 13:06:56 -0700 (PDT) X-Received: by 2002:aa7:d71a:0:b0:51e:bf2:6c70 with SMTP id t26-20020aa7d71a000000b0051e0bf26c70mr2952942edq.39.1688414816375; Mon, 03 Jul 2023 13:06:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Torvalds Date: Mon, 3 Jul 2023 13:06:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] parisc: fix inability to allocate stack pages on exec To: Mikulas Patocka Cc: Vegard Nossum , John Paul Adrian Glaubitz , Frank Scheiner , "James E.J. Bottomley" , Helge Deller , John David Anglin , Andrew Morton , linux-parisc@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A16F5A0013 X-Rspam-User: X-Stat-Signature: ryccc53dreb3g51xmhfaf83c5tf4j7bc X-Rspamd-Server: rspam01 X-HE-Tag: 1688414819-238317 X-HE-Meta: U2FsdGVkX18rp5THww+bGFxJ8bP0srPYC5L/f0zO2Atm+tVBlKIWV05pcxsitbImao1G6yWW+vA893WxGAq2HEOpjeqD1dp0WF6DCHWs3j+TkyiUzq+yrYHB2QJ+JAEl9xG+9srTz38pCvxnIf31ixd56vmHjhtusGx/zL2nKCTzkyEC8GFiQVooNdyhulSW9OrL6M3r6pS/vAklGMQFoQiubB8LBLf4bPqJqDDFu8cUGlTys1fM++xwrfLwqF0JSpTtLw+4kMzPP6HZ3FIaA279rsbi11vMAl5oHDLK/9wen6/az1oOJ4XpK4xX3AHoAa0OVsICQsMFaz/9lRm5LyT2R1R+CoNFI01ZTH4NLFqd6mhU6N8P4+//oW9QXYpkQTjCri0ZU1pVn/0UJli6aKqtE+Ou1KNPo5pyphzOHDeweAvV9sU0RCedD1FW4Jvqzjm4GAE2jF2IEJSruOvEX923NZL03WDrTHt2yp+SMKkMk7OjvJa2TTIXZChiAjHzAV06KrJOo6vK7HV9Y7wcMXPlM9QC+kRzsFXIY1CRyDaW3TpvZ9/diYhaNXXCnLx0ALHJXzIe0JnNkQZpbeQXjQct7740sONQTFGWK3YPqQEHK1NcHKU/tRY+i9J/SXopo56G89Md7hsPGTOkeFV4r9UlVEdtd0M5jtDvFTeyQ8V2/muGmfXmdXKZQ7FcxxARFh40UX4kFnk9rDnfhxFElZFC+3mD6Usvs0kJSDtikSL5Xn1VpZF8IHrvwSF2hvvVEC9vtvSAu3o0SI4MKLcxJu4AlwlLMgG4rTXVKmgM/SkTRNESXoTX1SOhTb6RXO4gIG1TR66P8lzXvxFQJ24OjBh1sYAPkZ6Zj0Y07Fv2wWCz9TDmQFJatyhh1Ciff/XpZSKGftu8Q5iVpD+yIvieTIoDsWEjOPNUllohBWcf49D/C/OXv+xccSLOf54OkluJmbEcQJg4Hkz0LkNKKHd 4BhaTGuq OEQePU1srSeX031vsbJ75DIZNZPbhgN5EHxUbJ+5xQORYj9MR1m4QS4qkcTdWnuqlI9P/Yb1B8xi8Xnd6cXunzuEcS0n60u7Q0p6/jUh7bnpPArH6halz0yAhZoGcXGmkNPBMjABaL2ZFI8gbDJA53Rbsb6JFl2Wx4rnm0kszLXmfkt0MK4GlwQThrj7O4Kv8S+opCTawyW6O14OocvbVOJDpnuwaDn0xmfrMoyaTjBEY0j+GEQ8KOAlo1v/mH/yYzqT57NsJcDN2SJHCbxn/9XCbCx6d7H0oAEkhj5DsoZ8bIPLKuLYq8R85b4pAPuyBidjz0XdNaucCODcAhBvZ1/gYs6VndPx/0h4aDsFLN0eqcK/7QOHIakd61wgXam18X91WqgGjeJG2DdAqiDrLY3KmoEDltpkFxYbjaZ3nHL4bBp8lM3ZORfPhufxxBW8CLQX+38GcEnFcZAS4PgdaavUxVJGfoK1oI2zANLLdtBqYf41v/vi0tF4T9wyMcPe+8WjW7yomu51Nd2Vjn8SdaChDQw65NB76a01kaxBVrRuV2UsKsAqLpXqhwcxcNZLVbGI4YOh/FjDmZkh04YgcwLRtC7dJKxYYt2gYXdvdyHjXm3h51YJ/4feMyBoNxE3MrUfM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 3 Jul 2023 at 12:59, Mikulas Patocka wrote: > > The patch 8d7071af8907 ("mm: always expand the stack with the mmap write > lock held") breaks PA-RISC. > > The breakage happens if we attempt to pass more arguments to execve than > what fits into the initial stack page - we get -E2BIG in such a case. > > The reason for the breakage is that the commit 8d7071af8907 adds the test > "if (!(vma->vm_flags & VM_GROWSDOWN)) return -EFAULT;" to the function > expand_downwards. Heh. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f66066bc5136f25e36a2daff4896c768f18c211e which fixes this differently (and, I think, much better). Just removing the VM_GROWSDOWN test will actually break some of the other users. Notably the new and improved expand_stack() function that now handles all the complicated *cough*ia64*cough* cases automatically, which allowed unifying the page fault handling code around this area. Linus