From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733ABC3DA49 for ; Sun, 28 Jul 2024 20:14:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FE526B0083; Sun, 28 Jul 2024 16:14:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AF0F6B0085; Sun, 28 Jul 2024 16:14:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDF606B0088; Sun, 28 Jul 2024 16:14:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D1F516B0083 for ; Sun, 28 Jul 2024 16:14:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4C5C11201DB for ; Sun, 28 Jul 2024 20:14:03 +0000 (UTC) X-FDA: 82390262766.29.30D4185 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf22.hostedemail.com (Postfix) with ESMTP id F2841C0023 for ; Sun, 28 Jul 2024 20:14:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=AjCUbaSe; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722197588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M1Snvl7BN/K7T+WhjV4Uh5adO9d93A8cd3uOzQBMOH8=; b=PBQkEWVNOH2XUncqBwTp9JE3Pr98TN8kCrmLQ/5LuoK+Dw2ECyvnTT7YMslpeqxKFvOSrm Z2EK+QC+F1T2KKHApuGY6W1jKdzhj3oX2wGC4EnwiDfinMVC8HUu/89XPpdUeLW+GdGJXL D/pXifRbe5uAwFg9vXO32YPugYdOL6Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722197588; a=rsa-sha256; cv=none; b=kzmL3qd5mDTRP0NceAFap3SeOnLuGweJexQGKMLGW6xT/kfgVXFj+qLKjjGcgwic3k1qSb Pe3KE7hADuwpLKqYs8iQkOqlcrA2xwJk/wcbImUxGMZjIPs6++y2b4Piqabmj9e47bqrIp bsUwo6hW32t+2i3g0787i111+pcZnVI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=AjCUbaSe; spf=pass (imf22.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.167.51 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-52efaae7edfso3079255e87.2 for ; Sun, 28 Jul 2024 13:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1722197639; x=1722802439; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=M1Snvl7BN/K7T+WhjV4Uh5adO9d93A8cd3uOzQBMOH8=; b=AjCUbaSet+brj111L3CUKY2SfT2WE2dBTvLBmozj8Sw2lJsgmcoiej2y+rdfPdhoBA QVsZQHR/fRpVfZIz5Ni0I2famuJ634dytfLJT9wa1ERxhOIPf3DKQ5XImVrhEMWgJ9tf UoS2nFSACj7ZYPfGMI/azYjMVNErmzF3+0xOk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722197639; x=1722802439; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=M1Snvl7BN/K7T+WhjV4Uh5adO9d93A8cd3uOzQBMOH8=; b=xIjMeVkSq6KMqqAaMve9jY9JHBn6K+jLzo0b5IRwDezaaE06KFp9gPMJMTqwNRra2j XlL7CLF6dM4Utc40ihMTcE1fgBduxPgj0dKAuP9e4miWTMk9yIhe4TxXiPvVqYb8kZhg Gvdkz+IHxtAckS4L3x2kESTEoqBc/SAhXrPMiVHgCBk2m0kzR8BxzOqSdnL3eg8SN66A 0wSyNqufF7/XrrrYzSknekh1Q+OjJFmyy4Fn+x1vhiFkYSGgmEU+oHB1Dw0SxhfgGdNC oMDdpqZvaeIqXVs8mk7kStHEwmPXFeIpntcpP9X6Qzr2pQ3jzJZG9Wixi9E25xCub54b nmeQ== X-Forwarded-Encrypted: i=1; AJvYcCXzNnN6Z6JTTBZBvfEt4jj8EIQs1cqqZqJamH57HWuEYgCaFVjb6XoDHH89aSYLrKdPPHybdmxyxqNcyKOE4BMkLGo= X-Gm-Message-State: AOJu0Yy4aoqgJy8lSWBSUF9inNuDC/j8lsHDOG+W+C8fh9RbJe/+PF19 Z8S34WPZANlK14av8Uc2ELhF+Swzzaa45jf+Lh1VhZ6spvdKZnuN24QOnWYg5InJm7QZbDcrxXV M0zWwog== X-Google-Smtp-Source: AGHT+IFktewdg0GlJYGP4QA0+zceVQz8Cor9/Wt82UhSkQ/Mq8NVOgzGsOyoreDoAiARojF/tMolqQ== X-Received: by 2002:a05:6512:480a:b0:52e:be1f:bf7f with SMTP id 2adb3069b0e04-5309b27b283mr3252408e87.27.1722197638646; Sun, 28 Jul 2024 13:13:58 -0700 (PDT) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com. [209.85.208.179]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52fd5c20829sm1189098e87.234.2024.07.28.13.13.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jul 2024 13:13:57 -0700 (PDT) Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2ef2c56da6cso32524061fa.1 for ; Sun, 28 Jul 2024 13:13:57 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWikDfgASSSEBRvgli9tE7mkIfLqkP9Eo87Ge3V3CJImybJ76WUqbTN7ZdbIhZd/+f9q1wEDqaZWev6/JhaOzGsmHw= X-Received: by 2002:a2e:b536:0:b0:2ef:564c:a590 with SMTP id 38308e7fff4ca-2f12edd97e0mr32563421fa.29.1722197637311; Sun, 28 Jul 2024 13:13:57 -0700 (PDT) MIME-Version: 1.0 References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> In-Reply-To: From: Linus Torvalds Date: Sun, 28 Jul 2024 13:13:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together To: David Laight Cc: "linux-kernel@vger.kernel.org" , Jens Axboe , "Matthew Wilcox (Oracle)" , Christoph Hellwig , Andrew Morton , Andy Shevchenko , Dan Carpenter , Arnd Bergmann , "Jason@zx2c4.com" , "pedro.falcato@gmail.com" , Mateusz Guzik , "linux-mm@kvack.org" , Lorenzo Stoakes Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F2841C0023 X-Stat-Signature: igo7qeybhbdyoxeabg86h9hfgpsmcarg X-HE-Tag: 1722197640-762710 X-HE-Meta: U2FsdGVkX19AaYtW0aQ9fqUx/R1pcQO4LKRN21zu691msBta+gUijgTTMJlRFdpJDPTIW+r0O6eGnBSNFNJgqJX2MrdbVKwB5qJJ75pPg8HeOeiRADdEzjT5FqFaZr3g3YtQuvI8oYd5L2sVcF5idGnAuIhNdiHLOhq3ovNEGE4B7olXqT3vX4kwuQnyUvrWCOLmnsFtlcfCvNerlDZoVPxEEzSetQ6JEftlQO/KBR0m4hTGajfEvVMiFNUPOL3nWW/9AX/4QRY6a7jy/29v9V662esr4t1zFf7pc5sDvf9E66z/pm8uKrNQNMYIsQNT6OPuPJCXxk/vrip4QVBq6aq5UcHoMb+B9WraD5fbJPYj+EgY2dYOAb2802COHKUrqBF6m8UyVqFhtDpi3rRNSpQKkZsv2eDqAwxOzq2xg4kNTwdx1s++4WmXdEx/EjncFEdh4oZhs0xTcm61CJ0Ko/XWXomP7kpXKtVgHrBqRFYMBRdfAGrPahTsELt5yiJq+MNU00XDzUo0xMIbtW++0mjw253SjNpechU04+kdp/tTrVrA9WsdutAsbb17oCgpIs5gITyGEu3JLOBOBp+HyKFddkr7swAFNDlqOihSdRoqYD3MwCYjNAOBsmX5Z9Op0psM3dC8bOjC75YKfgkIislAugGQ5W198mB8OtvOTAHi8Wgj7iWOLQmV1mhj+BmaC3d2wDxORi3z4pVh9AlFWl/fjIqB5fpjOjN847ajq+KWOx2rHr4ZbEFhNecN4EGoDrtRDe8VGWmDx7Nwyvt4PzCxAG4f4BxzrjPrPJG7iQG7JokNJD3NEcDbBvEA3c1xnEigMPAkxZdArTvKu+k4rV5rn0LraqDq9soIvs8lpG9jb0V+RbO7FaoeA55ZeQdBW2xzrlqlJXVvEBk5ChGoGn98yae+IFY8RWA4nRJUQj6xIaGAGByLT914tmXFpQz3Z2HNp7ZBsfRyn9xVY4b 9Dre9Zpd H5SMvm/s/v9sE1VpTi+VFEnF4626YFiLpPvCQgCA348W9rTVlsmp1sdoSgzeMc/uzdh5usSP9Y0+Vqgj8Q3qjJy4w8A4SmS6GiFA7lv9AaMSuLEcXwU5cq7OlDSNwv1QK9QXvZRAeJOoTMuGLnhWBW38Qxsp2LNNzB3vWQ45EzXHssMYJY0hXhqNCyPdNjq5AEst7YAlb5XY55SQT8S0nNV0eiTLGkjjzI+6GlnP1KXndIs1O97WXjgANJ5R/eqAXjpf52+S+pNyPYxZ7xhLbtMF22zRrE7Vh9yBBSnz7JaOixO4Nxqbmsd1WX1XParIfQtg3PPNLe2gsTOwp5Fsw8K07y//tuFmRadb0U7MwahahSA8J3I4KnndOABi/VvlVRG2b1fWZJu4DOJp5H1+0cZDb4ivkDNH7hogI0d2F28PucATUHD9bJzZH9USTejmL+EBlNDd1nNJxeatFMmZeRHSUsTrygc/uNtnvQSM7SB05lr8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 28 Jul 2024 at 13:10, David Laight wrote: > > I think they just need to be MIN_CONST() (without the casts). I'll just convert the existing cases of min_t/max_t to MIN_T/MAX_T, which I already added for other reasons anyway. That makes min_t/max_t not have to care about the nasty special cases (really just array sizes in these cases, and they all wanted MAX_T). > But (as you said earlier in the year) that should just be MIN(). > Except there are a few places that is used that need changing first. Yeah, we should just do this for MIN/MAX too, but that's slightly more annoying because those names are in use and defined by several drivers. Which makes it more of a clean-up. But I'm inclined to just do that too. Bite the bullet, get rid of the whole "has to be a C constant expression" pain. Linus