From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5D5DC432C0 for ; Fri, 22 Nov 2019 17:06:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8012E20658 for ; Fri, 22 Nov 2019 17:06:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="WdjUx8aH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8012E20658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 16D776B051A; Fri, 22 Nov 2019 12:06:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 11EC06B051B; Fri, 22 Nov 2019 12:06:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 034806B051C; Fri, 22 Nov 2019 12:06:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id E34266B051A for ; Fri, 22 Nov 2019 12:06:55 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 9A3FA40F1 for ; Fri, 22 Nov 2019 17:06:55 +0000 (UTC) X-FDA: 76184543190.22.swing48_3c62f945a4630 X-HE-Tag: swing48_3c62f945a4630 X-Filterd-Recvd-Size: 3798 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 Nov 2019 17:06:54 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id m6so834553ljc.1 for ; Fri, 22 Nov 2019 09:06:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tiuOvd7ZDxYtSgBh2c2OGm8DyWFrmWTUE1XqdhfG8K4=; b=WdjUx8aHLHTt5UuYswEH3nf8Iw2OJ/ImfCxyRng69ijN5yGfNTjHk3UPhO1hcKiJKm 7yU4dIeh/8qAvoLie2Ve7ZrsFKEBUtyFXGssszGyfI3pKuxURTlIeAt8SIravFmU41yj pieyrtMPX3X/40G9VZ8NCxbgFxw9T3p+KQSFY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tiuOvd7ZDxYtSgBh2c2OGm8DyWFrmWTUE1XqdhfG8K4=; b=e2/RxpbAatbPZDNiPOGfsLOILFcYpAaxjo1dLlXmFFSjcXYlRHXN1uNcu3tcRtWFIU NjzVXJBwGyOJWixCmSAFeRRuLTotwXdWOmi9bKntmet3fw+Slrx+pHtjylgQ2+clvBNn qLPHl4Vm5WfCQBhtzGzqbKzifBCrr7dbkmu4IvBc5GX3Jy/vjlIhq6IMD8vZYmdlc5SE 3imwwVgGZuUVjqfcxvDM1BaQwLFoHwp/VFkBN1Mo+KMMJQknlczwvExJ9eIpybCPWHhD Ng6Q3ZG2gder1pnTRe2b52ofEOrivDubBq0a6hyxEX+waVbTBURCWaqsRHmWyKXFYLri YXlw== X-Gm-Message-State: APjAAAXhDQ3CcbplXKcOgEYoI8eZbWvk7iY+6Q+hbd/sAFZygiZF+xHD pyKNJ6+jGIn1KMQTyFSbJxVvtkKbK9s= X-Google-Smtp-Source: APXvYqwgATkIMQW92MbAYfA+a7RZ5FtPS2vs5S1EKQfqvlf+9GITeo+c8mluK7HQ/mA8bxJfLehklg== X-Received: by 2002:a2e:970e:: with SMTP id r14mr12790286lji.57.1574442412062; Fri, 22 Nov 2019 09:06:52 -0800 (PST) Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com. [209.85.208.176]) by smtp.gmail.com with ESMTPSA id s20sm3433019lfb.6.2019.11.22.09.06.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2019 09:06:50 -0800 (PST) Received: by mail-lj1-f176.google.com with SMTP id q2so8207004ljg.7 for ; Fri, 22 Nov 2019 09:06:50 -0800 (PST) X-Received: by 2002:a2e:9a8f:: with SMTP id p15mr13114617lji.148.1574442410108; Fri, 22 Nov 2019 09:06:50 -0800 (PST) MIME-Version: 1.0 References: <20191122015349.DnuP3a202%akpm@linux-foundation.org> In-Reply-To: <20191122015349.DnuP3a202%akpm@linux-foundation.org> From: Linus Torvalds Date: Fri, 22 Nov 2019 09:06:32 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [patch 1/4] mm/sparse: consistently do not zero memmap To: Andrew Morton Cc: David Hildenbrand , Linux-MM , Michal Hocko , mm-commits@vger.kernel.org, osalvador@suse.de, pasha.tatashin@soleen.com, Vincent Whitchurch Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Nov 21, 2019 at 5:53 PM wrote: > > AFAICS this difference does not appear to be on purpose. If the code is > supposed to work with non-initialized memory (__init_single_page() takes > care of zeroing the struct pages which are actually used), we should > consistently not zero the memory, to avoid masking bugs. > This does not seem to be an actual fix, and I will not apply it this late in the rc game. Andrew, please stop sending cleanups as "fixes". Linus