From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
Linux-MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>,
mm-commits@vger.kernel.org, osalvador@suse.de,
pasha.tatashin@soleen.com,
Vincent Whitchurch <vincent.whitchurch@axis.com>
Subject: Re: [patch 1/4] mm/sparse: consistently do not zero memmap
Date: Fri, 22 Nov 2019 09:06:32 -0800 [thread overview]
Message-ID: <CAHk-=wj8g5QYgj_DNMG=NAy5rfTfNRMu8P2FOnLCgLiJmajQfA@mail.gmail.com> (raw)
In-Reply-To: <20191122015349.DnuP3a202%akpm@linux-foundation.org>
On Thu, Nov 21, 2019 at 5:53 PM <akpm@linux-foundation.org> wrote:
>
> AFAICS this difference does not appear to be on purpose. If the code is
> supposed to work with non-initialized memory (__init_single_page() takes
> care of zeroing the struct pages which are actually used), we should
> consistently not zero the memory, to avoid masking bugs.
>
This does not seem to be an actual fix, and I will not apply it this
late in the rc game.
Andrew, please stop sending cleanups as "fixes".
Linus
prev parent reply other threads:[~2019-11-22 17:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 1:53 akpm
2019-11-22 17:06 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wj8g5QYgj_DNMG=NAy5rfTfNRMu8P2FOnLCgLiJmajQfA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox