From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AF38EB64DC for ; Sun, 25 Jun 2023 19:42:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5F6AB6B0071; Sun, 25 Jun 2023 15:42:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A5096B0072; Sun, 25 Jun 2023 15:42:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46CCF6B0074; Sun, 25 Jun 2023 15:42:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 34A9E6B0071 for ; Sun, 25 Jun 2023 15:42:47 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CA512C0117 for ; Sun, 25 Jun 2023 19:42:46 +0000 (UTC) X-FDA: 80942292732.21.B580FC9 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf09.hostedemail.com (Postfix) with ESMTP id C7D34140016 for ; Sun, 25 Jun 2023 19:42:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=CMX48g22; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687722164; a=rsa-sha256; cv=none; b=ZVKBNZf+kFvjWd6cz5gzn28Cfs8erq1FKbeqCW0JYXj5yMcsmYzVCE7BV7PZlaHpqRJHjo rU8VHJ9RaxqsQFu/X9foUa4mu1iRChy0NCK5wyY8Dgioq0gn7Z18LsDYQjBM8sG6/yWAZ4 /pPDrn5x+WLdKeqaCmPaB9F14BScxzw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b=CMX48g22; spf=pass (imf09.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.47 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687722164; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6cNRKgxmHmTtoVESwsJ0zJcOrt2AZ+Czjavf35PMjh0=; b=tlqv10zvm/us3Rjpdubm0gplrVMXIDTusqO2Et3w0XeeVqxdOcTKoNrHhNA6ogB3CYLxds 0MEqdo118u/mqExray9r9an2FxlmLo64ITF4APXRo0s+fzCmtLlhnswD+mynM+vglVEGej IRoMP69UJOXKPcAOKYYcYs0fH16XSgM= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-51d805cb33aso2279113a12.3 for ; Sun, 25 Jun 2023 12:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1687722163; x=1690314163; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6cNRKgxmHmTtoVESwsJ0zJcOrt2AZ+Czjavf35PMjh0=; b=CMX48g22msgc7YR6JV/2ZWHeabBqgX82h4oYxNt6w/ZQkh6bItS3G7rVMoN47qChep rWCCLABKQMRtfq6TnV/4JC6dk+8YGFd+U3WJREcdwGFfKwT0AqGO8ic7RKQyWwyfmiiA DXerExsekxVlkZEcXneOKsBoKeDaFP3l5pjfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687722163; x=1690314163; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6cNRKgxmHmTtoVESwsJ0zJcOrt2AZ+Czjavf35PMjh0=; b=bkwIX4G6QgPkPPlNkK7ea2+vTig27lqcwHj7sccmOI22PK7QGRUdFFAs4QjkdVs5AJ nOZm6wAAngFkub+Omtajd+e6ZQbdWg5of2AxTe4SQYZT9lM8Q+U6Jmoj5VAxl69gkjPu iBCQExh0rNh8n6QXyiq2YwdObClbsegUO3fOfo1ZaU60LdDheN/23SKMJ+QEIeMHcjr9 hB7dfPMrfXVK9eaNLF935eu6LbX6Muff0kDqMmq2G68sBbEvtdWiDV9bAvc+0cyvrxAX 8vmLFAvrIxExnAntvoMvaGopoJcp4N+Up6g0QKsEBql53ZLYh0kSKHt/LIGbkyNxWXur Nnaw== X-Gm-Message-State: AC+VfDx6rEfgYsOIVwWcPW3A4Bs/8ZA5uNPrlV4Yo+tcGO1pgr5ymH6T C3q6tj5/XlwtxS4iVU9jT4srHRdrYZcAZZN7HykkICw6 X-Google-Smtp-Source: ACHHUZ6LShPsKI+/XuHXBL2+y/vIQ2rlTEMTvjFCTXK4OzK1KWqo8c+nxfp2JZFkdyXIaCe+uySVVw== X-Received: by 2002:a17:906:974f:b0:98c:df38:517b with SMTP id o15-20020a170906974f00b0098cdf38517bmr11769475ejy.33.1687722163146; Sun, 25 Jun 2023 12:42:43 -0700 (PDT) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com. [209.85.208.42]) by smtp.gmail.com with ESMTPSA id c15-20020a170906528f00b0098866a94f14sm2375978ejm.125.2023.06.25.12.42.41 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Jun 2023 12:42:42 -0700 (PDT) Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51d805cb33aso2279089a12.3 for ; Sun, 25 Jun 2023 12:42:41 -0700 (PDT) X-Received: by 2002:aa7:d758:0:b0:51b:e9d2:f17d with SMTP id a24-20020aa7d758000000b0051be9d2f17dmr7071359eds.27.1687722161610; Sun, 25 Jun 2023 12:42:41 -0700 (PDT) MIME-Version: 1.0 References: <20230607053135.2087354-1-stevensd@google.com> <8ef3ee-ba41-8e9e-4453-73736ff27783@google.com> In-Reply-To: From: Linus Torvalds Date: Sun, 25 Jun 2023 12:42:25 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mm/khugepaged: fix regression in collapse_file() To: Hugh Dickins Cc: David Stevens , Andrew Morton , Peter Xu , Matthew Wilcox , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Jiaqi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C7D34140016 X-Stat-Signature: okgy5zkrwjwzr5hhp6k6whc5r7g5fp4i X-Rspam-User: X-HE-Tag: 1687722164-891078 X-HE-Meta: U2FsdGVkX18jDhS67ylB+/RMYQ8zM1B/ntNI0zWrZjyDT9ZUH9K2GaBGGg1npoF83n7rBEhQpq0DW9j5mpdrQ8FHYY7LZ2Y3rPuPAknmBySq52M+BfS403F5LVUZCdXVCS554tjcPvH1o6oV4MCo3EhhzOIVpJPUqaf9KJqkYwGMgRDRJCG+IQSYevfFppbX4V7wUjGFpxUTJHB4I610ANP08DVplodbExlvwBlAp3c4EJIWGMUmpu822y8OV6ZPW7Jl31cJvYb954qGjoBgCYJhJ0A0iVVdnwkKYZolN/LMxs8SNSqKpM83DqkMAEavveIGal8kphxEW8UqspVBEWXj5tw0lVEhC0HyiDGpRJaMIYkI0v6BlIDGTjoMmS8Wcu33EeF4ClJ/vH+PRBl+l7xNJzd8+47iSWs+1VpDtE/rXmX34Q7bVKytLZ5FF1h85g9WIH2tBZNQZMtDc5N93P+xa8YR8TrueGu6dBCfHOd8g5ACbhtS7uRwBm5ZcHejwoltqU/4+SkkRT08sa7ytHSxFDkOAQiF7OHst4uuLiiGQHarOQx8c0v+MRGXcPyszz3/Li3TcQstdrr6jWzYXquIwgjIlGflphXHn7XHJU4ycKR519NkjaPhyotxIHjla4wmhbtBkku1KKPrEQ8ylIj5h3yCUgkM7esm4XHnBujZwP6W2oonGmIQU7A3Qcdmgj45wiz9NPc5IEgj1OYLNiIvb+Vql+GGU8Zf+nQa0yypua87j2jkuINkNV0tlaOWRYonRueF3R4sk18jdG0TO9MhSUT0fG88EWwjCMFQ9Yr2NqyVE5YtA4M5p1s6x8WjSeGnl71ft3ORB2VtlpYIY+MklflxYM33JCUyYSqk0oOftuJ3ifyoLLx1zWyuk6o4GjVnKCCgs1gYFP+Hfdydk9FlAHFdcyXCa5JfBC8N0jWmGSYUrr5GK+QX+GzpJNcGdt9SSqaLNWyb3Ptx7F4 sgznlzE4 u/v6rIUNdgm1BJHaiLzW1OhUDfpH616aB/BgLIDvzn7rTyv3lCcLVqotnWQoy2j+XrPe+5HXPvBISfKP686M3ymjONV0QXT9Cdv54u/oe3zNg7I36Ajet8pXJbN/mCRKkC07JkL4TrAR4/xT/3dKF7NWk94dFbbQFZ3spXeOSiTiHhjyGDl5XAAKDR1MRPZR8P1WpcJ2sSUDa5qpRCqVt1Q5YQK/q5611tBkhmfluG7F6i64ljYHAchYW5Lqjt9juCO/Vq6noVlTWQMpc2a1Y3UUVWjbQv/eDJuj09SABhpX10ZaSeGOfxtCJF53eO/l4VRFwewoIFbmN6qwdoYqCzy6T9LgF05NH/i9xjWNAmOBTAATOwsMZj1Uvw3JetGE+jlwDXI3Y4wCW3eVI/9uyyypCKnbfQQQ0HUx1uXJOPt72NJHpiQw/Wc5bHAyfhIKnr9Ah0QNzslDPzMwKNvk8jF40lVrPV5gpyOuKGekubU5ubwkIA7/A62h308ZHxhag69Pvj4+s5nLqbVERVVLyyIfCvhQdRmcEpI8XwYF0EkAzf76fz6Z6A6oHdU/7eMxg7937 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 25 Jun 2023 at 12:06, Hugh Dickins wrote: > > Linus, I'm rushing this directly to you, but not really expecting you > to put it in at this stage, unless you're very comfortable with it, > or perhaps it catches Matthew's eye and gets a quick Ack from him. Yeah, the fix and explanation sound fine to me, but the maple tree code confuses me enough and has been subtle enough (as exemplified by this bug and many others) that there's no way I'll apply this just before the final 6.4 without some "Ack, that's obviously correct" from Willy or Liam or somebody. Willy? Linus