From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F27AC2BA19 for ; Sat, 11 Apr 2020 22:03:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF12A20769 for ; Sat, 11 Apr 2020 22:03:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="MUvvXNsB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF12A20769 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4060A8E00B2; Sat, 11 Apr 2020 18:03:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DBE48E0007; Sat, 11 Apr 2020 18:03:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F18D8E00B2; Sat, 11 Apr 2020 18:03:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id 13FC68E0007 for ; Sat, 11 Apr 2020 18:03:00 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C392B8248068 for ; Sat, 11 Apr 2020 22:02:59 +0000 (UTC) X-FDA: 76696950078.01.jar31_544e9d3150958 X-HE-Tag: jar31_544e9d3150958 X-Filterd-Recvd-Size: 3813 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Sat, 11 Apr 2020 22:02:59 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id q19so5250662ljp.9 for ; Sat, 11 Apr 2020 15:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AxTwvLNyEWOqcyAMAl1px4l2VagsXdtElsWFFoHMqrA=; b=MUvvXNsBgMfrf2utiUefNgGNFiz8tc8Ft0POaCCNM8mjBA8s9X3yh2N4pcl2VO4plF zgsBnYEca8khVlPVEAnJq3PsGRt3JkvKkINq01m+F2sKy2CBtt0z9Qcz00Z8C59gDQbY gKZLgQz//ILFSG7Ir8gaz/C4iH7pzhhrvxXDw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AxTwvLNyEWOqcyAMAl1px4l2VagsXdtElsWFFoHMqrA=; b=ftOxODBIvhc4JNxoNUnt4bLrcBXYADW8AZD5TxnleF8V8E8xPyf7vVIPfX+9a9k8Oy m4tOj/O6NwZIaYPaMLXFmG2h3pX7QsOVCiwgTbIl6E/mO/N8mVwLXPx3pnHb/k63bcWt +OHg9kc3u3oVt0HSJ36hI5l/LarZoZckXeOPaR/eaqraZf0QCTjlz7xabKGn8YQDth1y 4butPzy517pQxHfEeBDangsLMuF4DgpntCJUW9ht3m/aWcyDbkqP6+OXa9ADvUmLKz3Q ldEK/7t7VDrykrrxtUo+c+91BcroDaYj/5AqIE3eSIU4L1iK7N6FTLSJIiP8n9qIw2ll JrCA== X-Gm-Message-State: AGi0PuZ+NxB/Rrylzbo9hjb5BW4bTTm/z2QNTO2U+BbeFjIjET3weKmT t9kknQL2uar1UFYX77xKiciTLRd0TDY= X-Google-Smtp-Source: APiQypKelGtLl+aVadFiep05KxGYRxAVHhKdcmUqfwnK9SA11vyJ2lubDjSo/6WFrG1ZBpGNW/ULZA== X-Received: by 2002:a2e:900c:: with SMTP id h12mr6670362ljg.290.1586642577174; Sat, 11 Apr 2020 15:02:57 -0700 (PDT) Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com. [209.85.208.173]) by smtp.gmail.com with ESMTPSA id w16sm4697066lfk.49.2020.04.11.15.02.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Apr 2020 15:02:56 -0700 (PDT) Received: by mail-lj1-f173.google.com with SMTP id z26so5262319ljz.11 for ; Sat, 11 Apr 2020 15:02:56 -0700 (PDT) X-Received: by 2002:a2e:7c1a:: with SMTP id x26mr6273872ljc.209.1586642575880; Sat, 11 Apr 2020 15:02:55 -0700 (PDT) MIME-Version: 1.0 References: <20200411203220.GG21484@bombadil.infradead.org> <20200411214818.GH21484@bombadil.infradead.org> In-Reply-To: <20200411214818.GH21484@bombadil.infradead.org> From: Linus Torvalds Date: Sat, 11 Apr 2020 15:02:40 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [GIT PULL] Rename page_offset() to page_pos() To: Matthew Wilcox Cc: linux-fsdevel , Linux-MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 11, 2020 at 2:48 PM Matthew Wilcox wrote: > > I wasn't entirely forthcoming ... I actually want to introduce a new > > #define page_offset(page, x) ((unsigned long)(x) & (page_size(page) - 1)) No, no, no. THAT would be confusing. Re-using a name (even if you renamed it) for something new and completely different is just bad taste. It would also be a horrible problem - again - for any stable backport etc. Just call that "offset_in_page()" and be done with it. Linus