From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C38AC3600C for ; Mon, 31 Mar 2025 15:35:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D161280007; Mon, 31 Mar 2025 11:35:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 48235280002; Mon, 31 Mar 2025 11:35:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3228D280007; Mon, 31 Mar 2025 11:35:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 143B7280002 for ; Mon, 31 Mar 2025 11:35:28 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 98C6A8170C for ; Mon, 31 Mar 2025 15:35:28 +0000 (UTC) X-FDA: 83282245536.26.955A5C7 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf27.hostedemail.com (Postfix) with ESMTP id 6C29440004 for ; Mon, 31 Mar 2025 15:35:26 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="dAxGl/BY"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743435326; a=rsa-sha256; cv=none; b=B2kSXJ2zO9uyAkIbDRZinx96k3M//Iipf2KNPqEbXk5BX+vtARCKJrINpO6dFixaxIlZWZ 0/ae1bCBe2u8pHhIqUua/abEs/gJlZRqlGYlDxeNF/shpe2IcClrqK0Ha6eNOuDkYH5n+X 7ij0ZMzL/fq8Ru50u3NPNnCKEpGBLQQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=google header.b="dAxGl/BY"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of torvalds@linuxfoundation.org designates 209.85.208.52 as permitted sender) smtp.mailfrom=torvalds@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743435326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YO0dREAco9t7gPO+WazvaPupC7wRyoflD+tJnxLDjG0=; b=MarXLE4fZU/qjUjOur+SUVAy6B7YxcH0CpdyXHWsbEYTNv2ZnW1pczx2l56BM5ZKorPjzR b8HThbE6BURCg3FrIZtlK7hQWqlGdQevk+4+KkEVgS/mfeYvfzfqCvhZ2P1YsqdUR5sGw3 dwpauZkHHI1G/OrZexmVPZU/oz7Fy48= Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5e6c18e2c7dso8446631a12.3 for ; Mon, 31 Mar 2025 08:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1743435325; x=1744040125; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=YO0dREAco9t7gPO+WazvaPupC7wRyoflD+tJnxLDjG0=; b=dAxGl/BYGthJKQF/hzuHOLLvc0iiQ9OPmzsj8GAxsDHhEURJmEJsSHJjiHpXPxNM3f UIoeWOj2OcEXKn0LmtXc5bMLR3FdPiomJyOz9b8lBMOQPtk9URhN3L4bgwuxSePU7kdX N+lh8TXHtn4Tx+3ob+h8KpkC/1I+5SQtM00/I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743435325; x=1744040125; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YO0dREAco9t7gPO+WazvaPupC7wRyoflD+tJnxLDjG0=; b=UAz2zDX6xlsI5kS0qr3s2GNkagcmBM2e6baLlOarcCuMVsaUrQWH4VMMU+QsgmBfZS JqGQ3MUd0DlwC2WdrdeqzKetIy5Ejy51WwCd1eh+PpFgHjxKlIeSQeBdRPbJlKPb9BF+ +MbGvStojVahE7GLcAeckuU7xxse8HkCEbWXSFCDrKsY4TmfUwPQI/tvG3jPxdUD++Do JJNwaBX4GIBLKsgEuAaS+hIwRujz1Ww2Hh1o1AfEIyXRAKIbaeb1dzYQZOm7cUyrdeAj eApzVQih2mGY0CEhjZVyuyQ8ggPQV13ypTd+/MlOPvwBS3GYX3l8HVRs8iCg095hJF1p KRnA== X-Forwarded-Encrypted: i=1; AJvYcCXnVBKsDrYUNwZFZdNORUydHkiWzVJhZfhi9g4Gv88Wkw4TrB/2MMqA7zlOgE5Ish4iTy6Hgm/iyQ==@kvack.org X-Gm-Message-State: AOJu0YyGDtLGmHcC8BEWqNBT3s5C9llmD0RhJKYUvR/ZEKS9HHNck2SO GK7vQPYOLDRGAE13vwIEV3xZjYenBnk+68NnwY1X5G4wKbknsmx1p5vxy6OZSzTJBjnwE2CaeR2 17RQ= X-Gm-Gg: ASbGncsNfm1MsDRESfyI1CSjdH+KTHy2/4fQjlu4U6xmesBRLf3nve6gNI8vyCFXdDb uGSyUXk3sAvIVZcn/PlmPP6U4WeQTq5lZNZ7pYMz1gJgKKzW9SkKjRQo4kQbWgHtH/UtsJD0TSi u2TAvBwkPEdBI4UgCdnyRXXQyzbnpLXsSh+ZymMhUR32mrvm9S2lfHCPL3KRj8VuKwsQvQatsgs ojrrztIkEM7xZKwlwTzKu4/arCVyRC9lbR0rA58wVV8fSE4eGx+7jzZ4EI5qtgXgz4HB7hHYMSU p9/K+aNy+jb+sAdhsLHg8W/31OIE034kSZPjKXLxQ2gfYX8u5PRRYCRFePC48EWfDn16Ipxvp3t 9Kyu6so7NuSNNqq+BNkE= X-Google-Smtp-Source: AGHT+IEnxEOBDUswJ13/FXL4+E8mXGLPwv1VUfF45cB/XalYJXPYXyAKb4wRGoVkcvmljt9DX67TNg== X-Received: by 2002:a05:6402:400f:b0:5ee:497:d714 with SMTP id 4fb4d7f45d1cf-5ee0497da1fmr8227565a12.34.1743435324523; Mon, 31 Mar 2025 08:35:24 -0700 (PDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5edc17e0042sm5786100a12.80.2025.03.31.08.35.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Mar 2025 08:35:23 -0700 (PDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-abec8b750ebso719392766b.0 for ; Mon, 31 Mar 2025 08:35:22 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVPVGgaDx0XEmSnRnUei21uP2weu1vnvnLhP/9V2br5iRaZ4LpKxzkTZgg576tcB6T2azY9IZU+ow==@kvack.org X-Received: by 2002:a17:907:3e03:b0:ac3:b115:21b8 with SMTP id a640c23a62f3a-ac738c21274mr750571766b.47.1743435322576; Mon, 31 Mar 2025 08:35:22 -0700 (PDT) MIME-Version: 1.0 References: <20250327145159.99799-1-alexei.starovoitov@gmail.com> <20250331071409.ycI7q6Q2@linutronix.de> <39586553-6185-4b83-b18a-3716caf2f3cf@suse.cz> In-Reply-To: <39586553-6185-4b83-b18a-3716caf2f3cf@suse.cz> From: Linus Torvalds Date: Mon, 31 Mar 2025 08:35:05 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AQ5f1JpPp2rq7h82rgAtWGoIctm8Ha-dBePer7BRjKEaDaPgda8D0EyYKeuC6qY Message-ID: Subject: Re: [GIT PULL] Introduce try_alloc_pages for 6.15 To: Vlastimil Babka Cc: Sebastian Sewior , Alexei Starovoitov , bpf , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Andrew Morton , Peter Zijlstra , Steven Rostedt , Michal Hocko , Shakeel Butt , linux-mm , LKML Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6C29440004 X-Stat-Signature: sugbeh8nx719b6oqmsn9aue5g9m74fk1 X-HE-Tag: 1743435326-742761 X-HE-Meta: U2FsdGVkX1+imNqjIBWG0RRZ3F7cn1Yz4VEYWniWM/KZDSPacgKrbg4noylQyOzeYNG1orgGx8WP0FC4fv7rrrIAue5cmsQI1HzryCx0QGvYPiz7ckR73GVOCsxyUV31ADjCIFXsgmqEHWCo0gOHdxqAChJM58Ylx+Q26Gwb/Greiiebp/iM1S47AhFfwirRJuySEuvUq7hz3O+wWAPm8SIoKNJnc7B34zahq3b9X1uQDSpHgEO6OYr69cOwuKgG4YVT/H4YJRthpFfIk2JbifdSfR+Qa2X0gbbfxYGEj/5Ds+wsx+wjuOBuEbX/jBIiQwpLYIO3PgEpz7+fYPqGc9DV3B/VJC19xKR0Sh3UWgdVTNgAXbr790acB+1gC2AgJmeOA8eu4fozINdsRAw+THtylDHb6Y6/WL5mLmYQ+pbcqvvt/v32d6X2KOKtQ+T3Rkv7sMnND/RnizuqvJSNWrJ0VcLBqcnGl7Q+7I1eEMl/XPhjkpdz07gvfB5m6vuw0kknb8Fg0ybKVNM4yi7mJuVz1lnMPWEmHsFDDKODJpEYboAMdxVB5SF6ULlW7YudY1t83xAQ4LP4vDqB/3RZbJWOa/XIalAmuPhFt/ROc4bEGEH+XcCYkiuOdsUMJ+qCv2YsH1GqOSgp2GyVQUukaZPa5e2SRpGJvxyr4DShDg1KujwuT1pZfLC99SHc8OYp3Ak1iYd3I2ctZdVFZ+NYHdRNBC729lkoAWoHaEHsbZCui0W3TvH6muScNfLp8pR2Z+4LBy6OIWQtro2AD/XzzMAEmb/+gSoPuU7367wfeyyVgFo3gAPWvpId8dszk1CUXCXIEEb6sDYEJNWuG0hSvwGbfBzfqEeR8eXacJWSeYgkjhwly7nuABnXmlQtXHB6poIziRBI8dzwXZGslQaCqFdtQIPh9kO7J02iRcG0kytk1gON7le1dKgJ2MM6arpRkB90oTwyO9oW8c33hop OQHdc3y8 Iie6PralS+enw/eFlSqI9qBnNUAJ6rje6c2O3L9P9uJjBJO1rESQ6xnLsLnB9mUWa1EHOa3HjxZE9yQzvLKFD7fntP5BJm1s8qXMxzSwE/z1Mv5/+qhDOdF04jlehORxI9Cx7bwNroT7FBYtZVaz9BOoqDZiGZxnS29hkr1ZQ2V5gVbZapEkNouLMGHmn8Fml2h3iYxW+dX+72jUrC9cA8HPLOEriuM8Nkjhlx0Ip/PWUEC2VwNMiadTkT+T6lPSYsBOULPFFaROZEcItg6ZGGD9Aho2IvZSTbrDjymC0IxdaL/aHZyqtd6yqzK7Ik6cPo6RAziN4QxNMTLdJ7fwN2JW9SJMsq15Kt144OsxArnWHl1p9tu2n2g/PQ3+AP9PvShfmu1XsC4tGLcPcKikkeI03bvnBccN24QHQwAY+F4cNy9ezoowVNrOI7Flh//F9U8Wm8xGowjYdBr+aXKo+cjCbXAp6S3Bx4gd6Zf8Zk+Fd3P7dFhFNajuCYE5fRagDkynJEhjxHjsnQkzsa7LCLr6PzO6/mOGfTwWlcoNB8Irb2LlLNKuOvg8QMSWazICI70tu1Ez67Z5rOCLE3c/RIUZPe9kbA/mmRhGE9qqbxC75iLddZyPVbFBT6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 31 Mar 2025 at 02:59, Vlastimil Babka wrote: > > Yes I was going to point out that e.g. "nmisafe_local_lock_irqsave()" seems > rather misleading to me as this operation is not a nmisafe one? Yeah, it's not a great name either, IO admit. > The following attempt [2] meant there would be only a new local_trylock_t > type, but the existing locking operations would remain the same, relying on > _Generic() parts inside them. Hmm. I actually like that approach. That avoids having the misleading operation naming. IOW, you'd not have a "localtry" when it's not a trylock, and you'd not have "nmisafe" when it's not an operation that is actually nmi-safe. The downside of _Generic() is that it's a bit subtle and can hide the actual operation, but I think that in this situation that's the whole point. So yes, I'd vote for the "let's just introduce the new type that has the required 'acquired' field, and then use a _Generic() model to automatically pick the right op". Linus